[issue5115] Extend subprocess.kill to be able to kill process groups

Gregory P. Smith added the comment: this is part of a chain of other related issues. the interesting thing in the patch in here is the potential feature to have send_signal/terminate/kill be able to optionally kill a process group. the logic as is in the patch in this issue is dangerous as

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Gregory P. Smith : -- resolution: -> duplicate superseder: -> subprocess.run timeout does not function if shell=True and capture_output=True ___ Python tracker ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Gregory P. Smith : -- pull_requests: -7893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by haizaar : -- nosy: +haizaar ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Ammar Askar : -- pull_requests: +7893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Fangyi Zhou : -- nosy: +fangyizhou ___ Python tracker ___ ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Eryk Sun added the comment: Using a Windows job object should be paired with the creation flag CREATE_SUSPENDED. Callers may also need CREATE_BREAKAWAY_FROM_JOB, but setting that creation flag shouldn't be integrated into Popen. The child has to be created suspended to ensure it doesn't spawn

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Xuanji Li xua...@gmail.com: -- nosy: +xuanji ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___ Python-bugs-list mailing list

[issue5115] Extend subprocess.kill to be able to kill process groups

Charles-Francois Natali neolo...@free.fr added the comment: Note that the setpgid creation part is now somewhat redundant with Popen's start_new_session flag (which calls setsid). Also, this should probably be an option, since with that patch every subprocess is in its own process group. I

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Ernst Sjöstrand ern...@gmail.com: -- nosy: +Ernst.Sjöstrand ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___ Python-bugs-list

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' g.rod...@gmail.com: -- versions: +Python 3.3 -Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Giampaolo Rodola' g.rod...@gmail.com added the comment: A strong +1 on adding this feature. I was wondering... what if process A runs a subprocess B which runs a subprocess C. Is C still considered a children of A and gets killed as well? Does os.setpgid() takes care of such a thing? What

[issue5115] Extend subprocess.kill to be able to kill process groups

STINNER Victor victor.stin...@haypocalc.com added the comment: erickt: can you fix your patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' g.rod...@gmail.com: ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Thomas Guettler guet...@thomas-guettler.de: -- nosy: +guettli ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___

[issue5115] Extend subprocess.kill to be able to kill process groups

STINNER Victor victor.stin...@haypocalc.com added the comment: I suspect that on Windows, TerminateJobObject won't work with a handle returned by CreateProcess. TerminateJobObject works with CreateJobObject and AssignProcessToJobObject. The following code (from your patch) should call

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Brian Curtin cur...@acm.org: -- priority: - normal stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Brian Curtin cur...@acm.org: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___ ___ Python-bugs-list mailing

[issue5115] Extend subprocess.kill to be able to kill process groups

Amaury Forgeot d'Arc amaur...@gmail.com added the comment: I suspect that on Windows, TerminateJobObject won't work with a handle returned by CreateProcess. A solution could look like http://www.mobzystems.com/code/killprocesstree.aspx -- nosy: +amaury.forgeotdarc

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' billiej...@users.sourceforge.net: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5115 ___

[issue5115] Extend subprocess.kill to be able to kill process groups

New submission from Erick Tryzelaar idade...@users.sourceforge.net: It would be really handy to add a way to portably kill process groups of a process spawned with subprocess.Popen. My project starts a process, which then starts other long running processes. Because of this process tree,