Giampaolo Rodola' added the comment:
I have 2 complaints about this:
1 - doc is missing: the only way to be aware of this is either by reading the
3.6 what's new doc or by checking the cmdline helper
2 - -j "N" parameter could be optional: if not specified os.cpu_count() can be
used.
Roundup Robot added the comment:
New changeset fc28c67fbbd3 by doko in branch 'default':
- Modules/Setup.dist: remove time extension duplicate, introduced by the fix
for #5309.
https://hg.python.org/cpython/rev/fc28c67fbbd3
--
___
Python tracker
Roundup Robot added the comment:
New changeset 107669985805 by Berker Peksag in branch 'default':
Add whatsnew entry for issue #5309.
https://hg.python.org/cpython/rev/107669985805
--
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
Here's a doc patch.
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file37824/issue5309-doc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
Julian Taylor added the comment:
very nice, thanks for adding this.
coincidentally numpy added the same to numpy.distutils independently just a
week later, though numpy also accepts an environment variable to set the number
of jobs.
This is useful for e.g. pip installations where one does not
STINNER Victor added the comment:
It looks like compilation of Python 3.5 fails on FreeBSD 6.4 because of the
changeset bbe57429eba0a9ec21fb0f1178f409f1bba44c22:
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x/builds/5061
Compile log:
---
building '_ctypes' extension
STINNER Victor added the comment:
There is a similar error on OpenIndiana buildbot, Python cannot be compiled
since this build:
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/8664/steps/compile/logs/stdio
gcc -fPIC -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
Antoine Pitrou added the comment:
Thanks for noticing this.
Looking at an old build, the ctypes and curses compile errors under OpenIndiana
are not new:
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/8658/steps/compile/logs/stdio
Simply, it seems that a ctypes compile
STINNER Victor added the comment:
the ctypes and curses compile errors under OpenIndiana are not new
FYI the compilation error of curses on OpenIndiana is *old*, at least 3 years
old :-(
http://bugs.python.org/issue13552
I just opened the issue #22521 for the compilation error of ctypes on
Jonas Wagner added the comment:
I don't understand where this error comes from...
The compilation commands are exactly the same in both the before and after
logs. The order of commands is also the same.
The only difference is this message:
*** WARNING: renaming _ssl since importing it
Roundup Robot added the comment:
New changeset 94af1af93670 by Antoine Pitrou in branch 'default':
Remove pointless vile hack that can cause the build step to fail when some
extension modules can't be imported.
https://hg.python.org/cpython/rev/94af1af93670
--
Antoine Pitrou added the comment:
The change I just pushed should fix the failures, waiting for the buildbots to
compile now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
Antoine Pitrou added the comment:
Looks ok on OpenIndiana, closing now.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
Roundup Robot added the comment:
New changeset bbe57429eba0 by Antoine Pitrou in branch 'default':
Issue #5309: distutils' build and build_ext commands now accept a ``-j``
https://hg.python.org/cpython/rev/bbe57429eba0
--
nosy: +python-dev
___
Python
Antoine Pitrou added the comment:
This is now pushed.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
Antoine Pitrou added the comment:
Updated patch raising DistutilsOptionError. I couldn't find any docs so I
didn't update them :-)
--
Added file: http://bugs.python.org/file36671/build_ext_parallel6.patch
___
Python tracker rep...@bugs.python.org
Jonas Wagner added the comment:
I've checked the `dlopen` issue. This was due to a problem with
UndefinedBehaviorSanitizer, and was solved by upgrading to Clang 3.5. It has
little to do with this patch.
Using this patch and http://bugs.python.org/issue22359 , I now get reliable
parallel
Éric Araujo added the comment:
self.parallel = int(self.parallel) would raise ValueError when a
non-number is passed. I suggest to print user-friendly error message.
The distutils idiom would be to catch the TypeError/ValueError and raise
DistutilsOptionError. Higher layers convert that to
Antoine Pitrou added the comment:
Updated patch:
- add the -j option to the build command as well (even though it's only used
by build_ext)
- in setup.py, only force parallel compilation if make was called with -j
--
Added file:
Changes by Antoine Pitrou pit...@free.fr:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
___
Arfrever Frehtes Taifersar Arahesis added the comment:
- Is support for infinite jobs planned?
(GNU make supports it for -j without number argument.)
- self.parallel = int(self.parallel) would raise ValueError when a non-number
is passed. I suggest to print user-friendly error message.
Changes by Jonas Wagner jonas.wag...@epfl.ch:
--
nosy: +Sjlver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
___
Python-bugs-list mailing
Jonas Wagner added the comment:
Is there a reason this has not landed? The patch works perfectly for me, except
for one issue:
@@ -268,6 +275,9 @@
if self.undef:
self.undef = self.undef.split(',')
+if self.parallel:
+
Stefan Behnel added the comment:
Yes, please. The sequential build in distutils is very annoying.
(too late for Py3.4, though, I guess...)
--
nosy: +scoder
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
Jonas Wagner added the comment:
With this patch, and on Ubuntu 14.04, occasionally modules fail to build with
the following error:
*** WARNING: renaming _testbuffer since importing it failed: dlopen: cannot
load any more object with static TLS
I'm not 100% sure if this is really due to the
Antoine Pitrou added the comment:
Here is a working patch.
--
keywords: +patch
Added file: http://bugs.python.org/file32378/build_ext_parallel.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
Antoine Pitrou added the comment:
Here is an updated patch which only enables parallel building in setup.py.
--
Added file: http://bugs.python.org/file32380/build_ext_parallel2.patch
___
Python tracker rep...@bugs.python.org
Christian Heimes added the comment:
Antoine's patch doesn't work for a fresh copy of Python
- add import error report to build_ext parallel (distutils doesn't use logging
and doesn't have a working log.exception() function)
- make time a builtin module
- add hack for concurrent.futures.process
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
title: setup.py doesn't parallelize extension module compilation - distutils
doesn't parallelize extension module compilation
___
Python tracker
29 matches
Mail list logo
