Mark Dickinson dicki...@gmail.com added the comment:
The latest patch looks good to me, and results in a much cleaner looking
_struct.c. Thank you!
One worry: the issue 4228 discussion suggests that the zipfile module
still relies on the deprecated wrapping. I think this needs to be
Andreas Schawo andreas.sch...@gmail.com added the comment:
Hi Mark,
I've removed all overflow masking from _struct.c.
Running the regression test test_struct failed for test_issue4228 wich I
think have to be removed too because it tests the deprecated feature.
I've tested the constraints
Changes by Andreas Schawo andreas.sch...@gmail.com:
Removed file: http://bugs.python.org/file13288/get_ulong_patch.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5463
___
Mark Dickinson dicki...@gmail.com added the comment:
Thanks for the patch! Certainly it's desirable to get rid
of this warning, especially as in this case the warning indicates
a genuine problem: namely that there's unused code floating around.
I think it would not be unreasonable to simply
New submission from Andreas Schawo andr...@schawo.de:
When compiling the newest 3.x trunk I've got a compiler warning that
get_ulong is defined but never used.
I moved the function near the only place where it is used (disabled code).
Now I have no more warnings.
I don't know if it's of any
