[issue5665] Add more pickling tests

Collin Winter added the comment: Committed as r71408 (trunk) and r71638 (py3k). -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue5665] Add more pickling tests

Benjamin Peterson added the comment: Ok. Thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue5665] Add more pickling tests

Collin Winter added the comment: Yes, I'm porting them. I got started, but got distracted by other things since there were a lot of conflicts in the merge -- ___ Python tracker _

[issue5665] Add more pickling tests

Benjamin Peterson added the comment: Collin, can you port these new tests to Py3k? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue5665] Add more pickling tests

Collin Winter added the comment: > Ok if it doesn't take too long to run the tests (which may imply > implementing something like Raymond's suggestion of randomizing test > order, if you haven't already done so). I did something similar: if you don't pass the -uxpickle flag to regrtest, only a

[issue5665] Add more pickling tests

Antoine Pitrou added the comment: > If no-one has any objections to the xpickle resource included in the > latest version of the patch, I'd like to commit this soon so that we can > be more confident in the other changes I have queued up. If I no-one > objects, I'll commit this sometime early to

[issue5665] Add more pickling tests

Collin Winter added the comment: If no-one has any objections to the xpickle resource included in the latest version of the patch, I'd like to commit this soon so that we can be more confident in the other changes I have queued up. If I no-one objects, I'll commit this sometime early tomorrow mo

[issue5665] Add more pickling tests

Changes by Collin Winter : Removed file: http://bugs.python.org/file13571/pickle_tests.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue5665] Add more pickling tests

Collin Winter added the comment: Updated the patch to include a regrtest xpickle resource, which restricts if the backwards compat tests will be run. For normal development, the existing tests should be fine; you only need these tests if you're mucking with the pickle output. Added backwards co

[issue5665] Add more pickling tests

Raymond Hettinger added the comment: The buildbots should be running with the resource enabled (run the full set of tests, every time). If we need the reproducible results with the resource disabled, then a random seed (different for each successful run) can be saved in a logfile so that a part

[issue5665] Add more pickling tests

Antoine Pitrou added the comment: Raymond, how would you reconcile your random approach with the fact that buildbots only display errors after a second verification run? -- ___ Python tracker __

[issue5665] Add more pickling tests

Antoine Pitrou added the comment: > test_xpickle currently takes over three minutes on my MacBook Pro to > test compatibility with Python 2.4, 2.5 and 2.6, and adding tests for > the pickle module will at least double that, if not push it well above > 10 minutes. Ouch! A couple of minutes is al

[issue5665] Add more pickling tests

Raymond Hettinger added the comment: We took a similar issue in test_decimal and came up with a better approach to using the resource flag. If the resource is not enabled, the tester runs a random subset of the tests. Over time, that means that all the tests will get run even if testers are ro

[issue5665] Add more pickling tests

Collin Winter added the comment: test_xpickle currently takes over three minutes on my MacBook Pro to test compatibility with Python 2.4, 2.5 and 2.6, and adding tests for the pickle module will at least double that, if not push it well above 10 minutes. That's why I recommend using the resource

[issue5665] Add more pickling tests

Antoine Pitrou added the comment: How much is "very slow"? If it's less than 10-15 seconds I think it's ok. -- nosy: +pitrou ___ Python tracker ___ __

[issue5665] Add more pickling tests

Collin Winter added the comment: I've made test_xpickle support Python 2.4 because it uses Python 2.4, 2.5 and 2.6 to check that we haven't broken backwards compatibility with those versions. I made AbstractCompatTests use cPickle because that's what I've been changing :) I can add tests for th

[issue5665] Add more pickling tests

Alexandre Vassalotti added the comment: Overall, the patch looks good. I haven't reviewed the patch thoroughly yet, but there is a few things I am not sure about. First, why do you bother supporting 2.4 (i.e. with a copy of run_with_locale) in a patch aimed at 2.7? In test_many_puts_and_gets()

[issue5665] Add more pickling tests

Changes by Antoine Pitrou : -- nosy: +alexandre.vassalotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue5665] Add more pickling tests

New submission from Collin Winter : The attached patch adds more tests for pickling: - Add tests for the module-level load() and dump() functions. - Add tests for cPickle's internal data structures, stressing workloads with many gets/puts. - Add tests for the Pickler and Unpickler classes, in par