[issue5671] Speed up pickling of lists in cPickle

Alexandre Vassalotti added the comment: It is too late now for the 2.x version. And, the huge patch in issue 9410 includes an updated version of this patch for 3.x. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Add Unladen Swallow's o

[issue5671] Speed up pickling of lists in cPickle

Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue5671] Speed up pickling of lists in cPickle

Changes by Garen : -- nosy: +Garen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailma

[issue5671] Speed up pickling of lists in cPickle

Sean Reifschneider added the comment: pickle_batch_list_exact_py3k.diff applies cleanly on current py3k trunk and passes tests. cpickle_list.patch applies cleanly against 2.x trunk and passes "make test". I don't see any objections brought up about this set of patches, so we can get these a

[issue5671] Speed up pickling of lists in cPickle

Skip Montanaro added the comment: Still applies cleanly (with a little fuzz) to the trunk after applying the issue 5683 patch. Tests all still pass (including xpickle w/ 2.4, 2.5, 2.6 available). -- nosy: +skip.montanaro ___ Python tracker

[issue5671] Speed up pickling of lists in cPickle

Collin Winter added the comment: I've added a microbenchmark to perf.py called pickle_list. Running that on this change (perf.py -r -b pickle_list): pickle_list: Min: 1.126 -> 0.888: 26.86% faster Avg: 1.154 -> 0.906: 27.43% faster Significant (t=115.404547, a=0.95) That's probably the upper b

[issue5671] Speed up pickling of lists in cPickle

Antoine Pitrou added the comment: A micro-benchmark of Collin's patch: python -m timeit -s "import cPickle; l=range(150)" "cPickle.dumps(l, protocol=-1)" * before: 12.1 usec per loop * after: 10.1 usec per loop => 15% faster on a favorable case -- nosy: +pitrou _

[issue5671] Speed up pickling of lists in cPickle

Changes by Alexandre Vassalotti : -- versions: +Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue5671] Speed up pickling of lists in cPickle

Alexandre Vassalotti added the comment: Here's a patch for py3k. I also added a special-case for 1-item lists. -- nosy: +alexandre.vassalotti Added file: http://bugs.python.org/file13595/pickle_batch_list_exact_py3k.diff ___ Python tracker

[issue5671] Speed up pickling of lists in cPickle

Collin Winter added the comment: No, we haven't started looking at other serialization formats yet. Marshal will probably be my next target, with json being a lower priority. There were enough instances of low-hanging fruit in cPickle that I didn't go looking at the other implementations for ide

[issue5671] Speed up pickling of lists in cPickle

Raymond Hettinger added the comment: Out of curiousity, are you also benchmarking against marshal and json? ISTM, that there is always one of them that will be the fastest and that the others should mimic that approach. -- nosy: +rhettinger ___ Pyth

[issue5671] Speed up pickling of lists in cPickle

New submission from Collin Winter : The attached patch adds another version of cPickle.c's batch_list(), batch_list_exact(), which is specialized for "type(x) is list". This provides a nice performance boost when pickling objects that use lists. This is similar to the approach taken in issue 5670