Ezio Melotti ezio.melo...@gmail.com added the comment:
Fixed in r77442 (trunk) and r77443 (release26-maint), thanks!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5827
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
assertTrue() also accepts a 'msg' argument where to explain what went
wrong in case of failure [1].
[1]:
http://docs.python.org/library/unittest.html#unittest.TestCase.assertTrue
--
___
Python
Erik Carstensen sandb...@virtutech.com added the comment:
Also, assertTrue has an alias failUnless which I personally find more
descriptive (I don't know if either form is preferred for inclusion in
Python though).
--
___
Python tracker
Ezio Melotti ezio.melo...@gmail.com added the comment:
failUnless is deprecated in Python3.1 [1]. The assert* methods are
preferred over the fail* ones that are now deprecated.
[1]:
http://docs.python.org/3.1/library/unittest.html#unittest.TestCase.failUnless
--
Matt Giuca matt.gi...@gmail.com added the comment:
Thanks Ezio.
I've updated the patch to incorporate your suggestions.
Note that I too have only tested it on Linux, but I tested both
posixpath and ntpath (and there is no OS-specific code, except for the
filenames themselves).
I'm not sure if
Ezio Melotti ezio.melo...@gmail.com added the comment:
Thanks for the patch, I tried it on Linux and it seems to solve the problem.
A few comments about it:
1) I'd change all the self.assertEqual(type(posixpath.normpath(u)),
unicode) to self.assertTrue(isinstance(posixpath.normpath(u),
New submission from Matt Giuca matt.gi...@gmail.com:
In the Python 2.x branch, os.path.normpath will sometimes return a str
even if given a unicode. This is not an issue in the Python 3.0 branch.
This happens specifically when it throws away all string data and
constructs its own:
Changes by Matt Giuca matt.gi...@gmail.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5827
___
___
Python-bugs-list
