Antoine Pitrou pit...@free.fr added the comment:
The various structures now contain several 'boolean' flags. It would
improve memory usage to use bitfields. Or would this impact performance
?
Those structures usually allocate a 4KB- or 8KB- buffer each, so I don't
think squeezing two or
Antoine Pitrou pit...@free.fr added the comment:
The new patch looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5883
___
___
Benjamin Peterson benja...@python.org added the comment:
Applied in r72175.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5883
___
Antoine Pitrou pit...@free.fr added the comment:
Reviewers: ,
Please review this at http://codereview.appspot.com/52075
Affected files:
Doc/library/io.rst
Lib/_pyio.py
Lib/test/test_io.py
Modules/_io/bufferedio.c
Modules/_io/textio.c
--
Antoine Pitrou pit...@free.fr added the comment:
http://codereview.appspot.com/52075/diff/1/2
File Doc/library/io.rst (right):
http://codereview.appspot.com/52075/diff/1/2#newcode366
Line 366: Disconnect this buffer from its underlying raw stream and
return it.
This sentence is a bit ambiguous.
Benjamin Peterson benja...@python.org added the comment:
Thanks for the review! New patch attached...
--
Added file: http://bugs.python.org/file13824/detach.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5883
New submission from Benjamin Peterson benja...@python.org:
Here's the detach() implementation for BufferedIOBase and TextIOBase.
--
assignee: benjamin.peterson
components: IO
files: detach.patch
keywords: patch
messages: 86830
nosy: benjamin.peterson, pitrou
severity: normal
status:
Changes by Benjamin Peterson benja...@python.org:
Added file: http://bugs.python.org/file13821/detach.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5883
___
