Alexandre Vassalotti alexan...@peadrop.com added the comment:
The patch was merged to 3.x in r74132.
--
assignee: jyasskin -
nosy: +alexandre.vassalotti
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
Jeffrey Yasskin jyass...@gmail.com added the comment:
Committed to trunk in r72879. I'll wait to merge it to 3.x until 3.1 has
been released, since we're approaching the release candidate there.
--
stage: patch review - committed/rejected
___
Python
Changes by Jeffrey Yasskin jyass...@gmail.com:
--
assignee: - jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6042
___
___
Antoine Pitrou pit...@free.fr added the comment:
I'm not sure why you changed PyCode_CheckLineNumber to
_PyCode_CheckLineNumber. Other than that, I suppose you know what you're
doing :)
--
___
Python tracker rep...@bugs.python.org
Jeffrey Yasskin jyass...@gmail.com added the comment:
I had two reasons to change PyCode_CheckLineNumber to
_PyCode_CheckLineNumber: First, its behavior is changing without its
signature changing. Without a name change, that could break users
silently (if there are any codesearch missed).
Jeffrey Yasskin jyass...@gmail.com added the comment:
I've fixed #1689458. Here's a new version of the patch with the
simplifying tweaks to PyCode_CheckLineNumber() so y'all can see what
that looks like.
If I don't get any substantive comments by the weekend (thanks Antoine
for the docs +1 :),
Antoine Pitrou pit...@free.fr added the comment:
I can't say anything about the simplification since I never use tracing,
but +1 at least on the doc cleanup.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6042
Georg Brandl ge...@python.org added the comment:
Jeffrey, while you're at lnotab stuff, could you have a look at #1689458
as well?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6042
New submission from Jeffrey Yasskin jyass...@gmail.com:
lnotab-based tracing is very complicated and isn't documented very well.
There were at least 3 comment blocks purporting to document co_lnotab,
and none did a very good job. This patch unifies them into
Objects/lnotab_notes.txt which tries
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6042
___
___
Python-bugs-list
10 matches
Mail list logo
