Tarek Ziadé ziade.ta...@gmail.com added the comment:
done in r74728 (trunk), r74729 (2.6.x), r74730 (pyk3) and r74731 (3.1.x)
Thanks guys !
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6163
Sridhar Ratnakumar sridh...@activestate.com added the comment:
From http://svn.python.org/view/python/trunk/Misc/NEWS?
r1=74728r2=74727pathrev=74728
Initial patch by Sridhar Ratnakumar
The author of the initial patch - distutils_hpux_libdir_option.patch -
is actually Trent Mick. I only
Tarek Ziadé ziade.ta...@gmail.com added the comment:
The rule I apply is as follow (any other rule would be too complicated
for me):
I add in Misc/NEWS the name of the user that initialy provides the patch
in the tracker.
If you want a different name, you need to provide a patch with the text
Sridhar Ratnakumar sridh...@activestate.com added the comment:
compiler.find(gcc) = 0 or compiler.find(g++) = 0
Why not `(gcc in compiler or g++ in compiler)`? Just curious.
--
___
Python tracker rep...@bugs.python.org
Michael Haubenwallner michael.haubenwall...@salomon.at added the comment:
compiler.find(gcc) = 0 or compiler.find(g++) = 0
Why not `(gcc in compiler or g++ in compiler)`? Just curious.
Fine with me too.
--
___
Python tracker
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Ok so, just to make sure, the final patch for both changes should be:
{{{
...
elif sys.platform[:5] == hp-ux:
if compiler.find('gcc'):
return [-Wl,+s, -L + dir]
return [+s, -L + dir]
...
}}}
--
Michael Haubenwallner michael.haubenwall...@salomon.at added the comment:
Basically yes, two minor ones:
*) also look for 'g++',
*) string.find() returns the index where found, -1 when not found,
so:
{{{
...
elif sys.platform[:5] == hp-ux:
if compiler.find('gcc') = 0 or compiler.find('g++')
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Two lines below already is another search for 'gcc' or 'g++',
which also should be changed from 'compiler[:3]' to 'compiler.find()'
But compiler[:3] implies that the compiler string starts *with* 'gcc'.
so are you sure we're looking for
Michael Haubenwallner michael.haubenwall...@salomon.at added the comment:
But compiler[:3] implies that the compiler string starts *with* 'gcc'.
so are you sure we're looking for 'gcc' anywhere in the string,
or at the beginning of it ?
It is very common to use the host triplet in the
Michael Haubenwallner michael.haubenwall...@salomon.at added the comment:
Ohw, indeed, this line was copied from 3 lines below, sorry!
The actual patch I'm using does not do { compiler[:3] == 'gcc' }, but {
compiler.find(gcc) }, to also work when CC=gcc-version, but this is a
different problem
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Michael, I am not sure how you patch applies, is elif meant to be if ?
e.g. a gcc compiler under hp-us case ?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6163
Michael Haubenwallner michael.haubenwall...@salomon.at added the comment:
While at it: gcc does not understand '+s', it does need '-Wl,+s'.
--
nosy: +haubi
Added file:
http://bugs.python.org/file14514/distutils_hpux_libdir_option-gcc.patch
___
New submission from Sridhar Ratnakumar sridh...@activestate.com:
this is also applicable to 3.1 (albeit the source is slightly changed)
Return a *list* of options otherwise these may be improperly interpreted as
one option with an embedded space. On /usr/bin/ld on a HP-UX/IA64 box this
results
13 matches
Mail list logo
