[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Everything looks ok, thanks! -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215 ___

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Committed in r73461. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215 ___ ___

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Everything looks ok, can you merge the commit to py3k so as to minimize conflicts when merging stuff? Thanks :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Done in r73169. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215 ___ ___

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Well, the patch looks ok, so you can commit it if it fixes things on Windows. (I honestly haven't tested it, though) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I think I could fix windows build issue. (r73423) It seems some tests are failing. See http://www.python.org/dev/buildbot/trunk.stable/x86%20XP-4%20trunk/builds/2244/step-test/0 -- nosy: +ocean-city

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I found following patch can fix test_invalid_operations error on windows. Is this correct fix? There are many other places using bare open(). Index: Lib/test/test_io.py

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: I found following patch can fix test_invalid_operations error on windows. Is this correct fix? There are many other places using bare open(). The fix looks ok. test_io should use self.open() instead of open() everywhere, except in places where

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Here is a patch to convert open() and io.open() to self.open(). # I didn't change _default_chunk_size() but maybe should this also use self.open()? -- Added file: http://bugs.python.org/file14302/self_open.patch

[issue6215] Backport the IO lib to trunk

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: except in places where it's not used as a test. I couldn't distinguish which one is that case, so I converted all open(). ;-) -- ___ Python tracker rep...@bugs.python.org

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Updated patch for recent py3k changes. I will commit soon if nobody objects. -- Added file: http://bugs.python.org/file14275/iobackport3.patch ___ Python tracker rep...@bugs.python.org

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Done in r73394. -- resolution: - fixed stage: patch review - committed/rejected status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Someone will probably have to fix the Windows build files, by the way (I can't do it myself). -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

Alexandre Vassalotti alexan...@peadrop.com added the comment: Could simply merge the changes in r71185 to the PC/ and PCbuild/ directories? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

Alexandre Vassalotti alexan...@peadrop.com added the comment: I think the build configuration for _io on Windows is missing. Modules/Setup.dist probably needs to be updated too. -- ___ Python tracker rep...@bugs.python.org

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: I think the build configuration for _io on Windows is missing. Yes. Modules/Setup.dist probably needs to be updated too. Not sure, I don't think any of these modules are built-in. -- ___ Python

[issue6215] Backport the IO lib to trunk

Alexandre Vassalotti alexan...@peadrop.com added the comment: Not sure, I don't think any of these modules are built-in. Ah true. Although there are built-in in py3k, you are right that it doesn't make sense to make the trunk versions built-in. --

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: New patch incorporating the latest py3k changes. -- Added file: http://bugs.python.org/file14208/iobackport2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6215

[issue6215] Backport the IO lib to trunk

New submission from Antoine Pitrou pit...@free.fr: The new IO lib has undergone deep changes in py3k which have never been backported to trunk. This patch brings trunk up to date, including tests. -- components: IO files: iobackport.patch keywords: patch messages: 88974 nosy: pitrou

[issue6215] Backport the IO lib to trunk

Antoine Pitrou pit...@free.fr added the comment: Please note that test_io leaks references because of #2521. Otherwise it's fine. -- nosy: +alexandre.vassalotti, amaury.forgeotdarc, benjamin.peterson ___ Python tracker rep...@bugs.python.org