Mark Dickinson dicki...@gmail.com added the comment:
Could someone ensure the attached unittest does the job, I blindly
copied from above...
Unfortunately it doesn't, because the apop method needs a timestamp in the
welcome message in order to work. I've adapted it to make this work---see
Mark Dickinson dicki...@gmail.com added the comment:
Adding Giampaolo Rodola to the nosy list, since he worked on the test code
recently. Giampaolo, any comments?
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' billiej...@users.sourceforge.net added the comment:
@Mark
I can't test your patch right now as I don't have a Python 3.x installed
here but it looks good to me.
--
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
Patch committed, r74330 (py3k) and r74331 (release31-maint).
Thanks, Giampaolo and Vincent!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Vincent Legoll vincent.leg...@gmail.com added the comment:
Could someone ensure the attached unittest does the job, I blindly
copied from above...
I don't know how to launch an unittest with the svn 'Lib', it takes the
system one and just messing with PYTHONPATH won't work either.
--
Mark Dickinson dicki...@gmail.com added the comment:
Comparing with trunk, I agree that it seems very likely that 'password' is
intended here.
It's unfortunate that the test-suite doesn't expose this bug; it would be
good to come up with a test that covers this.
--
nosy:
New submission from Vincent Legoll vincent.leg...@gmail.com:
The poplib modules use the 'secret' variable during its creation, this
may be a mistake. Perhaps the intention was to use the 'password' instead...
--
components: Library (Lib)
files: py3k-poplib.py-use-wrong-variable.patch
