[issue6715] xz compressor support

2013-01-04 Thread Peter
Peter added the comment: Apologies again for the noise, but I've just made the first public release of the lzma backport at http://pypi.python.org/pypi/backports.lzma/ with the repository as mentioned before at https://github.com/peterjc/backports.lzma I have tested this on Python 2.6, 2.7

[issue6715] xz compressor support

2012-11-06 Thread Peter
Peter added the comment: Apologies for noise, but since a backport was discussed, I'm mentioning this here. I've started implementing a backport, currently working and tested on Mac OS X and Linux, back to Python 3.0 - supporting Python 2 would be nice but probably significantly more work

[issue6715] xz compressor support

2012-03-06 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: I had intended to wait until the code had been tested on all of the buildbots before closing it. However, it's taking a while to get xz-utils installed on the last few bots, so it doesn't make sense to keep the issue open for this.

[issue6715] xz compressor support

2012-03-05 Thread STINNER Victor
STINNER Victor victor.stin...@gmail.com added the comment: Why is this issue still open? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2012-02-25 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 7c22281e967c by Éric Araujo in branch '2.7': Improve interlinking of archiving/compression modules docs. http://hg.python.org/cpython/rev/7c22281e967c -- ___ Python

[issue6715] xz compressor support

2012-02-14 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: BTW, any plans on a PyPI backport for fun and profit? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2012-02-14 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: BTW, any plans on a PyPI backport for fun and profit? At present, no. I'll look into it later in the year, but at the moment I don't have the time to work on it - I suspect the parts written in C will require substantial changes to work

[issue6715] xz compressor support

2012-02-05 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 11bd2d32b4e8 by Éric Araujo in branch '3.2': Improve interlinking of archiving/compression modules docs. http://hg.python.org/cpython/rev/11bd2d32b4e8 New changeset 1cb9b8126534 by Éric Araujo in branch 'default':

[issue6715] xz compressor support

2011-12-16 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Is there any reason why this issue is still open? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-12-16 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Yes, almost half of the buildbots still don't have the xz-utils headers installed, and thus are not building/testing the lzma module. I've kept the issue open as a reminder to myself to follow up on this. --

[issue6715] xz compressor support

2011-12-08 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: I’ll commit my doc patch to all branches later. I checked the 4 red 3.3 builbots and they can’t build _lzma. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-12-08 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: I’ll commit my doc patch to all branches later. OK, great. I checked the 4 red 3.3 builbots and they can’t build _lzma. For the record, the 3.x buildbots that currently aren't able to build the _lzma module are: * x86 Ubuntu Shared *

[issue6715] xz compressor support

2011-12-08 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Le jeudi 08 décembre 2011 à 17:40 +, Nadeem Vawda a écrit : Nadeem Vawda nadeem.va...@gmail.com added the comment: I’ll commit my doc patch to all branches later. OK, great. I checked the 4 red 3.3 builbots and they can’t build

[issue6715] xz compressor support

2011-12-08 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 66df5ace0eee by Nadeem Vawda in branch 'default': What's New in Python 3.3: Add entry for lzma module (issue #6715). http://hg.python.org/cpython/rev/66df5ace0eee -- ___

[issue6715] xz compressor support

2011-12-08 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Ok, I've e-mailed the owners. Thanks. I was just thinking I should send a reminder, in case they missed the note in my announcement on python-dev. Will someone write an entry in the what's new file for 3.3? Done --

[issue6715] xz compressor support

2011-11-30 Thread Ned Deily
Ned Deily n...@acm.org added the comment: I've opened Issue13507 to track adding liblzma to the OS X installer builds. -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-11-30 Thread Per Øyvind Karlsen
Per Øyvind Karlsen peroyv...@mandriva.org added the comment: Ah, I thought that he had reused most of the original C code in _lzmamodule.c not replaced by python code, but I see that not being the case now (only slight fragments;). Oh well, I thought that I'd still earned a note with some

[issue6715] xz compressor support

2011-11-30 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Oh well, I thought that I'd still earned a note with some slight credit at least I completely agree. Sometimes people get credit for simple bug fixes (count me among them) so the author of the first working implementation deserves

[issue6715] xz compressor support

2011-11-30 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Nadeem: Instead of duplicating the list of archiving/compression modules in each doc, what about only linking to the shutil doc for archives and the archiving.rst file? (I can make the patch, just wanted feedback first) --

[issue6715] xz compressor support

2011-11-30 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Not meaning to sound petty, but wouldn't it be common etiquette to retain some original copyright notice from original code intact..? It seemed to me that Nadeem had rewritten everything from scratch. Is there any code of yours in the

[issue6715] xz compressor support

2011-11-30 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Instead of duplicating the list of archiving/compression modules in each doc, what about only linking to the shutil doc for archives and the archiving.rst file? Sure, go ahead. I actually hadn't realized that each section of the library

[issue6715] xz compressor support

2011-11-30 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: --- a/Misc/NEWS +++ b/Misc/NEWS @@ -400,6 +400,7 @@ --- - Issue #6715: Add a module 'lzma' for compression using the LZMA algorithm. + Thanks to Per Øyvind Karlsen for the initial implementation. The entry in

[issue6715] xz compressor support

2011-11-30 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: what about a mention in lzmamodule.c? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-11-30 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: I actually hadn't realized that each section of the library docs had a sub-index page like that That’s multiple-entry navigation :) You can jump to a module page, or use the index, or use the search, or browse and see the sub-indexes. As the

[issue6715] xz compressor support

2011-11-30 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: The entry in Misc/ACKS, Doc/whatsnew/3.3.rst and the commit message should be enough. Lately I’ve noticed some attributions in NEWS, but it’s usually not done (as redundant). I generally add attributions in NEWS since that's where most people

[issue6715] xz compressor support

2011-11-30 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 6cde416ef03b by Nadeem Vawda in branch 'default': Credit Per Øyvind Karlsen for the initial implementation of the lzma module (issue #6715). http://hg.python.org/cpython/rev/6cde416ef03b --

[issue6715] xz compressor support

2011-11-30 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: As the docs for zlib, gzip, bz2, lzma, zipfile and tarfile are in the archiving subsection, there’s already a link to the subsection index, so I just removed the “See also zlib, etc.” lines (except for the link from zlib to gzip). I

[issue6715] xz compressor support

2011-11-29 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 74d182cf0187 by Nadeem Vawda in branch 'default': Issue #6715: Add module for compression using the LZMA algorithm. http://hg.python.org/cpython/rev/74d182cf0187 -- nosy: +python-dev

[issue6715] xz compressor support

2011-11-29 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: The patch has been committed. I'm leaving this issue open for a while longer, until more of the buildbots are building and testing the module. -- ___ Python tracker rep...@bugs.python.org

[issue6715] xz compressor support

2011-11-29 Thread Per Øyvind Karlsen
Per Øyvind Karlsen peroyv...@mandriva.org added the comment: Not meaning to sound petty, but wouldn't it be common etiquette to retain some original copyright notice from original code intact..? -- ___ Python tracker rep...@bugs.python.org

[issue6715] xz compressor support

2011-11-29 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Not meaning to sound petty, but wouldn't it be common etiquette to retain some original copyright notice from original code intact..? It seemed to me that Nadeem had rewritten everything from scratch. Is there any code of yours in the current

[issue6715] xz compressor support

2011-11-26 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Victor: Thanks for the review; I've replied to your comments and updated the patch. Let me know what you think of the changes. -- ___ Python tracker rep...@bugs.python.org

[issue6715] xz compressor support

2011-11-26 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: The last patch (9276fc685c05.diff) looks good to me. Go ahead for the commit! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-11-19 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23732/9276fc685c05.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-11-19 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23466/371a133b770a.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-11-16 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: What is the status on this, Nadeem? It would be lovely to get the feature in the stdlib. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-11-16 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: I just added the missing files liblzma.a to the externals repository. If someone can quickly check that it works on win32, I don't have anything else to add to this change. -- ___ Python

[issue6715] xz compressor support

2011-11-16 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Everything is ready to go, as far as I'm concerned. Once I've tested the Windows build using the binary from the externals repository, I'll be ready to commit it to the main repository. -- ___

[issue6715] xz compressor support

2011-11-16 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: I've tested the Windows build, and it works fine. If there are no objections, I'll commit on Saturday. Btw, what is the preferred channel for communicating with buildbot owners? I'll want to send out an email asking that all the *nix bots

[issue6715] xz compressor support

2011-11-16 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I've tested under 64-bit Windows and it worked fine. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-11-16 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: I wrote a short review on http://bugs.python.org/review/6715/show -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-19 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Apart from this, is there anything else that needs to be done before this change can be committed to the main repo? Things look fine to me, apart from a couple of minor comments I've made on the review tool. --

[issue6715] xz compressor support

2011-10-19 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23393/bdf0afbbbd80.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-19 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23466/371a133b770a.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-17 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: After disabling a bunch of services and skipping the tests that are failing on the Windows buildbots, it seems that the failures I was getting last week have disappeared. It looks like they were due to the Windows search indexer preventing

[issue6715] xz compressor support

2011-10-13 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: I have imported xz-5.0.3 into the externals repository now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-12 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Modules/_lzmamodule.c:364: Py_BEGIN_ALLOW_THREADS It seems that the Windows version at least is not thread-safe. If so, you would need an LZMA lock when releasing the GIL. Does the class need to be thread-safe, though? As a matter of

[issue6715] xz compressor support

2011-10-12 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Correct. I copied the algorithm from _io.FileIO, under the assumption that there was a reason for not using a simpler O(n log n) doubling strategy. Do you know of any reason for this? Or is it safe to ignore it? I don't know, but I'd say

[issue6715] xz compressor support

2011-10-12 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: To elaborate on the policy: giving bogus data in cases of race conditions is ok; crashing the interpreter or corrupting memory is not. If bogus data is given, it would be useful if the bogosity can be specified (e.g. when multiple

[issue6715] xz compressor support

2011-10-12 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23393/bdf0afbbbd80.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-12 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23168/591277fe6b4a.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-12 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Patch update time! Noteworthy changes: * Windows build support, thanks to Amaury * Thread safety for LZMACompressor and LZMADecompressor, by means of per-instance locks * O(n) buffer growth strategy I've tried running the tests on Windows,

[issue6715] xz compressor support

2011-10-11 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Awesome stuff! I'll post an updated patch during the course of the day. Martin: I've been having problems with Rietveld lately, so I'm posting my replies to your comments here instead. Modules/_lzmamodule.c:115: return

[issue6715] xz compressor support

2011-10-11 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Modules/_lzmamodule.c:115: return _PyBytes_Resize(buf, size + BIGCHUNK); This has quadratic performance. Correct. I copied the algorithm from _io.FileIO, under the assumption that there was a reason for not using a simpler O(n log n)

[issue6715] xz compressor support

2011-10-10 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: *Very* good news for lzma on windows: The precompiled static library liblzma.a works very well with MSVC (tested with VS2008 on Windows XP, 32bit). This was a surprise for me... Here is a patch for the win32 build files, to be

[issue6715] xz compressor support

2011-10-06 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: On http://tukaani.org/xz, I downloaded the file named xz-5.0.3-windows.zip. It contains precompiled dlls for both platforms: bin_i486/liblzma.dll and bin_x86_64/liblzma.dll Unfortunately, there is no import library for VS. It should not

[issue6715] xz compressor support

2011-10-06 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Hmm... according to http://git.tukaani.org/?p=xz.git;a=blob;f=windows/README-Windows.txt;hb=HEAD#l80, the MinGW-compiled static libs *can* be used with MSVC. Not sure how reliable the information is, but it's worth a try at least.

[issue6715] xz compressor support

2011-10-06 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Ah indeed, the zip archive contains a doc/liblzma.def which can be used to build a liblzma.lib -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-10-06 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Hey, today I learnt something about mingw! Rename liblzma.a to e.g. liblzma_static.lib and tell MSVC to link against it. Apparently mingw can generate COFF libraries. This may simplify things *a lot*. --

[issue6715] xz compressor support

2011-10-06 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Wow, this discussion has gotten quite busy while I've been travelling... Martin, could you explain what the problems are with bundling a precompiled DLL for Windows? I am willing to do the work of getting liblzma to compile with VS if

[issue6715] xz compressor support

2011-10-06 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Am 06.10.11 13:01, schrieb Nadeem Vawda: Nadeem Vawdanadeem.va...@gmail.com added the comment: Wow, this discussion has gotten quite busy while I've been travelling... Martin, could you explain what the problems are with bundling a

[issue6715] xz compressor support

2011-10-05 Thread Jesús Cea Avión
Jesús Cea Avión j...@jcea.es added the comment: I agree with Martin here. We should *NOT* have first and second class OS support, if we can avoid it. That said, I wonder what happens in Windows with the BZ2 module, for instance :-?. Do we include the BZ2 sourcecode to compile it under

[issue6715] xz compressor support

2011-10-05 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I agree with Martin here. We should *NOT* have first and second class OS support, if we can avoid it. The key word being if we can avoid it. Jesus, if you are a Windows expert, your contribution is welcome. --

[issue6715] xz compressor support

2011-10-05 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: For bz2, Tools/buildbot/external-common.bat has code to download bz2 source, and PCbuild/_bz2.vcproj include and compile these files together with _bz2.pyd. The _ssl module does a similar thing, except that libeay32.lib and

[issue6715] xz compressor support

2011-10-05 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: That said, I wonder what happens in Windows with the BZ2 module, for instance :-?. External code currently lives at http://svn.python.org/projects/external/. The build process gets it from there, and we may have local modifications to

[issue6715] xz compressor support

2011-10-05 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: I agree with Martin here. We should *NOT* have first and second class OS support, if we can avoid it. Ok but who will do the job? If nobody is motivated to fix compiler issues, it would be a pity to not add the module for that.

[issue6715] xz compressor support

2011-10-05 Thread Jesús Cea Avión
Jesús Cea Avión j...@jcea.es added the comment: Antoine, I am a Linux/Solaris/Illumos guy. I only use Windows (virtualized) to sync my iPhone with iTunes :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715

[issue6715] xz compressor support

2011-10-04 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Based on Amaury's report, I would suggest going forward integrating the xz module for configure-based systems, and letting someone else handle Windows integration later if a solution is found. -- ___

[issue6715] xz compressor support

2011-10-04 Thread Éric Araujo
Changes by Éric Araujo mer...@netwok.org: Removed file: http://bugs.python.org/file23300/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-10-04 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly variables declared in the middle of a block. It's doable for sure, but it's a lot of work. I'd be in favor of doing so, and then feeding patches upstream. Hopefully,

[issue6715] xz compressor support

2011-10-04 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Based on Amaury's report, I would suggest going forward integrating the xz module for configure-based systems, and letting someone else handle Windows integration later if a solution is found. -1000. I feel quite strongly that this should

[issue6715] xz compressor support

2011-10-04 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Based on Amaury's report, I would suggest going forward integrating the xz module for configure-based systems, and letting someone else handle Windows integration later if a solution is found. -1000. I feel quite strongly that this should

[issue6715] xz compressor support

2011-10-04 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Am 04.10.11 19:08, schrieb Antoine Pitrou: Antoine Pitroupit...@free.fr added the comment: Based on Amaury's report, I would suggest going forward integrating the xz module for configure-based systems, and letting someone else handle

[issue6715] xz compressor support

2011-10-04 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: This module is only useful in the standard library if it is available on all systems. Not really. xz is becoming a defacto standard under Linux (and perhaps other free Unices) while I guess it is marginal under Windows. We have other

[issue6715] xz compressor support

2011-10-04 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Not really. xz is becoming a defacto standard under Linux (and perhaps other free Unices) while I guess it is marginal under Windows. We have other system-specific functionality, and nobody sees it as a bad thing. That's because all

[issue6715] xz compressor support

2011-10-04 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: That's because all system-specific functionality that we have really depends on system features which just can't be available elsewhere. For all functionality that in principle works on all systems, it also actually works on all systems for

[issue6715] xz compressor support

2011-10-04 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: That's because all system-specific functionality that we have really depends on system features which just can't be available elsewhere. For all functionality that in principle works on all systems, it also actually works on all systems

[issue6715] xz compressor support

2011-10-02 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Thanks for investigating the Windows situation. - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly variables declared in the middle of a block. It's doable for sure, but it's a lot of work. I don't think that

[issue6715] xz compressor support

2011-10-02 Thread Dan Stromberg
Dan Stromberg strom...@gmail.com added the comment: On Sun, Oct 2, 2011 at 3:49 PM, Nadeem Vawda rep...@bugs.python.org wrote: Nadeem Vawda nadeem.va...@gmail.com added the comment: Thanks for investigating the Windows situation. - liblzma can't be compiled by Visual Studio: too many C99

[issue6715] xz compressor support

2011-09-16 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Nadeem, I started reviewing this path, but now stopped since the patch I reviewed isn't available anymore. Please let us know when the patch has a state where you don't plan to make more changes. --

[issue6715] xz compressor support

2011-09-16 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Ah, sorry about that. It probably wasn't necessary to regenerate the patch after I addressed the comments in each review. The patch should be stable now; I don't plan to make any further changes for a while. (At some point I'll want to add

[issue6715] xz compressor support

2011-09-16 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: I'm a bit worried by the Windows version: - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly variables declared in the middle of a block. It's doable for sure, but it's a lot of work. - liblzma is normally

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23158/95016f363e6c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23159/3017ee1d548d.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23158/95016f363e6c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23063/f3cf187208ea.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23129/fe2c9998f329.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: I've attached another patch that includes proper ReST documentation, a few more tests, and some fixups following Ezio and Amaury's reviews. -- stage: needs patch - patch review ___ Python tracker

[issue6715] xz compressor support

2011-09-15 Thread Lars Gustäbel
Lars Gustäbel l...@gustaebel.de added the comment: Today I played around with lzma support for tarfile based on your last patch (see issue5689). There are a few minor issues that I just wanted to mention, as they break the tarfile testsuite: - LZMAFile does not expose a name attribute.

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23168/591277fe6b4a.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Removed file: http://bugs.python.org/file23159/3017ee1d548d.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-15 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: Thanks for getting the ball rolling with that. I'll want to try and familiarize myself with the code for tarfile module before I start changing stuff, but those points shouldn't be hard to fix, one way or the other. --

[issue6715] xz compressor support

2011-09-15 Thread John Reese
Changes by John Reese jre...@leetcode.net: -- nosy: -jreese ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___ ___ Python-bugs-list mailing

[issue6715] xz compressor support

2011-09-11 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23129/fe2c9998f329.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

[issue6715] xz compressor support

2011-09-11 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: I've attached another patch (fe2c9998f329.diff) with a more complete implementation of the lzma module. All that's left now is to write the documentation, and make sure that the module can build on Windows. --

[issue6715] xz compressor support

2011-09-09 Thread Nam Nguyen
Nam Nguyen bits...@gmail.com added the comment: In uint32_converter, I'm not sure the if statement comparing val and UINT32_MAX makes sense. val was defined to be unsigned long, which is 32bit on 32-bit compiler. -- nosy: +Nam.Nguyen ___ Python

[issue6715] xz compressor support

2011-09-09 Thread Nadeem Vawda
Nadeem Vawda nadeem.va...@gmail.com added the comment: In uint32_converter, I'm not sure the if statement comparing val and UINT32_MAX makes sense. val was defined to be unsigned long, which is 32bit on 32-bit compiler. Yes, on a 32-bit system, this comparison will always be false. However,

[issue6715] xz compressor support

2011-08-29 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___ ___ Python-bugs-list mailing

[issue6715] xz compressor support

2011-08-29 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: -- hgrepos: +64 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___ ___ Python-bugs-list

[issue6715] xz compressor support

2011-08-29 Thread Nadeem Vawda
Changes by Nadeem Vawda nadeem.va...@gmail.com: Added file: http://bugs.python.org/file23063/f3cf187208ea.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6715 ___

  1   2   >