[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Roundup Robot added the comment: New changeset 6bd3c8623bb2 by Gregory P. Smith in branch '3.4': Fix issue #6973: When we know a subprocess.Popen process has died, do https://hg.python.org/cpython/rev/6bd3c8623bb2 New changeset bc907c76f054 by Gregory P. Smith in branch '3.5': Fix issue #6973:

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Gregory P. Smith added the comment: I chose to go with the "there should not be an error" approach similar to how Python deals with multiple file closes. Both are technically programming errors but the point of Python is make life easier. Reasoning? I don't want someone to ever think they

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Martin Panter added the comment: It seems to me that raising OSError isn’t quite right. Either the error is more of an internal programmer error, like how writing to a closed file object raises ValueError, or there should not be an error, like when the process has terminated but has not been

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Martin Panter vadmium...@gmail.com: -- components: +Library (Lib) -Interpreter Core ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: -- nosy: -markon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___ ___ Python-bugs-list mailing

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Ezio Melotti ezio.melo...@gmail.com: -- versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4 -Python 2.6, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Giampaolo Rodola' g.rod...@gmail.com added the comment: I totally agree this should be fixed (there was a similar issue for psutil: http://code.google.com/p/psutil/issues/detail?id=58) but communicate() and wait() should be affected in the same manner. Probably it would make sense to add an

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti priority: - normal stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Marco Buccini marcu...@gmail.com added the comment: I agree with Milko. However, I think Popen.send_signal should poll() before sending any signals, without resetting any variables to zero (or None). In this way, if you poll() before sending a signal, if the return code is None, the child is

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Added file: http://bugs.python.org/file15136/test_subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Removed file: http://bugs.python.org/file15136/test_subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Added file: http://bugs.python.org/file15137/test_subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Removed file: http://bugs.python.org/file15135/subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Added file: http://bugs.python.org/file15141/subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Removed file: http://bugs.python.org/file15141/subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Removed file: http://bugs.python.org/file15137/test_subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Added file: http://bugs.python.org/file15142/test_subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Marco Buccini marcu...@gmail.com: Added file: http://bugs.python.org/file15143/subprocess.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6973 ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

New submission from Milko Krachounov pyt...@milko.3mhz.net: When subprocess.Popen.send_signal is called, it simply calls os.kill(self.pid, ...) without checking whether the child has already terminated. If the child has been terminated, and Popen.wait() or Popen.poll() have been called, a