[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Enhanced patch applied in r75400, and further enhanced by Nick Coghlan in r75456, r75457, and r75466. Ported to py3k by Nick in r75493, with a little cleanup in r75504. -- status: open -> closed ___ Python tracker

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: I agree about not backporting the new patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue7058] Add some test execution environment protection to regrtest

Antoine Pitrou added the comment: Looks good to me. Not sure it should be backported though, the patch has become really sizeable. -- ___ Python tracker ___ _

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Here is an updated patch that doesn't break -j. -- Added file: http://bugs.python.org/file15125/refactored_environment_checking.patch ___ Python tracker _

[issue7058] Add some test execution environment protection to regrtest

Changes by R. David Murray : Removed file: http://bugs.python.org/file15107/refactored_environment_checking.patch ___ Python tracker ___ ___ P

[issue7058] Add some test execution environment protection to regrtest

Changes by R. David Murray : Removed file: http://bugs.python.org/file15105/refactored_environment_checking.patch ___ Python tracker ___ ___ P

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Here is a finished version of the refactoring patch. It introduces a new category in the list of test statuses at in the summary to list the tests that have changed the execution environment. This patch makes it easy to add additional things to check and rest

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: I've refactored the code and added more checks (cwd, all three stdio attributes). Patch attached. I'm not done with this because I want to make the reporting more visible. -- Added file: http://bugs.python.org/file15105/refactored_environment_checki

[issue7058] Add some test execution environment protection to regrtest

Ezio Melotti added the comment: The cwd should also be checked/restored to avoid problems like #7066. -- nosy: +ezio.melotti ___ Python tracker ___ __

[issue7058] Add some test execution environment protection to regrtest

Changes by R. David Murray : Removed file: http://bugs.python.org/file15044/regrtest_guards.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Committed to trunk in r75255, py3k in r75279, and 3.1 in r75280. Leaving open until 2.6 is unfrozen and I can commit it there as well. -- assignee: -> r.david.murray resolution: -> accepted stage: patch review -> committed/rejected

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Updated patch based on Antoine's feedback on IRC. Removes a mislaid 'not quiet' and restores argv using argv[:] = saved_argv. I agree about putting it into 2.6/3.1. We could also claim that it is fixing a bug in the running of the tests :) I suspect it migh

[issue7058] Add some test execution environment protection to regrtest

Antoine Pitrou added the comment: Apart from the comments I made on IRC, I think it would be nice to have this patch in 2.6 and 3.1 as well. While not technically a bug fix, it is innocuous for users and certainly helps finding problems. -- nosy: +pitrou versions: +Python 2.6, Python 3.

[issue7058] Add some test execution environment protection to regrtest

R. David Murray added the comment: Or should regrtest convert these into test failures for reporting purposes? -- ___ Python tracker ___ _

[issue7058] Add some test execution environment protection to regrtest

New submission from R. David Murray : One of the failures when regrtest is run with a read-only Lib results from test_runpy modifying sys.argv. Antoine also found cases where tests modified os.environ in issue 7055. It seems useful to have regrtest fix these kinds of environment corruptions whe