Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Is there anything more I can do to help get this crash-fix committed before 2.7
rc1?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
Antoine Pitrou pit...@free.fr added the comment:
Sorry, I had just forgotten. The patch has been committed in r81275 (trunk) and
r81277 (2.6). Thank you:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Removed file: http://bugs.python.org/file15076/fileobject.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Removed file: http://bugs.python.org/file15077/crash.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Added file: http://bugs.python.org/file17130/file_close_test.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Added file: http://bugs.python.org/file17131/file_close.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
I reworked my test script into a unit test. Thanks for pointing me to
test_file2k.py. I leveraged the infrastructure that was already there.
I've also uploaded a new patch that uses tabs instead of spaces, to match the
rest
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
--
keywords: +needs review
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
--
assignee: gregory.p.smith - stutzbach
stage: patch review - unit test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
Antoine Pitrou pit...@free.fr added the comment:
Your proposal looks reasonable.
Two things:
- your patch should include an unit test (see Lib/test/test_file2k.py)
- fileobject.c should use tabs for indentation, not spaces
And you're right, py3k doesn't have this problem.
--
nosy:
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
priority: - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
New submission from Daniel Stutzbach dan...@stutzbachenterprises.com:
I noticed that file_close() calls close_the_file(), then frees the
buffer for the file object. However, close_the_file() may fail and
return NULL if the file object is currently in use by another thread, in
which case freeing
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Added file: http://bugs.python.org/file15077/crash.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
Changes by Benjamin Peterson benja...@python.org:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7079
___
___
14 matches
Mail list logo
