Georg Brandl ge...@python.org added the comment:
Committed rest of patch in r87045. Will try to get test_pdb2 in shape and
working on all platforms.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
Ilya Sandler ilya.sand...@gmail.com added the comment:
The patch tries to write to stdout in signal handler.
This currently does not work in the python 3.x (see
http://bugs.python.org/issue10478).
--
___
Python tracker rep...@bugs.python.org
Georg Brandl ge...@python.org added the comment:
I committed the commands part of the patch in r83308.
For the SIGINT part, I'm concerned that the SIGINT handler is set
in the Pdb constructor, since it's a processwide setting I think it
should a) be set only before sys.settrace() and b) be
Georg Brandl ge...@python.org added the comment:
Adding the rest of the patch adapted for py3k trunk as of today.
--
keywords: +patch
Added file: http://bugs.python.org/file18277/pdb-keyboardinterrupt.diff
___
Python tracker rep...@bugs.python.org
Ilya Sandler ilya.sand...@gmail.com added the comment:
I tried to understand the cause of failures and I don't see how test_pdb2 could
have caused them ;-).
Here is the relevant part of buildbot timeline:
http://www.python.org/dev/buildbot/trunk/?last_time=1273368351show_time=7400
The only
Gregory P. Smith g...@krypto.org added the comment:
Committed to trunk in r81012. though as this missed 2.7beta2 its possible that
will be rejected and this becomes a 3.x only feature.
I'm porting to py3k now.
--
versions: +Python 3.2
___
Python
Gregory P. Smith g...@krypto.org added the comment:
And reverted in trunk r81013. Multiple buildbot problems from the initial
commit due to the unittest.
This is likely to be py3k only at this point.
I do believe sig.patch.v3 is fine, but its the test_pdb2 unittest that is
difficult to make
Ilya Sandler ilya.sand...@gmail.com added the comment:
a note on testing: it should be possible to integrate the tests into existing
test_pdb.py by simply placing subprocess based tests next to doctest-based
tests. This way pdb tests will at least be in a single module. (this is an
approach
Ilya Sandler ilya.sand...@gmail.com added the comment:
Is there anything else I can do for this patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7245
___
Ilya Sandler ilya.sand...@gmail.com added the comment:
I'm attaching a test for Ctrl-C behavior on Linux (the patch itself works on
Windows too, but I am not sure how to send Ctrl-C on windows programatically
and subprocess does not have this functionality either).
The test_pdb2.py module is
Ilya Sandler ilya.sand...@gmail.com added the comment:
Another version of the patch is attached ( I think, I fixed all the remaining
style issues).
I'll answer the testing question in a separate post
--
Added file: http://bugs.python.org/file16470/sig.patch.v3
Ilya Sandler ilya.sand...@gmail.com added the comment:
new version of the patch is uploaded to bugs.python.org
http://codereview.appspot.com/216067/diff/2001/2002
File Lib/pdb.py (right):
http://codereview.appspot.com/216067/diff/2001/2002#newcode63
Lib/pdb.py:63: def sigint_handler(self,
Ilya Sandler ilya.sand...@gmail.com added the comment:
Also, can you take a look at how the pdb unittests work and see if you
can come up with a way to unittest the KeyboardInterrupt behavior?
Yes, this is doable. In fact, I already have such tests written (unix only
though). The tests are
Gregory P. Smith g...@krypto.org added the comment:
Reviewers: gregory.p.smith, Benjamin, ilya.sandler,
Message:
Also, can you take a look at how the pdb unittests work and see if you
can come up with a way to unittest the KeyboardInterrupt behavior?
Particular for the 4 scenarios you outlined
14 matches
Mail list logo
