Martijn Pieters added the comment:
Indeed, the 2.7 backport was not correctly applied for _elementtree.c, leaving
files open because the close_source flag is set to False *again* when opening a
filename.
Should a new issue be opened or should this ticket be re-opened?
--
nosy:
Berker Peksag added the comment:
Should a new issue be opened or should this ticket be re-opened?
It's a 3 years old backport, I'd say open a new issue.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
Christian Henz added the comment:
I think the cElementTree portion of the applied changes is incorrect.
`close_source` is never actually set to `True`.
http://hg.python.org/cpython/file/50722d2f08c7/Modules/_elementtree.c#l2926
--
nosy: +Christian.Henz
Changes by Brian Curtin br...@python.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7334
___
___
Python-bugs-list
Florent Xicluna florent.xicl...@gmail.com added the comment:
Changeset cff78ffb932a fixed the issue for 3.2.
I will consider backporting.
--
resolution: - fixed
stage: needs patch - patch review
versions: -Python 3.2
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset eceaa31252b3 by Florent Xicluna in branch '2.7':
Closes #7334: close source files on ElementTree.parse and iterparse (partial
backport of issue #10093 from 3.2).
http://hg.python.org/cpython/rev/eceaa31252b3
Philip Jenvey pjen...@underboss.org added the comment:
Florent, any chance of signing off on this for 3.2? I was waiting for the patch
to go through your authorized elementtree fork
--
assignee: pjenvey - flox
___
Python tracker
Philip Jenvey pjen...@underboss.org added the comment:
Patch with tests (which can only really test it on Windows) here
http://bitbucket.org/pjenvey/et-2009-provolone/changeset/8292a06090a3/
--
___
Python tracker rep...@bugs.python.org
Changes by Brian Curtin cur...@acm.org:
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7334
___
___
Python-bugs-list mailing
Florent Xicluna la...@yahoo.fr added the comment:
The patch proposed on msg95349:
* need tests
* not reviewed (yet)
--
keywords: +patch
nosy: +flox
priority: - normal
stage: - needs patch
title: XML file locking in Jython 2.5 (OSError on Windows) - ElementTree: file
locking in
10 matches
Mail list logo