STINNER Victor victor.stin...@haypocalc.com added the comment:
I think one more skip is required in test_socketserver.
Fixed: 2.7 (r81543), 3.2 (r81545), 3.1 (r81546). Blocked in 2.6 (r81544).
--
resolution: - fixed
status: open - closed
___
Stefan Krah stefan-use...@bytereef.org added the comment:
Victor, I think one more skip is required in test_socketserver.
--
nosy: +skrah
resolution: fixed -
status: closed - open
Added file:
http://bugs.python.org/file17317/nothreads-socketserver-shutdown.patch
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ported to py3k (r80600), blocked in 2.6 (r80602) and 3.1 (r80601).
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
STINNER Victor victor.stin...@haypocalc.com added the comment:
I commited the patch into small parts:
1 (r80552): fix test_support.py for Python compiled without thread
2 (r80553): regrtest.py -j option requires thread support
3 (r80554): test_doctest: import trace module in test_coverage()
4
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ok, here is my patch version 4, based on jerry's nothreads_3.patch. Changes
between version 3 and 4:
- test_support: threading_setup() returns (1,) instead of None; reap_threads()
simply returns the function instead of a dummy
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Did someone notice that on Windows, subprocess imports threading, and use
threads for the communicate() method?
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
Did someone notice that on Windows, subprocess imports threading,
and use threads for the communicate() method?
No, I didn't ran the tests on Windows. I can expect that someone build Python
on Linux without threads, but is
STINNER Victor victor.stin...@haypocalc.com added the comment:
I think the latest (v3) patch is in pretty good shape. (...)
I'll break up the patch into multiple files as well.
It will make it easier to deal with if I cause a regression.
I'm already doing that (apply the patch file by file).
Jerry Seutter jseut...@gmail.com added the comment:
Uploaded a new version of the patch, nothreads_3.patch.
@r.david.murray - Good point about unittest.skipUnless, I didn't know about
that function. I removed my decorator and used skipUnless() instead.
@haypo:
test_xmlrpc.py - Modified the
Jerry Seutter jseut...@gmail.com added the comment:
I think this issue is going to reoccur every time someone adds a unit test that
relies on threading. What do you think about using a buildbot slave to run the
tests with a non-multithreaded build of python?
--
R. David Murray rdmur...@bitdance.com added the comment:
I think it is a good idea, but someone has to set one up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
+1 to setup a buildbot, but only after all bugs are fixed :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
I'm applying fixes one by one in my local git-svn repository. I will commit
them (in one huge patch \o/) when I'm done, or maybe post a new version of the
patch (if I'm too scared of the patch).
--
Jerry Seutter jseut...@gmail.com added the comment:
I think the latest (v3) patch is in pretty good shape. You and David have been
through the changes and the result is a much improved set of changes. If you
want (and you're okay with it), I can commit the changes from here and take the
Jerry Seutter jseut...@gmail.com added the comment:
I'll break up the patch into multiple files as well. It will make it easier to
deal with if I cause a regression.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
Jerry Seutter jseut...@gmail.com added the comment:
In the test_xmlrpc.py case I changed the value from URL to 'http:' because the
code that sets URL to a valid url relies on threading. When threading is
disabled, URL is set to None and the test will fail. The two ServerProxy test
cases
R. David Murray rdmur...@bitdance.com added the comment:
I haven't reviewed the whole patch, but I would suggest that instead of making
a test_support.skip_if_no (or any other name), you use use
@unittest.skipUnless(threading) (note that lack of quotes around
threading...you seem to already
STINNER Victor victor.stin...@haypocalc.com added the comment:
In the test_xmlrpc.py case I changed the value from URL to 'http:' because
the code that sets URL to a valid url relies on threading. When threading
is disabled, URL is set to None and the test will fail.
I would prefer
STINNER Victor victor.stin...@haypocalc.com added the comment:
Comments about nothreads.patch. There are unrelated changes:
Lib/test/test_xmlrpc.py:
-p = xmlrpclib.ServerProxy(URL, transport=t)
+p = xmlrpclib.ServerProxy('http:', transport=t)
Lib/test/test_macostools.py
Jerry Seutter jseut...@gmail.com added the comment:
The patch makes it so that tests that use threading skip rather than
generate errors when python is compiled --without-threads.
I added a skip_if_no('modulename') decorator to test_support.
Let me know if this patch is too big to review and
Changes by Jerry Seutter jseut...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
___
___
New submission from R. David Murray rdmur...@bitdance.com:
In the past (= 2.6) regrtest skipped a test if any import failure
happened, which masked various real test failures. This was fixed, and
tests that should be skipped if certain modules are not available were
changed to use
Changes by Jerry Seutter jseut...@gmail.com:
--
assignee: - jseutter
nosy: +jseutter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7449
___
___
23 matches
Mail list logo
