anatoly techtonik techto...@gmail.com added the comment:
depends on issue #7583
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7585
___
___
anatoly techtonik techto...@gmail.com added the comment:
The reason is to provide a good usage example.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7585
___
Antoine Pitrou pit...@free.fr added the comment:
Is there any reason why you changed some of the examples in the docstrings
(e.g. 'Sat Jan 26 23:30:50 1991' - '1991-01-26 23:30:50')?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +tim_one
priority: - normal
stage: - patch review
versions: -Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7585
anatoly techtonik techto...@gmail.com added the comment:
It is the same reason as for removing recommendation from docstring to generate
timestamps in the format returned by time.ctime(). See issue #7582
--
___
Python tracker rep...@bugs.python.org
anatoly techtonik techto...@gmail.com added the comment:
Filenames may contain spaces too.
--- handle dis Sun Dec 27 16:08:28 2009
--- или вот это пон, дек 27 16:08:28 2009
The last line is space separated filename and date in Russian locale.
Patch tool should handle that, but as you may see
Brian Curtin cur...@acm.org added the comment:
I agree that splitting with a tab character is good, but I think it
should be split by a tab character in every case.
If the separator is different based on what data is provided, then it
complicates parsing and would have to be explained in
anatoly techtonik techto...@gmail.com added the comment:
This patch makes sure filename and date split by tab in every case when
date is provided.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7585
Brian Curtin cur...@acm.org added the comment:
I don't think the conditional checks around the timestamps are
necessary. Couldn't you just put the \t directly in the string that gets
yielded? That way the chunk headers always follow the same format.
--
nosy: +brian.curtin
anatoly techtonik techto...@gmail.com added the comment:
Conditional checks are required to prevent leaving trailing whitespace in
filename when date component is not present. Such trailing whitespace may
confuse patch tools. [1]
[1] http://code.google.com/p/python-patch/issues/detail?id=2
Brian Curtin cur...@acm.org added the comment:
Shouldn't the patch tool handle that? FWIW, both the svn diff and *nix
diff utilities produce headers with the parts split by a tab character.
Would the code in example.py work in your tool to handle both tabs and
spaces?
--
Added file:
New submission from anatoly techtonik techto...@gmail.com:
The patch inserts \t character between filename and timestamp in unified
and context diff headers.
According to specification by Guido Van Rossum =)
http://www.artima.com/weblogs/viewpost.jsp?thread=164293
And de-facto output from
12 matches
Mail list logo
