Changes by Senthil Kumaran sent...@uthcode.com:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Changes by Benjamin Peterson benja...@python.org:
--
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Donald Stufft added the comment:
@larry
Is there anything else I need to do?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Senthil Kumaran added the comment:
@dstufft - should you commit it in 3.4 branch (since the change is already in
3.5) and then wait for larry's approval or rejection?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Larry Hastings added the comment:
Okay, this has my blessing to be merged for 3.4.1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Changes by Larry Hastings la...@hastings.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
Senthil Kumaran added the comment:
I am glad that issues with 3rdparty libs which dependent on the previous wrong
behavior has been resolved.
As indicated previously, I think, it makes sense to have this in 2.7 as well. I
created a patch and tested it 2.7 and it is all good. I plan to commit
Roundup Robot added the comment:
New changeset 568041fd8090 by Senthil Kumaran in branch '2.7':
Backport Fix for Issue #7776: Fix ``Host:'' header and reconnection when using
http.client.HTTPConnection.set_tunnel().
http://hg.python.org/cpython/rev/568041fd8090
--
Senthil Kumaran added the comment:
This is fixed in 2.7 as well here (changeset 568041fd8090).
We shall close this ticket after @dstufft pulls in the updated pip for 3.4
Thanks!
--
priority: high - release blocker
versions: +Python 2.7
___
Python
Donald Stufft added the comment:
Requests has been released and I've pulled it into the pip tree. I'll be
releasing tonight probably, or maybe tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Larry Hastings added the comment:
I tag 3.4.1 final in less than 24 hours. I really would prefer that the
embedded pip not contain such, uh, fresh software. But let's try it and hope
for the best.
--
___
Python tracker rep...@bugs.python.org
Donald Stufft added the comment:
Well you're the RM Larry :) I'll do whatever you think is best. I would greatly
prefer it if the pip shipped with CPython 3.4.1 wasn't broken with proxies. I
think the choices are
1) Ship it with the new pip, I can give a delta of the differences if that is
Larry Hastings added the comment:
Yeah, I'd like to see the diff.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
Donald Stufft added the comment:
I just released pip 1.5.6.
The ensurepip package currently has 1.5.4 inside of it. 1.5.5 has been out for
2 weeks or so and there haven't been any reported regressions.
The only difference between 1.5.5 and 1.5.6 is that requests has been upgraded.
Here's the
Donald Stufft added the comment:
Just FYI, I upgraded setuptools and pip in 3.5:
http://hg.python.org/cpython/rev/acb5cc616052
http://hg.python.org/cpython/rev/308ff6a5ce67
If you decide to go that way dunno if you can just cherry pick or not.
--
Senthil Kumaran added the comment:
I prefer we update the ensurepip in 3.4.1
That will be helpful too since 3.5 has the fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list mailing
Donald Stufft added the comment:
Just an update, the issue is fixed in urllib3 and that has been pulled into
requests. Requests is currently prepping to release a new version which I'll
pull into pip and issue a pip 1.5.6 release which can be pulled into CPython
which should fix this.
Nikolaus Rath added the comment:
Cybjit rep...@bugs.python.org writes:
Cybjit added the comment:
On 2014-05-10 00:23, nikratio wrote:
Is pip maybe doing its own certificate check, and relying on
HTTPSConnection.host to contain the final hostname rather than the proxy?
I think the culprit
Ned Deily added the comment:
Should this be a release blocker regression for 3.4.1?
--
nosy: +larry, ned.deily
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Larry Hastings added the comment:
dstufft, what do you think?
--
nosy: +dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Donald Stufft added the comment:
Let me raise the issue with urllib3 and see if maybe we can get a quick turn
around and just fix it for real.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Donald Stufft added the comment:
This is going to break existing versions of urllib3 (and thus requests and thus
pip) when using verified TLS + a proxy, however future versions can work around
it and a fix is being looked at right now. Once it's fixed there it can
propagate to requests and
Cybjit added the comment:
On 2014-05-10 00:23, nikratio wrote:
Is pip maybe doing its own certificate check, and relying on
HTTPSConnection.host to contain the final hostname rather than the proxy?
I think the culprit might be here
Cybjit added the comment:
I get errors when using pip with a proxy in 3.4.1rc1 on Windows, that does not
happen on 3.4.0.
I tracked it down to this change to client.py.
OK with client.py from fd2c69cedb25, but not with client.py from 39ee3286d187.
C:\Python34\Scriptsset
Nikolaus Rath added the comment:
On 05/09/2014 02:02 PM, Cybjit wrote:
C:\Python34\Scriptspip -v install simplejson
Downloading/unpacking simplejson
Could not fetch URL https://pypi.python.org/simple/simplejson/: connection
err
or: hostname 'openwrt.lan' doesn't match either of
Senthil Kumaran added the comment:
I verified the patch and this indeed corrects a nasty bug in sending a wrong
header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad
term) to the end host..I was worried as why we did not observe this earlier and
it seems to me that
Roundup Robot added the comment:
New changeset 39ee3286d187 by Senthil Kumaran in branch '3.4':
Issue #7776: Fix ``Host:'' header and reconnection when using
http.client.HTTPConnection.set_tunnel().
http://hg.python.org/cpython/rev/39ee3286d187
New changeset 2c9af09ba7b8 by Senthil Kumaran in
Senthil Kumaran added the comment:
This is fixed in 3.4 and 3.5 (finally). I will port it to 2.7 as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: test needed - committed/rejected
versions: +Python 3.5 -Python 2.7, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Nikolaus Rath added the comment:
Refreshed patch.
--
Added file: http://bugs.python.org/file34802/issue7776_r7_Py3.4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Changes by Nikolaus Rath nikol...@rath.org:
Added file: http://bugs.python.org/file34803/issue7776_r7_Py3.5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Senthil Kumaran added the comment:
I am reviewing this patch right now and you will see my action soon. It is
completely and I am reviewing to validating the technical details/fix. Thanks
for patch, Nikolaus.
--
___
Python tracker
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Nikolaus Rath added the comment:
Hmm. I think I found another problem... please wait for another patch revision.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Nikolaus Rath added the comment:
Ok, I've attached yet another patch revision.
This revision is less complex, because it gets rid of the ability to set up
chains of tunnels. The only reason that I put that in was to preserve backward
compatibility -- but upon reviewing the old implementation
Benjamin Peterson added the comment:
A few comments
- Your docstring for set_tunnel claims the method sends CONNECT when it in fact
doesn't touch the network at all.
- Instead of 3 parallel arrays for tunnel information, it would be better to
have a TunnelInfo class to contain
Nikolaus Rath added the comment:
Thanks for the review! I've attached an updated patch.
An update to the set_tunnel library documentation is being discussed in issue
11448. I'm not sure how to best handle the overlap. Maybe the best way is to
first deal with issue 11448, and then add the
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
Nikolaus Rath added the comment:
Rebased patch on current tip.
--
Added file: http://bugs.python.org/file33520/issue7776.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Nikolaus Rath added the comment:
I've updated the patch again to fix a problem with HTTPSConnection.
--
Added file: http://bugs.python.org/file33431/issue7776.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Nikolaus Rath added the comment:
Ok, this is a bit of a mess.
Issue #11448 contains a patch for the documentation. But the functionality
itself is still not working.
With the (I believe) intended usage, we have:
import http.client
conn = http.client.HTTPSConnection(localhost,8080)
Nikolaus Rath added the comment:
I have attached a patch that should fix the issue.
--
keywords: +patch
Added file: http://bugs.python.org/file33357/issue7776.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Nikolaus Rath added the comment:
New patch revision, this time includes unit tests.
--
Added file: http://bugs.python.org/file33358/issue7776_rev1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
Changes by Brian Curtin br...@python.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
47 matches
Mail list logo
