[issue7918] distutils always ignores byte compilation errors

STINNER Victor added the comment: It seems like this issue is not a bug, I close it. -- nosy: +vstinner resolution: -> not a bug stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue7918] distutils always ignores byte compilation errors

Colton Leekley-Winslow added the comment: Also agree setup allowing broken code an be annoying, but it is necessary to maintain the existing behavior. Maybe we need an additional argument for setup that will in turn pass doraise to py_compile.compile, but retain the default behavior in all

[issue7918] distutils always ignores byte compilation errors

Changes by Danek Duvall duv...@comfychair.org: -- nosy: +dhduvall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7918 ___ ___ Python-bugs-list

[issue7918] distutils always ignores byte compilation errors

Danek Duvall added the comment: As a distribution maintainer of several Python modules, I've run into this bug twice in the past week. In each case, the python file in question had a SyntaxError and failed to compile, but the error just scrolled past in a large log and was missed because no

[issue7918] distutils always ignores byte compilation errors

Éric Araujo added the comment: Again, I think this behaviour was a deliberate decision, not a patch. Developers should use tests to detect syntax errors in their code, not rely on distutils byte compilation. -- ___ Python tracker

[issue7918] distutils always ignores byte compilation errors

Éric Araujo added the comment: a deliberate decision, not a bug* -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7918 ___ ___ Python-bugs-list

[issue7918] distutils always ignores byte compilation errors

Danek Duvall added the comment: Absolutely true that developers should have tests that would detect such bugs. However, the sooner you detect a bug, the more time you save. And by the time it reaches someone like me, who is just packaging up the module for distribution with an OS, it's just

[issue7918] distutils always ignores byte compilation errors

Éric Araujo added the comment: We all agree Python files with invalid syntax should be allowed, but some error message should be logged. From the py_compile docs, this is already what the compile function does if the doraise argument is false (default), so what’s needed here is a unit test

[issue7918] distutils always ignores byte compilation errors

Éric Araujo added the comment: Another use case from #10530: deliberately broken modules for testing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7918 ___

[issue7918] distutils always ignores byte compilation errors

Changes by Éric Araujo mer...@netwok.org: -- Removed message: http://bugs.python.org/msg122428 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7918 ___

[issue7918] distutils always ignores byte compilation errors

Donald Stufft added the comment: It would also break some 2/3 compatible projects who have a python3 and a python2 file sitting next to each other and dynamically selected and imported based on Python version. -- nosy: +dstufft ___ Python tracker

[issue7918] distutils always ignores byte compilation errors

Éric Araujo added the comment: This may have been done on purpose, to allow nearly-valid Python files to be packaged. In other bug reports we got some use cases: files used as templates; custom dialects converted by import hooks; 2.x and 3.x code in the same sdist. In that light, I think