Changes by mpb mpb.m...@gmail.com:
--
nosy: +mpb
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
___
Python-bugs-list mailing list
Kazuhiro Yoshida added the comment:
Thanks for a comment.
I've made a version that adds a line to the document.
--
Added file: http://bugs.python.org/file29776/issue-8109.patch
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 4ae6095b4638 by Antoine Pitrou in branch 'default':
Fix a crash when setting a servername callback on a SSL server socket and the
client doesn't send a server name.
http://hg.python.org/cpython/rev/4ae6095b4638
--
Antoine Pitrou added the comment:
Thank you for finding this! The patch is now committed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Kazuhiro Yoshida added the comment:
I am trying to use SSLContext.set_servername_callback in my program but when a
callback is set, it seems that connecting to the server without providing a
server name causes a segmentation fault. (e.g. 'openssl s_client -connect
localhost:443 -servername
Daniel Black added the comment:
nice patch. Thanks for finding the bug. I like the solution with test case.
Just needs a small enhancement of documention to ensure other users expect this
behaviour.
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Fixed in 52b4d9bfc9ea (Roundup e-mail gateway seems broken).
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
(testing Roundup mail gateway, please ignore)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
___
Roundup Robot added the comment:
New changeset 927afb7bca2a by Antoine Pitrou in branch 'default':
Issue #8109: The ssl module now has support for server-side SNI, thanks to a
:meth:`SSLContext.set_servername_callback` method.
http://hg.python.org/cpython/rev/927afb7bca2a
--
nosy:
Antoine Pitrou added the comment:
I've committed the latest patch. Thank you very much!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
danblack added the comment:
I've committed the latest patch. Thank you very much!
much appreciate your help.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Christian Heimes added the comment:
Coverity reports an issue in the callback function:
/Modules/_ssl.c: 2403 ( uninit_use)
2400/* remove race condition in this the call back while if
removing the
2401 * callback is in progress */
2402
danblack added the comment:
I don't know which error code should be returned in this case.
Thanks Christian. My fault - asked Antoine to remove the default value for it
and didn't see this like.
make line 2403:
return SSL_TLSEXT_ERR_OK;
--
___
Antoine Pitrou added the comment:
Here is an updated patch with cyclic GC support, and other small things.
--
components: +Library (Lib) -Extension Modules
Added file: http://bugs.python.org/file28565/sni.patch
___
Python tracker
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file28565/sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file28566/sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Antoine Pitrou added the comment:
Updated patch after Daniel's comments.
--
Added file: http://bugs.python.org/file28568/sni2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
danblack added the comment:
If it isn't very clear to you, I can still handle it myself, though. Those
docs aren't the best.
Not clear enough. Yes I'd appreciate you handling it. Thanks.
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
I've posted a few more comments.
As for cyclic garbage collection, it's explained a bit there:
http://docs.python.org/dev/extending/newtypes.html#supporting-cyclic-garbage-collection
If it isn't very clear to you, I can still handle it myself, though. Those
Changes by danblack daniel.bl...@openquery.com:
Added file: http://bugs.python.org/file28326/issue-8109-sni-serverside.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
danblack added the comment:
I've added a full set of alert descriptions and cleaned up the doco some more.
The reference counting when the SNI callback comes in is my greatest worry.
--
Added file: http://bugs.python.org/file28271/issue-8109-sni-serverside.patch
danblack added the comment:
Antoine Pitrou (pitrou) * Date: 2012-10-06 13:10
Daniel, I'll take a look.
minor nag :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:
--
nosy: +piotr.dobrogost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
___
Antoine Pitrou added the comment:
Daniel, I'll take a look.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
___
Python-bugs-list mailing
danblack added the comment:
happy with this?
I'm not sure what i've done to make s._set_context(newctx) work but s.context =
newctx fail. I though the code here
http://bugs.python.org/review/8109/diff2/5815:5989/Lib/ssl.py effectively maps
them.
--
Changes by danblack daniel.bl...@openquery.com:
Removed file: http://bugs.python.org/file26950/issue8109_server_side_sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
danblack added the comment:
Daniel, your patch looks quite interesting. Please, send a contributor
agreement to the PSF: http://www.python.org/psf/contrib/contrib-form-python/
. Let me know when you status have changed.
Already done. Has been accepted and I've got an acknowledgement email.
Jesús Cea Avión added the comment:
Daniel, your patch looks quite interesting. Please, send a contributor
agreement to the PSF: http://www.python.org/psf/contrib/contrib-form-python/ .
Let me know when you status have changed.
Why are you changing Lib/test/keycert2.pem?
Please, provide also
Changes by Jesús Cea Avión j...@jcea.es:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
___
danblack added the comment:
test_sni not working. getpeercert() not returning a certificate.
--
keywords: +patch
nosy: +daniel-black
Added file: http://bugs.python.org/file26950/issue8109_server_side_sni.patch
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
Server side SNI is still missing.
Right, re-opening.
--
resolution: duplicate -
stage: - needs patch
status: closed - open
superseder: Support TLS SNI extension in ssl module -
title: Support for TLS Server Name Indication extension
31 matches
Mail list logo
