STINNER Victor victor.stin...@haypocalc.com added the comment:
Oh, sigwait() doesn't accept a timeout! I would be nice to have
also sigwaitinfo().. and maybe also its friend, sigwaitinfo()
Oops, I mean sigtimedwait() and sigwaitinfo().
--
___
Charles-François Natali neolo...@free.fr added the comment:
I just noticed something funny: signal_sigwait doesn't release the
GIL, which means that it's pretty much useless :-)
Patch attached.
Also, test_sigwait doesn't block the signal before calling sigwait: it
happens to work because
Giampaolo Rodola' g.rod...@gmail.com added the comment:
This whole thread is becoming quite confusing.
It would be better to open a separate issue for any bug or feature request
which is not related to exposing signalfd(2) and pthread_sigmask.
--
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
___
Charles-François Natali neolo...@free.fr added the comment:
The wakeup fd now contains the number of each signal, and so the behaviour has
to change. I applied your patch and I added a test.
Interesting. I suspected this would have an impact on the test_signal
failure on the FreeBSD 6.4
Roundup Robot devnull@devnull added the comment:
New changeset 29e08a98281d by Victor Stinner in branch 'default':
Issue #8407: test_signal doesn't check signal delivery order
http://hg.python.org/cpython/rev/29e08a98281d
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Cool, x86 FreeBSD 6.4 3.x is green for the first time since a long time,
thanks to my commit 29e08a98281d (test_signal doesn't check signal delivery
order).
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Oh, sigwait() doesn't accept a timeout! I would be nice to have also
sigwaitinfo().. and maybe also its friend, sigwaitinfo() (if we implement the
former, it's trivial to implement the latter). Python 3.3 adds optional timeout
Charles-François Natali neolo...@free.fr added the comment:
New changeset f8c49a930015 by Victor Stinner in branch 'default':
Issue #8407: The signal handler writes the signal number as a single byte
http://hg.python.org/cpython/rev/f8c49a930015
There's a race.
If a signal is received while
Roundup Robot devnull@devnull added the comment:
New changeset 234021dcad93 by Victor Stinner in branch 'default':
Issue #8407: Fix the signal handler of the signal module: if it is called
http://hg.python.org/cpython/rev/234021dcad93
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
There's a race. If a signal is received while is_tripped is set,
the signal number won't be written to the wakeup FD.
Oh, nice catch. The bug is not new, Python behaves like that since Python
3.1. But in Python 3.3, it doesn't
Stefan Krah stefan-use...@bytereef.org added the comment:
There are warnings on the FreeBSD and OSX buildbots, where pthread_t
is not a long.
http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/237/steps/compile/logs/warnings%20%283%29
Roundup Robot devnull@devnull added the comment:
New changeset 2e0d3092249b by Victor Stinner in branch 'default':
Issue #8407: Use an explicit cast for FreeBSD
http://hg.python.org/cpython/rev/2e0d3092249b
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
New changeset f8c49a930015 by Victor Stinner in branch 'default':
Issue #8407: The signal handler writes the signal number as a single byte
Wakeup test using two pending signals fails on FreeBSD 6.4 buildbot:
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
___
Python-bugs-list mailing list
STINNER Victor victor.stin...@haypocalc.com added the comment:
I mistakenly removed your pending_signals-2 patch
I'm really sorry about this, could you re-post it?
No problem, anyway I worked on a new version in the train.
So, if anything, you shouldn't check for a pending signal [in
STINNER Victor victor.stin...@haypocalc.com added the comment:
Note: we might expose pth_raise() which is similar to pthread_kill(), but...
pth support was deprecated by the PEP 11 and pth support will be removed from
Python 3.3 source code.
--
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
About signalfd(): this patch doesn't provide any information or tool to decode
data written to the file descriptor. We should expose the signalfd_siginfo
structure or you cannot handle more than one signal (how do you know which
STINNER Victor victor.stin...@haypocalc.com added the comment:
wakeup_signum.patch: simple patch to write the signal number (as a single byte)
instead of just b'\x00' into the wake up file descriptor. It gives the ability
to watch more than one signal and be able to know which one was raised.
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21883/pending_signals.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
pending_signals-3.patch: doc nit, the link to Thread.ident doesn't work. The
doc should be replaced by something like:
*thread_id* can be read from the :attr:`~threading.Thread.ident` attribute
of a
STINNER Victor victor.stin...@haypocalc.com added the comment:
The threading has a function to get directly the identifier of the current
thread: threading._get_ident() instead of threading.current_thread().ident. I
think that threading._get_ident() is more reliable to
Antoine Pitrou pit...@free.fr added the comment:
pending_signals-3.patch:
- don't check for pending signals in sigwait()
- pthread_kill() doc: it is not a good idea to say that pthread_kill() with
signum=0 can be used to check if a thread identifier is valid = such test
does crash
Roundup Robot devnull@devnull added the comment:
New changeset 1d8a57deddc4 by Victor Stinner in branch 'default':
Issue #8407: Add pthread_kill(), sigpending() and sigwait() functions to the
http://hg.python.org/cpython/rev/1d8a57deddc4
--
___
Roundup Robot devnull@devnull added the comment:
New changeset f8c49a930015 by Victor Stinner in branch 'default':
Issue #8407: The signal handler writes the signal number as a single byte
http://hg.python.org/cpython/rev/f8c49a930015
--
___
Python
Roundup Robot devnull@devnull added the comment:
New changeset e3cb2c99a5a9 by Victor Stinner in branch 'default':
Issue #8407: Remove debug code from test_signal
http://hg.python.org/cpython/rev/e3cb2c99a5a9
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Update the signalfd patch (version 4) against the default branch. Specify the
minimum Linux version in signalfd() doc. The patch still lacks a structure to
parse the bytes written into the file (see msg135438 for a ctypes example):
Changes by Charles-François Natali neolo...@free.fr:
Removed file: http://bugs.python.org/file21901/pending_signals-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
Charles-François Natali neolo...@free.fr added the comment:
Oops.
Victor, my mouse got stuck and I mistakenly removed your pending_signals-2
patch. I'm really sorry about this, could you re-post it?
To try to make up for this, a small comment:
In signal_sigwait, at the end of the function,
Antoine Pitrou pit...@free.fr added the comment:
Quick review at http://bugs.python.org/review/8407/show
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
http://bugs.python.org/review/8407/show
Updated patch (version 2).
Note: sigpending() doesn't return an error code but -1 on error.
--
Added file: http://bugs.python.org/file21901/pending_signals-2.patch
STINNER Victor victor.stin...@haypocalc.com added the comment:
c) Skip the test if the _tkinter thread is present (...)
I opened issue #11998 for the problem with test_signal and the _tkinter module.
To get back green buildbots, I commited a workaround:
New changeset 88dca05ed468 by Victor
Roundup Robot devnull@devnull added the comment:
New changeset a5890ff5e3d5 by Victor Stinner in branch 'default':
Issue #8407: signal.pthread_sigmask() returns a set instead of a list
http://hg.python.org/cpython/rev/a5890ff5e3d5
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
pending_signals.patch: add pthread_kill(), sigpending() and sigwait() functions
with doc and tests.
I added many See also in the doc, e.g. os.kill() gives a link to
signal.pthread_kill().
Note: the patch renames also
Roundup Robot devnull@devnull added the comment:
New changeset d003ce770ba1 by Victor Stinner in branch 'default':
Issue #8407: Fix pthread_sigmask() tests on Mac OS X
http://hg.python.org/cpython/rev/d003ce770ba1
--
___
Python tracker
Roundup Robot devnull@devnull added the comment:
New changeset c9207c6ce24a by Victor Stinner in branch 'default':
Issue #8407: pthread_sigmask() checks immediatly if signal handlers have been
http://hg.python.org/cpython/rev/c9207c6ce24a
--
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Since the commit c9207c6ce24a, test_signal fails on OpenIndiana:
http://www.python.org/dev/buildbot/all/builders/x86%20OpenIndiana%203.x/builds/1179
==
ERROR:
Roundup Robot devnull@devnull added the comment:
New changeset 96a532eaa2d1 by Victor Stinner in branch 'default':
Issue #8407: disable faulthandler timeout thread on all platforms
http://hg.python.org/cpython/rev/96a532eaa2d1
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Since the commit c9207c6ce24a, test_signal fails on OpenIndiana:
http://www.python.org/dev/buildbot/all/builders/x86%20OpenIndiana%203.x/builds/1179
==
ERROR:
STINNER Victor victor.stin...@haypocalc.com added the comment:
test_signal.PthreadSigmaskTests fails on Mac OS X.
http://www.python.org/dev/buildbot/all/builders/PPC Leopard
3.x/builds/1785/steps/test/logs/stdio
http://www.python.org/dev/buildbot/all/builders/PPC Tiger
STINNER Victor victor.stin...@haypocalc.com added the comment:
Update signalfd patch.
--
Added file: http://bugs.python.org/file21856/signalfd-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21841/signalfd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
Antoine Pitrou pit...@free.fr added the comment:
Update signalfd patch.
--
Added file: http://bugs.python.org/file21856/signalfd-2.patch
- In the tests, you don't need sys.exc_info(), just
except XXXError as e.
- In the doc, you wrote file description instead of file descriptor
-
STINNER Victor victor.stin...@haypocalc.com added the comment:
Fixed: updated patch (version 3).
--
Added file: http://bugs.python.org/file21857/signalfd-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21856/signalfd-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
test_signal.PthreadSigmaskTests fails on Mac OS X.
The problem is that sometimes SIG_UNBLOCK does not immediatly call the pending
signal, but it calls it later. The problem is that I don't know exactly when.
I tried to wait the
Roundup Robot devnull@devnull added the comment:
New changeset 28b9702a83d1 by Victor Stinner in branch 'default':
Issue #8407, issue #11859: Add signal.pthread_sigmask() function to fetch
http://hg.python.org/cpython/rev/28b9702a83d1
--
nosy: +python-dev
STINNER Victor victor.stin...@haypocalc.com added the comment:
signalfd.patch: Add signal.signalfd(), signal.SFD_CLOEXEC and
signal.SFD_NONLOCK.
The patch is based on http://codereview.appspot.com/1132041 and the last
version (bzr) of python-signalfd.
The patch uses also
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
title: expose signalfd(2) and sigprocmask(2) in the signal module - expose
signalfd(2) and pthread_sigmask in the signal module
___
Python tracker rep...@bugs.python.org
49 matches
Mail list logo
