Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r81043 (trunk) and r81044 (3.2).
Thanks for your comments.
--
assignee: josiahcarlson - giampaolo.rodola
components: +Tests
resolution: - fixed
stage: - committed/rejected
versions: +Python 2.7, Python 3.2
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8490
___
___
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I have adjusted the failing tests in r80895 and r80930 which now pass on
Solaris.
It seems Solaris has two problems:
- OOB data (aka handle_expt) doesn't work, but I'm not too worried about this
as it's very rarely used. In past there
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Builbots are all ok except Solaris which makes me think that maybe asyncore is
broken on such platform:
http://python.org/dev/buildbot/builders/sparc%20solaris10%20gcc%20trunk/builds/728/steps/test/logs/stdio
I've tried to adjust the tests
Antoine Pitrou pit...@free.fr added the comment:
Some remarks:
- I agree with RDM's comment regarding inheritance
- you don't use use_poll in loop_waiting_for_flag()
- calling time.sleep() in loop_waiting_for_flag() looks wrong to me
- test_handle_error should check that the exception state is
Giampaolo Rodola' g.rod...@gmail.com added the comment:
should be 'listens'
[...]
should be 'bound'
done
I'd prefer to see a 'BaseTestAPI' that has no base class, and two
TestCase subclasses that use BaseTestAPI as a mixin, one for
use_poll=True and one for use_poll=False.
done
- you
New submission from Giampaolo Rodola' g.rod...@gmail.com:
The patch in attachment provides actual tests for asyncore.dispatcher class
API, including all handle_* callback methods.
--
assignee: josiahcarlson
files: asyncore.patch
keywords: patch, patch
messages: 103896
nosy:
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for writing these.
The patch looks good to me (caveat: I only have a passing familiarity with
asyncore). A couple of English nits:
A server which listen on an address and dispatches the
should be 'listens'
# EADDRINUSE
