Changes by Éric Araujo mer...@netwok.org:
--
resolution: accepted - out of date
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Éric Araujo mer...@netwok.org added the comment:
Changing “if s in 'yn'” to “if s in ('y', 'n')” is not really an
improvement. It’s not more readable to always use tuples or frozensets
for membership testing; str has __contains__ for a reason :)
Let me eat my words: using “in 'yn'” matches
Changes by Michael Mulich michael.mul...@gmail.com:
--
nosy: +michael.mulich
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
___
Éric Araujo mer...@netwok.org added the comment:
FYI, the mkcfg module has seen a lot of change since last summer, some of which
have bad style. I still have this bug on my todo list to fix that.
--
___
Python tracker rep...@bugs.python.org
Changes by Sean Reifschneider j...@tummy.com:
--
nosy: -jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
___
Python-bugs-list mailing
Changes by Éric Araujo mer...@netwok.org:
--
versions: +3rd party -Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Éric Araujo mer...@netwok.org added the comment:
I have six changesets that make progressive improvements on cosmetic things, so
that the code gets more readable. You can start with
http://bitbucket.org/Merwok/distutils2-killsetup/changeset/5e2906cabeab and
follow the parent links.
The other
Éric Araujo mer...@netwok.org added the comment:
After speaking with a Montreal-Python hacker about my use case and reading the
PyMOTW page for cmd, I think that using raw_input and print is actually the way
to go. We don’t want the user to enter commands, just to answer questions.
--
Éric Araujo mer...@netwok.org added the comment:
I’m assigning this bug to myself as part of my work on #8252. Dan, I’ll sort
the various fixes in your patch and replay them incrementally. I’ll be pleased
to work with you if you have time (find me in #distutils or through email), if
you don’t
Éric Araujo mer...@netwok.org added the comment:
I’ve started to review your patch but I find it a bid unwieldy to read. Would
you mind exporting changesets to patches? I tried to look at your repo, but
didn’t know which branch to look at.
So, thanks for giving us the occasion of thinking
Dan Buch daniel.b...@gmail.com added the comment:
@merwok much thanks for the feedback. After seeing how you're working via
bitbucket I've decided to create a fresh fork from tarek and recreate my patch
in multiple changesets all within the default branch. I'll update the issue
when
Changes by Dan Buch daniel.b...@gmail.com:
Removed file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17407/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Removed file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17408/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Dan Buch daniel.b...@gmail.com added the comment:
The attached mkpkg-round-of-pylinting.patch is known to cleanly apply to
tarek's branch @ 541f90ef0636
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Dan Buch daniel.b...@gmail.com added the comment:
I've started work on cleanup of ``mkpkg.py`` per instruction from jafo, am
pushing to a branch 'mbh/mkpkg-cleanup' of my distutils2 fork:
http://bitbucket.org/meatballhat/distutils2/changeset/be40174c59e2
I'll attach patch(es) when
Dan Buch daniel.b...@gmail.com added the comment:
bump.
Would it be more helpful if I were to submit a patch, too, or is doing so prior
to guidance from the driver (Tarek) frowned upon?
--
___
Python tracker rep...@bugs.python.org
Tarek Ziadé ziade.ta...@gmail.com added the comment:
I am adding Sean (jafo) who wrote this module. He'll have the best answer :)
--
nosy: +jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
New submission from Dan Buch daniel.b...@gmail.com:
On first glance, `distutils2.mkpkg` does not reflect the latest and greatest in
Python coding standards. I'd like to take a stab at PEP-(7|8)'ing the whole
thing, although I know there are other issues open to add features to the
module, so
Éric Araujo mer...@netwok.org added the comment:
Pepeightification is ok for things like whitespace that do not break
compatibility (don’t waste time doing it manually though, we have automated
tools that can be used to reindent the whole of Distutils2). However, renaming
classes and
Dan Buch daniel.b...@gmail.com added the comment:
I probably shouldn't have dropped the PEP8 bomb so much as stated that I feel
the module could use some updating. It's my (very much potentially wrong)
understanding that `distutils2.mkpkg` isn't considered library code so much as
the guts of
24 matches
Mail list logo
