[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: Let's close. This was only ever an issue in Python 2. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Brett Cannon added the comment: Is there any cleanup to worry about as the comment suggests? If not then the patch LGTM if it does lead to any memory leak. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Serhiy Storchaka added the comment: How did you detect a leak Mark? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627 ___ ___ Python-bugs-list

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: Whoops; make that two years ago, not four. The rest stands, though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627 ___

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: How did you detect a leak Mark? Um. It was four years ago. I have no idea. :-) I suspect I was just looking at the C code and being my usual nasty suspicious self. -- ___ Python tracker rep...@bugs.python.org

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Serhiy Storchaka added the comment: May be this patch will fix the issue. -- components: +Interpreter Core keywords: +patch nosy: +serhiy.storchaka stage: - patch review type: - behavior versions: -Python 2.6 Added file: http://bugs.python.org/file36783/issue8627.patch

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Changes by Mark Dickinson dicki...@gmail.com: -- resolution: out of date - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627 ___

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Brett Cannon added the comment: A quick search through typeobject.c in 2.7 didn't show any PyErr_WarnPy3k calls that didn't have their return value checked or propagated. -- resolution: - out of date status: open - closed ___ Python tracker

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: There's still a case where the return value isn't properly propagated: it's the one marked by an 'XXX' in the source. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: It's line 3912 in the current source. The warning is always cleared, which is the wrong thing to do if warnings should be turned into exceptions. -- ___ Python tracker rep...@bugs.python.org

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Brett Cannon added the comment: I can't find it, Mark, after searching through every XXX marker in a 2.7 checkout of Objects/typeobject.c . -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson added the comment: To clarify, here's the bug: the following code should raise an exception, but doesn't: iwasawa:cpython mdickinson$ ./python.exe -3 Python 2.7.3+ (2.7:333fe4c4897a, Nov 17 2012, 18:01:00) [GCC 4.2.1 (Apple Inc. build 5664)] on darwin Type help, copyright,

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Brett Cannon added the comment: Go ahead and reopen. I just couldn't find the lines anymore when I closed it. On Nov 17, 2012 3:07 PM, Mark Dickinson rep...@bugs.python.org wrote: Mark Dickinson added the comment: To clarify, here's the bug: the following code should raise an exception,

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson dicki...@gmail.com added the comment: Removed the __cmp__ warning in r81736, and added a PyErr_Clear() for the __eq__ warning in r81740. I'll leave this open in case anyone wants to figure out how to propagate the warning exception properly. --

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson dicki...@gmail.com added the comment: Not sure why I added 3.1 and 3.2 to the versions. -- versions: -Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson dicki...@gmail.com added the comment: I also have my doubts about the other 'goto error' lines in PyType_Ready, but I haven't figured out how to trigger those gotos in normal code. Trying to figure out how to clean up properly on error in PyType_Ready is making my head hurt.

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

New submission from Mark Dickinson dicki...@gmail.com: Lines 3884 and 3890 of Objects/typeobject.c (trunk, r80782), which check for a subclass overriding __eq__ (or __cmp__) but not __hash__, call PyErr_WarnPy3k but don't check the return value. [This was reported when compiling Python with

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Mark Dickinson dicki...@gmail.com added the comment: Hmm. Fixing this isn't easy: a simple 'if (inherit_slots(...) 0) goto error;' produces a huge reference leak in PyType_Ready. -- ___ Python tracker rep...@bugs.python.org

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Brett Cannon br...@python.org added the comment: I just came across the warning myself (after ignoring all the PyType_INIT() warnings; what to do about those?) and came to the same conclusion: it's a pain to fix. One option is to do a PyErr_Occurred() check at inherit_slots() call sites.

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Nick Coghlan ncogh...@gmail.com added the comment: I haven't looked at this in a while, but I do remember it was hard to get working at all without a ridiculous number of false alarms - type initialisation isn't the most straightforward thing in the world. Agreed the warning for __cmp__

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

Nick Coghlan ncogh...@gmail.com added the comment: (Not sure how relevant my second last paragraph is - I meant to take that out after noticing the MRO details). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8627