Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file18482/sdist-manifest-marker.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file18517/sdist-manifest-marker.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
Éric Araujo mer...@netwok.org added the comment:
New version of the patch to address Tarek’s comments and add NEWS and docs
entries.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
Barry A. Warsaw ba...@python.org added the comment:
This is a regression introduced in 2.6.6rc1. After discussion in irc with
merwok, it is agreed that he will revert to pre-2.6.6rc1 behavior and not apply
any fix. It's way too late to be changing behavior in 2.6.6. Folks using
Python 2.6
Éric Araujo mer...@netwok.org added the comment:
2.6 regression reverted in r83992.
Tarek is okay with my patch for the other branches. I noticed the first fix did
not have a versionadded in the docs, so I’ll add that and commit.
--
assignee: tarek - eric.araujo
priority: release
Éric Araujo mer...@netwok.org added the comment:
Patch committed in r83993 (py3k), r83994 (3.1) and r83996 (2.7).
I got the version wrong in 3.x and fixed it in r83995 and r83998.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Attaching a patch to implement the marker idea. No doc changes yet.
It should work transparently: you don’t have to give an option to have
automatic recalculation, you don’t have to give an option to have it leave your
manual MANIFEST alone.
J. David Ibáñez jda...@itaapy.com added the comment:
This issue has broken our build system too.
A bug has been fixed, but another one is open now.
If the MANIFEST file has been produced by distutils it should be
regenerated each time. But if it has not been produced by distutils
then it
Ronald Oussoren ronaldousso...@mac.com added the comment:
I agree with msg113530 and msg112371 that the current behavior is a bug:
distutils is now too agressive because it recalculates the MANIFEST file even
when distutils isn't the one that calculated it in the first place.
This is a
Tarek Ziadé ziade.ta...@gmail.com added the comment:
I like the idea of a marker in a comment line in the MANIFEST, we can introduce
this as a bug fix to avoid this regression
--
___
Python tracker rep...@bugs.python.org
Changes by Dirkjan Ochtman dirk...@ochtman.nl:
--
nosy: +djc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
___
Python-bugs-list mailing
Matt Mackall m...@selenic.com added the comment:
This change just wrecked Mercurial's release build process.
We've been building Mercurial release tarballs with a Makefile target wrapped
around sdist for most of five years, and we've never had or wanted a
MANIFEST.in file. We generate an
Tarek Ziadé ziade.ta...@gmail.com added the comment:
this fix was done to avoid generating broken MANIFEST file with sdist.
IIUC your problem is more about avoiding generating a MANIFEST file at *all*
via sdist, so we should add a --no-manifest option to the sdist command.
This can be added
Matt Mackall m...@selenic.com added the comment:
Ok, we need a change that will work with Python 2.4 through 2.7.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Follow-up at
http://selenic.com/pipermail/mercurial-packaging/2010-August/09.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
Tarek Ziadé ziade.ta...@gmail.com added the comment:
done in r81255, r81256 (2.6), r81258 (py3), r81260 (3.1)
Thanks Ronald
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
Ronald Oussoren ronaldousso...@mac.com added the comment:
One way to fix this: is to always recreate MANIFEST when an explicit
MANIFEST.in file exists, as in the attached patch.
(The patch is not perfect: I'd rename template_newer before committing)
--
keywords: +needs review, patch
Tarek Ziadé ziade.ta...@gmail.com added the comment:
The same problem occurs without a manifest template: you can have options or
imports in setup.py that will change the MANIFEST file.
For example : if setup() has:
packages=['foo']
And if you add a subpackage bar in foo with some
Changes by Tarek Ziadé ziade.ta...@gmail.com:
--
priority: normal - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
___
Changes by Dan Buch daniel.b...@gmail.com:
--
nosy: +meatballhat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8688
___
___
Python-bugs-list
New submission from Ronald Oussoren ronaldousso...@mac.com:
The sdist command in distutils calculates the MANIFEST file from a template (by
default MANIFEST.in).
The code in sdist assumes that the contents of MANIFEST only depends on
MANIFEST.in and setup.py, which can cause files to be
21 matches
Mail list logo
