STINNER Victor victor.stin...@haypocalc.com added the comment:
One more patch to check sys.getfilesystemencoding() on any OS (r81920).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Is this check needed on darwin? Why not simply set fs_encoding = 'utf-8'?
--
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
Ronald Oussoren ronaldousso...@mac.com added the comment:
I haven't looked at the actual test yet, but the filesystem encoding on OSX is
UTF-8.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Victor,
Your patch works for me and makes sense even though I don't really know where
Py_FileSystemDefaultEncoding is set on Darwin. :-)
--
___
Python tracker
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On the second thought, test_imp is not the right place to test this. Can you
add a sys module test for this issue?
--
stage: - unit test needed
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Patch commited as r81883 (blocked in 3.1: r81884).
Can you add a sys module test for this issue?
Ok, I added a test to test_sys: r81885 (blocked in 3.1: r81886).
I don't really know where Py_FileSystemDefaultEncoding
is set on
STINNER Victor victor.stin...@haypocalc.com added the comment:
Hum. To avoid regression, we should maybe have a test with the C locale.
@belopolsky: Can you try test_sys.patch on Mac OS X?
--
Added file: http://bugs.python.org/file17617/test_sys.patch
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Nope.
$ ./python.exe -m test.regrtest test_sys
test test_sys failed -- Traceback (most recent call last):
File Lib/test/test_sys.py, line 877, in test_getfilesystemencoding
self.assertEqual(fs_encoding, 'utf-8')
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17619/issue8965-test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17620/issue8965-test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file: http://bugs.python.org/file17619/issue8965-test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Sorry for extra traffic. I thought my patch introduced an indentation error,
but it looks like you truly don't check sys.getfilesystemencoding() output if
not on darwin.
--
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17621/issue8965-test-1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8965
___
13 matches
Mail list logo
