Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Committed in r84961
--
stage: patch review - committed/rejected
status: open - closed
type: - behavior
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
Changes by Raymond Hettinger rhettin...@users.sourceforge.net:
--
assignee: rhettinger - stutzbach
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
___
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
How do we mark a test as implementation specific? Is there a decorator for
that?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Nevermind, I found it: @support.cpython_only
I'll work on a patch to add the decorator and a comment about why the test is
fragile.
--
___
Python tracker rep...@bugs.python.org
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
--
keywords: +needs review, patch
resolution: - accepted
stage: needs patch - patch review
Added file: http://bugs.python.org/file18591/issue9131.patch
___
Python tracker
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Removed file: http://bugs.python.org/file18591/issue9131.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
___
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
errr... ignore that first patch (now deleted)
:-)
--
Added file: http://bugs.python.org/file18592/issue9131.patch
___
Python tracker rep...@bugs.python.org
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Removed file: http://bugs.python.org/file18592/issue9131.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
___
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
Added file: http://bugs.python.org/file18593/issue9131.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
___
New submission from Daniel Stutzbach dan...@stutzbachenterprises.com:
test_set_reprs in test_pprint creates a complex arrangement of frozensets and
tests the pretty-printed repr against a string hard-coded in the test. The
hard-coded repr depends on the sort order of frozensets.
However,
Mark Dickinson dicki...@gmail.com added the comment:
I agree that this looks a bit suspicious.
Adding Raymond to the nosy list, since it looks like this is his code (r60264).
--
nosy: +mark.dickinson, rhettinger
___
Python tracker
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Yes, it's a fragile and crummy test.
Feel free to delete it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9131
___
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
After discussion on #python-dev, have decided to mark the test as
implementation specific and add a comment about why the test is fragile.
--
assignee: stutzbach - rhettinger
___
13 matches
Mail list logo
