[issue9155] Reserve COMPARE_OP for rich comparisons

2010-09-01 Thread Daniel Stutzbach
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com: -- nosy: +stutzbach ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___ ___

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-09-01 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: I'm marking this one as rejected. The timings have shown mixed results (some favorable, some not). In general, there is a bias against expanding the number of opcodes because 1) there aren't that many codes available, 2)

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-08 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I would like any such change to show what it improves through benchmarks. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-08 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +jyasskin, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___ ___ Python-bugs-list

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-08 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: The seperation of COMPARE_OP into multiple opcodes shouldn't affect cache size since the opcodes are aliased. Spreading out the switch statement shouldn't cause issue from flattening, since GCC would inline the single use of cmp_outcome.

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-08 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: Replaced TARGET_DUP_TOPX with _unknown_opcode I recompiled with --with-computed-gotos, and the results remain promising, though the interpreter instead grows from 6756023B to 6765167B -- Added file:

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-08 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Here, your patch actually show a slowdown on pybench with computed gotos. Results attached. -- Added file: http://bugs.python.org/file17904/pybench.txt ___ Python tracker rep...@bugs.python.org

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-05 Thread Éric Araujo
Changes by Éric Araujo mer...@netwok.org: -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-05 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: I've fixed the segfaulting in IN and NOT_IN, though the code requires cleaning due to the obtusely cargo culted nature of those opcodes I'm also including an incrementation which completely removes COMPARE_OP, using the opcode to determine

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-05 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: It seems the lack of benefits from replacing COMPARE_OP with a set of aliased bytecodes was repairable through TARGET_WITH_IMPL. Also fixed was the lack of amendments to dis -- versions: -Python 3.3 Added file:

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Changes by Demur Rumed junkm...@hotmail.com: -- title: Reserve COMPARE_OP for RichComparisons - Reserve COMPARE_OP for rich comparisons ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: Any chance you could regenerate the patch without all the unnecessary whitespace changes? It's kinda hard to read right now. -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Alexander Belopolsky
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___ ___

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Changes by Demur Rumed junkm...@hotmail.com: Added file: http://bugs.python.org/file17856/cmpoppatch2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: I've attached the original patch without whitespace, and am also including modifications to this portion of the interpreter which remove ROT_FOUR, DUP_TOPX while adding ROT_THREE_TWO, DUP_TOP_TWO, DUP_ROT_THREE. I've seen a 5% speed increase

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: I've attached the original patch without whitespace, and am also including modifications to this portion of the interpreter which remove ROT_FOUR, DUP_TOPX while adding ROT_THREE_TWO, DUP_TOP_TWO, DUP_ROT_THREE. I've seen a 4% speed increase

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Changes by Demur Rumed junkm...@hotmail.com: Removed file: http://bugs.python.org/file17859/cmpoprotdup.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Demur Rumed
Demur Rumed junkm...@hotmail.com added the comment: Fixed regression in ROT_THREE_TWO and a missed DUP_TOP2 - DUP_TOP_TWO. Now there are only the odd segfaults -- Added file: http://bugs.python.org/file17861/cmpoprotdup2.diff ___ Python tracker

[issue9155] Reserve COMPARE_OP for rich comparisons

2010-07-04 Thread Raymond Hettinger
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- assignee: - rhettinger nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9155 ___