STINNER Victor added the comment:
> For the other referenced issue1153027, bug is not reproducible in the
> trunk and I see that fix has been made in revision 43132.
This change was a fix for bpo-1353433:
commit ddb84d7c69addc5d5e2ab3e327260d97b52af3a7
Author: Georg Brandl
Date: Sat Mar
Adam Nelson a...@varud.com added the comment:
I can't think of too many specific scenarios. It just seems like a non-
trivial behavior change (or rather, it is trivial but with possibly far
reaching ramifications).
One issue I see is that the ticket morphed from just dealing with space
Adam Nelson a...@varud.com added the comment:
This seems a bit serious for inclusion in 2.7 IMHO. urllib is used in all
sorts of hackish ways in the wild and I really wonder if this is going to
cause more problems for people than it's worth. The 3.x series alone
seems like the best place
Senthil Kumaran orsent...@gmail.com added the comment:
AdamN, did you specifically come across a scenario which broke due to
this change? I can understand your concern, in general. The
'non-breaking' existing tests is the one of confidence factor we have in
introducing the changes.
--
Changes by Senthil orsent...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
___
Python-bugs-list
Changes by Senthil orsent...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
___
Python-bugs-list
Senthil orsent...@gmail.com added the comment:
Fixed this in the revision 71780 for Python 2.7.
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
Senthil orsent...@gmail.com added the comment:
The attached patch fixes this issue and adds the test too. Followed John
J Lee's suggestion for the patch.Can someone review this?
For the other referenced issue1153027, bug is not reproducible in the
trunk and I see that fix has been made in
Changes by Jeremy Hylton jer...@alum.mit.edu:
--
nosy: +jhylton
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
___
Python-bugs-list
Changes by Daniel Diniz aja...@gmail.com:
--
dependencies: +http_error_302() crashes with 'HTTP/1.1 400 Bad Request
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
John J Lee jj...@users.sourceforge.net added the comment:
Mike's list is missing one more character, % itself. So, the
replacement should be:
quote(newurl, safe=%/:=?~#+!$,;'@()*[])
The replacement should be done in the .open() method, not in the code
that handles redirects.
John J Lee jj...@users.sourceforge.net added the comment:
A suitable test would be to derive a urllib.URLOpener subclass that has
an open_spam(url) method which records the URL. Then call
.open(spam://) in the test and verify that the URL has been quoted.
John J Lee jj...@users.sourceforge.net added the comment:
Uh, that should have beeen something like
.open(spam://example.com/%2E/) of course.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
Daniel Diniz aja...@gmail.com added the comment:
Any idea about how to test this one reliably?
--
stage: - test needed
type: - behavior
versions: +Python 2.6, Python 2.7 -Python 2.3
___
Python tracker rep...@bugs.python.org
Rob Probin rob...@users.sourceforge.net added the comment:
I agree - this appears to be the same as issue 1153027 ?
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
John J Lee jj...@users.sourceforge.net added the comment:
This bug refers to urllib. Issue 1153027 refers to urllib2. It's the
same problem in each case, though.
--
nosy: +jjlee
___
Python tracker rep...@bugs.python.org
Daniel Diniz aja...@gmail.com added the comment:
Superseded by issue 1153027 ?
--
nosy: +ajaksu2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
17 matches
Mail list logo
