[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Berker Peksag added the comment: New changeset 0e6cb2ea624570ed08c354f1ed1f595dab4192d6 by Berker Peksag (Aviv Palivoda) in branch 'master': bpo-26187: Test that set_trace_callback() is not called multiple times (GH-461)

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Donald Stufft : -- pull_requests: +920 ___ Python tracker ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Berker Peksag added the comment: New changeset 86a670543ff97d52fd9b8ca0477f8b6d27ee946d by Berker Peksag (Aviv Palivoda) in branch 'master': bpo-9303: Migrate sqlite3 module to _v2 API to enhance performance (#359)

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Larry Hastings : -- pull_requests: -583 ___ Python tracker ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Larry Hastings : -- pull_requests: +583 ___ Python tracker ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Berker Peksag added the comment: I will add commit information manually: https://github.com/python/cpython/commit/86a670543ff97d52fd9b8ca0477f8b6d27ee946d Thanks! -- ___ Python tracker

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Berker Peksag : -- resolution: postponed -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Aviv Palivoda added the comment: I changed the patch to use SQLITE_VERSION_NUMBER and it looks way better. Thanks Serhiy -- ___ Python tracker ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Serhiy Storchaka added the comment: > sqlite3_open_v2 - 2007-09-04 (3.5.0) alpha > sqlite3_prepare_v2 - 2007-01-04 (3.3.9) > sqlite3_close_v2 - 2012-09-03 (3.7.14) There are compile-time checks for supporting SQLite older than 3.2.2. I think it is better to use the preprocessor rather of

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Aviv Palivoda added the comment: from https://www.sqlite.org/changes.html: sqlite3_open_v2 - 2007-09-04 (3.5.0) alpha sqlite3_prepare_v2 - 2007-01-04 (3.3.9) sqlite3_close_v2 - 2012-09-03 (3.7.14) In issue 29355 Ma Lin says that RHEL6 comes with SQLite 3.6.x. I think that removing that

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Serhiy Storchaka added the comment: Is detection in the configure script needed? What are SQLite versions in which _v2 APIs were added? What is minimal supported SQLite version? Don't forget about Windows where autotools are not used. -- nosy: +serhiy.storchaka versions: +Python 3.7

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Aviv Palivoda added the comment: I opened a PR. This actually is a bugfix in addition to an enhancement as it solves issue 26187 as well. -- ___ Python tracker

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Aviv Palivoda : -- pull_requests: +306 ___ Python tracker ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Dima Tisnek added the comment: Can someone review Aviv's patch? -- ___ Python tracker ___ ___ Python-bugs-list

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Aviv Palivoda added the comment: I made a new patch to fix this issue. I left a fallback to the old API as Jim suggested. In addition to the changes in Robin`s patch I changed sqlite3_close to sqlite3_close_v2 if available. This solves issue 26187 as well. -- nosy: +palaviv Added

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Berker Peksag : -- nosy: +berker.peksag type: performance -> enhancement ___ Python tracker ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Gerhard Häring added the comment: The externally maintained version of the sqlite3 module has now been switched to the v2 statement API. pysqlite is for Python 2.7 only. I'd suggest to revisit this for Python 3.6 and then try to port most fixes from pysqlite to the sqlite3 module. --

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___ ___ Python-bugs-list

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Dima Tisnek added the comment: Is there any hope? Surely sqlite backwards compatibility is not an issue any longer... -- nosy: +Dima.Tisnek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Gerhard Häring added the comment: ok, i will have to look into this -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___ ___ Python-bugs-list

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Antoine Pitrou pit...@free.fr: -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___ ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Antoine Pitrou added the comment: This would be nice to have in 3.4. When were the _v2 APIs introduced? See also issue13773 which uses sqlite3_open_v2() to pass some flags. -- nosy: +larry, pitrou versions: +Python 3.4 -Python 3.3 ___ Python tracker

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Petri Lehtinen pe...@digip.org added the comment: What Sqlite version are you targeting? Some systems use quite old Sqlite versions, see #14572 for example. -- nosy: +petri.lehtinen ___ Python tracker rep...@bugs.python.org

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Antoine Pitrou pit...@free.fr: -- stage: needs patch - patch review versions: +Python 3.3 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Robin Schreiber robin.schrei...@me.com added the comment: I have now submitted a patch, which swapped out all the necessary calls. Tests are all running as expected. I will now try to remove some backwards compatibility code. -- keywords: +patch Added file:

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Robin Schreiber robin.schrei...@me.com: Removed file: http://bugs.python.org/file25211/sqlite.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Robin Schreiber robin.schrei...@me.com: Added file: http://bugs.python.org/file25212/sqlite.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303 ___

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Jim Jewett jimjjew...@gmail.com added the comment: I can't speak for GSoC or Gerhard, but it strikes me as a reasonable first step. An alternatives woube be writing it with fallbacks (so older sqlite can still be used, though less efficiently). It would also be nice to clean up at least one

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Robin Schreiber robin.schrei...@me.com added the comment: Apparently this issue has not been dealt with for quite some time now. As a prospective GSoC student, I still need to submit a patch to pass final screening and I thought, that the needed patch here would be quite suitable for a

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

New submission from Michael Schwarz michi.schw...@gmail.com: The Python sqlite module currently uses some deprecated API [0] of SQLite. These are functions that have a counterpart with _v2 appended to their name. The SQLite query planner will not use certain optimizations when using the old

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Changes by Antoine Pitrou pit...@free.fr: -- assignee: - ghaering nosy: +ghaering stage: - needs patch versions: +Python 3.2 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9303

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

Gerhard Häring g...@ghaering.de added the comment: Yes, the sqlite module uses the old API, and is written to work with older SQLite releases and their respective bugs as well. Using the new API will mean requiring newer SQLite releases. If we do this, then this is the chance to remove all