[issue940286] pydoc.Helper.help() ignores input/output init parameters

miss-islington added the comment: New changeset e9e6495eedd7fb588964ffa50e8bf2c5ce9c6051 by Miss Islington (bot) in branch '3.6': bpo-940286: Fix pydoc to show cross refs correctly (GH-8390) https://github.com/python/cpython/commit/e9e6495eedd7fb588964ffa50e8bf2c5ce9c6051 -- nosy:

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Change by Berker Peksag : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Berker Peksag added the comment: New changeset 14f58f0ff823ba71e3f21803c509d348626b6089 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-940286: Fix pydoc to show cross refs correctly (GH-8390) https://github.com/python/cpython/commit/14f58f0ff823ba71e3f21803c509d348626b6089

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Change by miss-islington : -- pull_requests: +7928 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Change by miss-islington : -- pull_requests: +7929 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Berker Peksag added the comment: New changeset d04f46c59f1d07d9bcc0ba910741296ac88d370d by Berker Peksag in branch 'master': bpo-940286: Fix pydoc to show cross refs correctly (GH-8390) https://github.com/python/cpython/commit/d04f46c59f1d07d9bcc0ba910741296ac88d370d --

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Éric Araujo added the comment: Patch works! -- assignee: eric.araujo -> berker.peksag ___ Python tracker ___ ___ Python-bugs-list

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Berker Peksag added the comment: I just noticed the same bug described by Éric in msg127840. PR 8390 should fix it. Unfortunately, it wasn't easy to create a test case, so I skipped that part. I'm open to suggestions if you have an idea on how to write a simple test that reproduces the bug.

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Change by Berker Peksag : -- pull_requests: +7918 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___ ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Mark Lawrence added the comment: One commit already so presumably not too much effort needed to close this one. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Kevin Le solno...@gmail.com added the comment: confirmed, I'll take a closer look -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___ ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Changes by Éric Araujo mer...@netwok.org: -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___ ___ Python-bugs-list

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Éric Araujo mer...@netwok.org added the comment: I just added another comment on Rietveld because I thought this was not fixed :) Demo session: $ pydoc3.2 nonlocal # will launch my pager, then print to stdout Related help topics: global, NAMESPACES Kevin Le, would you like to write a

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Georg Brandl ge...@python.org added the comment: Looks good; committed in r86957. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Changes by Éric Araujo mer...@netwok.org: -- assignee: - eric.araujo versions: -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Éric Araujo mer...@netwok.org added the comment: Patchset 3 on codereview looks good. I’d like another review, so I’m adding the latest developers who touched pydoc. -- nosy: +belopolsky, georg.brandl ___ Python tracker rep...@bugs.python.org

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Changes by Éric Araujo mer...@netwok.org: -- stage: unit test needed - patch review versions: +Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Kevin Le solno...@gmail.com added the comment: This patch redirects output from Helper.help to whatever output stream is passed to the Helper constructor. If no output stream is specified, the fault behavior is to pass the output to the OS pager. -- keywords: +patch nosy: +bkad

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Kevin Le solno...@gmail.com added the comment: Created a rietveld review http://codereview.appspot.com/3202042 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Éric Araujo mer...@netwok.org added the comment: Thanks for the patch. I commented there. -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Changes by Daniel Diniz aja...@gmail.com: -- keywords: +easy stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286 ___ ___

[issue940286] pydoc.Helper.help() ignores input/output init parameters

Daniel Diniz aja...@gmail.com added the comment: Confirmed. Is it relevant? -- nosy: +ajaksu2 type: - behavior versions: +Python 2.6 -Python 2.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue940286