[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by Berker Peksag : -- dependencies: +Update test_base64 to use test.support.script_helper, Update test_capi to use test.support.script_helper ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan added the comment: Berker committed the original patch to move the helper module, so adjusting the stage back to reflect the ongoing review on related issues. -- keywords: -easy stage: commit review - patch review ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hello all! So the following are waiting for review: * #24033 * #23981 * #24279 I'm going to hold off on continuing to refactor any other modules for the moment, would be great to get the above wrapped up and eventually merged when possible. Thanks! - Christie

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Created issue24398 for updating test_capi. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Created Issue24279 for updating test_base64. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan added the comment: Just noting that issue 18576 has a draft patch for test.support.script_helper documentation (the move to the support module part of the current patch there is obsolete) -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Cool, thanks @ncoghlan! Would you like someone to take on the work of updating the latest patch on issue 18576? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan added the comment: Sure, that would be great. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hey @berker.peksag, @r.david.murray, @serhiy.storchaka, If you get a chance I've got some changes up for review at: * http://bugs.python.org/issue24033 * http://bugs.python.org/issue23981 Thanks! -- ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Thanks very much @berker.peksag! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Roundup Robot added the comment: New changeset f65174aef9ea by Berker Peksag in branch 'default': Issue #9517: Move script_helper to the support package. https://hg.python.org/cpython/rev/f65174aef9ea -- nosy: +python-dev ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by Berker Peksag berker.pek...@gmail.com: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: @serhiy.storchaka - just double checking, do you guys need me to make any more changes to the patch? And is there any more review needed, or is it possible for this to be merged? Thanks very much! -- ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hey @berker.peksag, I've added a new patch in response to your review! You should create the patch with hg diff --git to preserve moving. And then apply it with hg import, not the patch command. Unfortunately Rietveld don't like patches in git format. Ick, I'm

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Serhiy Storchaka added the comment: You should create the patch with hg diff --git to preserve moving. And then apply it with hg import, not the patch command. Unfortunately Rietveld don't like patches in git format. -- nosy: +serhiy.storchaka ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Serhiy Storchaka added the comment: The committer should be careful, and manually make hg mv and apply the patch with the patch command, not hg import. We shouldn't lost the history. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hey @berker.peksag, @r.david.murray! Here's another change set where script_helpers.py is moved with an hg mv (still looks in the patch like the file was deleted and re-added, not sure if that's expected). I've ALSO removed some unused imports from

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Created issue24033. If it and issue23981 could be added as dependencies of this issue (or I could get permission to add them?) that would be swell! -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Berker Peksag added the comment: Thanks for the patch, Christie. Review comments: http://bugs.python.org/review/9517/ (still looks in the patch like the file was deleted and re-added, not sure if that's expected). I don't know if it's important. I'm using a very old version of Mercurial

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: @Christie - Nope. This patch can stand on it's own, simply moving the package to where it belongs. In fact, I'd recommend applying the patch first. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Berker Peksag added the comment: Alternatively, you can import public functions from support/script_helper.py in support/__init__.py. Then you can do from test.support import assert_python_ok -- nosy: +berker.peksag stage: needs patch - patch review versions: +Python 3.5 -Python

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Berker Peksag added the comment: Reviewing iss9517_move_script_helpers_py.patch: * Can you move script_helper.py by using hg mv? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: So @flipmcf we're sticking with the test.support.script_helper namespace? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: @r.david.murray I've created issue23981, I don't think I have permissions to add it as a dependency to this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: Yes, I did miss that. (Root cause: `git diff` instead of `git diff --staging`) Sorry. I'm learning, and decided to take the git path - might not have been the best choice. I'll submit a new patch shortly. --

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: I'm thinking also, maybe instead of putting script_helper into the test.support namespace, we could move the individual methods and helpers from script_helper into test.support, e.g.: test.support.run_python_until_end vs.

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: Uploading new patch that includes the creation of Lib/test/support/script_helper.py -- Added file: http://bugs.python.org/file39038/iss9517_move_script_helpers_py.patch ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray added the comment: I actually originally wanted to do just that (move the script helpers routine into the old support.py) but I was in the minority. test.support was turned into a package exactly so that script_helpers could become a sub-namespace. As I remember, it was Nick

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: I would recommend still moving script_helper into test.support , and adding a list of symbols from script_helper.py into __init__ Sounds like a great plan to me @flipmcf! -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: @r.david.murray and @flipmcf: I've audited all test modules using sys.executable for a starting point, and these tests look like they could benefit from helper methods to invoke python (probably the ones in script_helper, but we may want to create others if the

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: namespaces are a honkin' great idea I don't have enough information to say that 'script_helper' is the right name for the namespace, tho. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: I have a patch for moving script_helper as R. David suggested. Here it is. -- nosy: +flipmcf Added file: http://bugs.python.org/file39003/iss9517_move_script_helpers_py.patch ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hey there @flipmcf, is the change which adds `script_helpers` to test.support is missing from your patch? import test.support.script_helper Traceback (most recent call last): File stdin, line 1, in module ImportError: No module named 'test.support.script_helper'

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: bobcatfish: Sorry, I didn't refresh and see your comment before submitting my patch. It only moves script_helpers, but doesn't address the original OP. Hopefully I made your life easier, not harder. -- ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Michael McFadden added the comment: re: test.test_tools.py - should this also move into test.support ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray added the comment: test_tools is a test suite that tests the tools in the scripts directory, it is not tools for testing. So no, it doesn't belong in test.support. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Okee dokee, I'll tackle that first! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray added the comment: Apparently I was imaginig that script_helpers had been moved into test.support. test.support was changed into a module in prep for doing so, but as far as I can see it was never moved. So that does remain to be done as well, and should be done first.

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Okay thanks @r.david.murray, I'll take a look at doing this. I'll open an issue when I figure out which module to start on. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray added the comment: It could be done either way, but I suspect that indovidual issues for test module changes, entered as dependencies on this issue, is probably the more effective in this case. -- ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: Hello @r.david.murray! We probably don't want a multi-module changeset, though, so this could become a meta issue for new issues for converting particular test files to use script_helpers. Does this mean you'd like to leave this issue open until all of the test

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray added the comment: Script helpers has been made more discoverable by moving it into the test.support namespace, but it has not been documented in the test.support docs. I can no longer remember if this is intentional or not. Regardless, this issue is still valid insofar as

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Rodrigue Alcazar added the comment: @Mark, I had a look at the time I commented on the ticket but didn't get a chance to progress much in the end. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Mark Lawrence added the comment: @Rodrigue did you ever make any progress with this? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Ezio Melotti added the comment: There's already strip_python_stderr() :) This is already used in Lib/test/script_helper.py:42, and a way to call _assert_python() without using -E has also been introduced[0]. The next step would be to check if these functions could be used elsewhere in the

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray rdmur...@bitdance.com added the comment: Here is a patch that causes _assert_python to remove the refcount lines from stderr. -- keywords: +patch Added file: http://bugs.python.org/file19975/script_helper_del_refcount.patch ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray rdmur...@bitdance.com added the comment: Hmm. Having posted that it occurs to me that it could be useful to have the _remove_refcount function in test.support as remove_refcount instead. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Antoine Pitrou pit...@free.fr added the comment: Having posted that it occurs to me that it could be useful to have the _remove_refcount function in test.support There's already strip_python_stderr() :) -- ___ Python tracker

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray rdmur...@bitdance.com added the comment: Oh, good, I'll use that then. I could have sworn I looked for that functionality a couple weeks ago and couldn't find it. -- ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray rdmur...@bitdance.com added the comment: I just tried using script_helper in a new test, so I have a couple of comments. I don't see stdout and stderr being conflated, it looks to me like they are returned separately, at least by the assert methods. The assert methods return

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +michael.foord ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Antoine Pitrou pit...@free.fr added the comment: I just tried using script_helper in a new test, so I have a couple of comments. I don't see stdout and stderr being conflated, it looks to me like they are returned separately, at least by the assert methods. That's because I wrote the

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

R. David Murray rdmur...@bitdance.com added the comment: OK, fine on the convention, but I'd still like a more memorable name for assert_python_failure. I've been working on this issue off and on today, and I've had to look up that name at least four times. I can remember assert_python_ok,

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Rodrigue Alcazar rodriguealca...@gmail.com added the comment: someone wanting to get to know the process of working on CPython without having to deal with anything that is particularly tricky to understand. That sounds exactly like me :) I can have a look at this ticket. -- nosy:

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan ncogh...@gmail.com added the comment: I still think this is a good idea, I'm just not actively working on it. It might make a good project for someone wanting to get to know the process of working on CPython without having to deal with anything that is particularly tricky to

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan ncogh...@gmail.com added the comment: One other feature for the new-and-improved helpers: add a flag to allow -E to be omitted (as per the comment in test_cmd_line) -- assignee: - ncoghlan ___ Python tracker rep...@bugs.python.org

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Nick Coghlan ncogh...@gmail.com added the comment: (The email daemon was not in a happy place, so posting directly) On Thu, Aug 5, 2010 at 8:50 AM, Antoine Pitrou rep...@bugs.python.org wrote: - perhaps improve the existing functions (kill_python() does a strange dance instead of calling

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

New submission from Antoine Pitrou pit...@free.fr: test.script_helper has a couple of dedicated functions to launch a Python interpreter instance in a subprocess. Unfortunately, it is little used and most test modules use their own ad hoc calls to subprocess instead. Remedying the situation