[issue9588] Skip subprocess shell tests on Windows per file association setup

2010-08-13 Thread Brian Curtin
Brian Curtin added the comment: Yeah that's much better :) I should have asked if you left out sys.executable out intentionally before coming up with my patch...I assumed it was intended to be different due to shell=1 or something. Go ahead and apply if you want. -- assignee: brian.c

[issue9588] Skip subprocess shell tests on Windows per file association setup

2010-08-13 Thread Tim Golden
Tim Golden added the comment: Assuming I understand you correctly, could I propose this rather less involved patch which simply specifies the sys.executable as part of the command line. The test doesn't propose to test file associations and indeed two of the test already fill in the executabl

[issue9588] Skip subprocess shell tests on Windows per file association setup

2010-08-13 Thread Brian Curtin
Brian Curtin added the comment: Attached is a patch that fixes this for me, and I *think* it's looking in the most correct area for the information. Tim or any other Windows users, would you mind seeing that the skip does not occur on your machines, thus allowing it to properly run those test

[issue9588] Skip subprocess shell tests on Windows per file association setup

2010-08-13 Thread Brian Curtin
New submission from Brian Curtin : The fix for #2304 causes issues on Windows if you have file associations setup that aren't Python interpters. In my case I have an association setup to open .py files in gvim, which causes the shell tests to hang until I quit the editor, then it fails because