Roundup Robot added the comment:
New changeset 69827c2ab9d0 by Stefan Krah in branch 'default':
Issue #9709: Revert 97fb852c5c26. Many extensions are not using PyMODINIT_FUNC.
http://hg.python.org/cpython/rev/69827c2ab9d0
--
___
Python tracker
Stefan Krah added the comment:
Too many extensions are not using PyMODINIT_FUNC (See #20166).
Closing as WONT_FIX.
--
resolution: fixed - wont fix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Roundup Robot added the comment:
New changeset 97fb852c5c26 by Stefan Krah in branch 'default':
Issue #9709: Stop adding PyInit_ + module_name' to export_symbols. This is
http://hg.python.org/cpython/rev/97fb852c5c26
--
nosy: +python-dev
___
Python
Stefan Krah added the comment:
Éric, thanks for taking a look.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Stefan Krah added the comment:
Is the distutils freeze still in place? If not, I'll commit initfunc2.patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
Éric Araujo added the comment:
The feature freeze was lifted at PyCon 2013. This patch can be committed in
the default branch. Could you add a test?
--
assignee: tarek - eric.araujo
versions: -3rd party, Python 2.7, Python 3.3
___
Python tracker
Éric Araujo added the comment:
Ignore my comment about a test, you already replied to that :) Please commit.
--
assignee: eric.araujo - skrah
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
This warning still appears on buildbots running with warnings turned on.
--
nosy: +terry.reedy
versions: +Python 3.4 -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +jkloth
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
___
Python-bugs-list
Santoso Wijaya santoso.wij...@gmail.com added the comment:
A workaround would be to define an arbitrary macro when building with
distutils. For example, in setup.cfg:
[build_ext]
define = _DISTUTILS
Then in some main header file(s) in your project:
#ifdef _DISTUTILS
#undef
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
versions: +3rd party
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
___
Martin v. Löwis mar...@v.loewis.de added the comment:
Thorsten: my recommendation is to ignore this issue in your software. It's just
a warning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Thorsten Behrens sbehr...@gmx.li added the comment:
Thank you for that patch, Stefan. I am currently tinkering with bringing
pycrypto to 3.x and ran into this issue. initfunc2.patch resolves the issue on
Win7-64, python31-64.
I don't feel comfortable releasing code that requires the user to
Éric Araujo mer...@netwok.org added the comment:
Sounds like a “+1 for the patch” to me :)
I get no warning on linux2 after the patch. This is still a behavior change,
and there might be code out there relying on self.get_export_symbols being
called. My understanding of extension modules
Stefan Krah stefan-use...@bytereef.org added the comment:
Without the patch, you see the warning if test_build_ext is run in
verbose mode. With the patch, the warning disappears.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
The policy for distutils is: no changes, only bug fixes. We cannot remove a
function, even useless. Deprecating does not seem useful if we aren’t going to
remove. Changing the docstring, the docs or the output of the code is okay.
Stefan Krah stefan-use...@bytereef.org added the comment:
Thinking about it, declaring PyMODINIT_FUNC as void would be a huge
step backwards. Using PyMODINIT_FUNC is the correct way of doing things.
The current situation punishes developers who actually read the docs.
If a C module stops
Éric Araujo mer...@netwok.org added the comment:
I don’t think we can remove a method. Can you make a patch with your other
suggestion? Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Stefan Krah stefan-use...@bytereef.org added the comment:
This is the history of the issue:
In r16757 the current version of get_export_symbols() was added to
distutils. This function adds /EXPORT initfunc to the command line.
In 27697 PyMODINIT_FUNC was defined as __declspec(dllexport) void.
Éric Araujo mer...@netwok.org added the comment:
I can review a patch for this bug but not write it, lacking knowledge in C.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
Changes by Éric Araujo mer...@netwok.org:
--
versions: +3rd party
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
___
Python-bugs-list
New submission from Stefan Krah stefan-use...@bytereef.org:
On Windows, the initfunc of a C extension is exported twice, as
seen here:
test_distutils
xxmodule.c
xxmodule.obj : warning LNK4197: export 'initxx' specified multiple times; using
first specification
First export: pyport.h: #define
Stefan Krah stefan-use...@bytereef.org added the comment:
Tarek, I forgot to add you, sorry. I was thinking mainly about distutils,
not distutils2.
--
nosy: +tarek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
23 matches
Mail list logo
