Senthil Kumaran orsent...@gmail.com added the comment:
Fixed in r87329, r87330 and r87331. Thanks for the patch Wes, that was proper.
--
resolution: accepted - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Wes Chow wes.c...@gmail.com added the comment:
Here's a patch for 3.2 which fixes this problem I believe. There does exist a
test case that should have produced an error, except that the last path segment
in RFC3986_BASE is only one character long. Had it been more than one character
long,
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9721
___
___
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9721
___
___
Wes Chow wes.c...@gmail.com added the comment:
New patch (urlparse-9721-3.2.patch) against 3.2 which fixes the erroneous test.
--
Added file: http://bugs.python.org/file19706/urlparse-9721-3.2.patch
___
Python tracker rep...@bugs.python.org
Wes Chow wes.c...@gmail.com added the comment:
Patch against 2.7 (urlparse-9721-2.7.patch).
--
Added file: http://bugs.python.org/file19707/urlparse-9721-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9721
Senthil Kumaran orsent...@gmail.com added the comment:
Simply applying the patch would break the testsuite of urlparse ( test_RFC3986
case of urljoin for ';' starting joinurls). The expected behavior should be
trim off all receding chars until a '/' and then join the semi-colon starting
url.
Éric Araujo mer...@netwok.org added the comment:
The versions getting bug fixes are 2.7, 3.1 (stable versions) and 3.2 (active).
2.6 is in security mode now.
Can someone write a test (as a standalone script or a diff against
Lib/test/test_urlparse.py) and tell if 3.1 and 3.2 have the bug too?
Bastian Kleineidam cal...@users.sourceforge.net added the comment:
Update: the python2.5 behaviour is the expected and what I think the correct
output.
--
versions: -Python 2.5
___
Python tracker rep...@bugs.python.org
Michał Powaga michalpowag...@gmail.com added the comment:
The problem was be here:
path = path[:-1] # This is not needed and cuts last character
return urlunparse((scheme, netloc, path,
params, query, fragment))
I sent a patch.
PS. Sorry if I`m doing something wrong but it
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9721
___
___
Python-bugs-list
New submission from Bastian Kleineidam cal...@users.sourceforge.net:
The urljoin() implementation cuts off the last base URL
character if the URL to join starts with a semicolon.
Expected output is no cut off characters.
$ python2.6
Python 2.6.6 (r266:84292, Aug 29 2010, 12:36:23)
[GCC 4.4.5
12 matches
Mail list logo
