[issue7946] Convoy effect with I/O bound threads and New GIL

2010-05-14 Thread Nir Aides

Changes by Nir Aides n...@winpdb.org:


Removed file: http://bugs.python.org/file17195/bfs.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7946
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7946] Convoy effect with I/O bound threads and New GIL

2010-05-14 Thread Nir Aides

Nir Aides n...@winpdb.org added the comment:

Duck, here comes another update to bfs.patch.

This one with some cleanups which simplify the code and improve behavior (on 
Windows XP), shutdown code, comments, and experimental use of TSC for 
timestamps, which eliminates timestamp reading overhead.

TSC (http://en.wikipedia.org/wiki/Time_Stamp_Counter) is a fast way to get high 
precision timing read. On some systems this is what gettimeofday() uses under 
the hood while on other systems it will use HPET or another source which is 
slower, typically ~1usec, but can be higher (e.g. my core 2 duo laptop 
occasionally goes into a few hours of charging 3usec per HPET gettimeofday() 
call - god knows why)

This overhead is incurred twice for every GIL release/acquire pair and can be 
eliminated with:
1) Hack the scheduler not to call gettimeofday() when no other threads are 
waiting to run, or
2) Use TSC on platforms it is available (the Linux BFS scheduler uses TSC).

I took cycle.h pointed by the Wikipedia article on TSC for a spin and it works 
well on my boxes. It is BSD, (un)maintained? and includes implementation for a 
gazillion of platforms (I did not yet modify configure.in as it recommends). 

If it breaks on your system please ping with details.

Some benchmarks running (Florent's) writes.py on Core 2 Quad q9400 Ubuntu 64bit:

bfs.patch - 35K context switches per second, threads balanced, runtime is 3 
times that of running IO thread alone:

~/dev/python$ ~/build/python/bfs/python writes.py
t1 1.60293507576 1
t2 1.78533816338 1
t1 2.88939499855 2
t2 3.19518113136 2
t1 4.38062310219 3
t2 4.70725703239 3
t1 6.26874804497 4
t2 6.4078810215 4
t1 7.83273100853 5
t2 7.92976212502 5
t1 9.4341750145 6
t2 9.57891893387 6
t1 11.077393055 7
t2 11.164755106 7
t2 12.8495900631 8
t1 12.8979620934 8
t1 14.577999115 9
t2 14.5791089535 9
t1 15.9246580601 10
t2 16.1618289948 10
t1 17.365830183 11
t2 17.7345991135 11
t1 18.9782481194 12
t2 19.2790091038 12
t1 20.4994370937 13
t2 20.5710251331 13
21.0179870129


dabeaz_gil.patch - sometimes runs well but sometimes goes into high level of 
context switches (250K/s) and produces output such as this:

~/dev/python$ ~/build/python/dabeaz/python writes.py 
t1 0.742760896683 1
t1 7.50052189827 2
t2 8.63794493675 1
t1 10.1924870014 3
17.9419858456

gilinter2.patch - 300K context switches per second, bg threads starved:

~/dev/python$ ~/build/python/gilinter/python writes.py 
t2 6.1153190136 1
t2 11.7834780216 2
14.5995650291

--
Added file: http://bugs.python.org/file17330/bfs.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7946
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8709] mention explicitly Windows support for os.devnull

2010-05-14 Thread akira

New submission from akira 4kir4...@gmail.com:

Currently it is not obvious that os.devnull works on Windows.

--
assignee: d...@python
components: Documentation
files: doc-os-devnull-windows-r81160.diff
keywords: patch
messages: 105688
nosy: akira, d...@python
priority: normal
severity: normal
status: open
title: mention explicitly Windows support for os.devnull
type: feature request
Added file: http://bugs.python.org/file17331/doc-os-devnull-windows-r81160.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

 Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:

 Speaking of getting side-tracked, I didn't see an answer to a question I 
 asked earlier.  I'd like to get some feedback before I proceed with revising 
 the patch.

 For the find-last-set-bit (to replace log2) and count-set-bits operations, 
 would it be worthwhile to create a pybits.h and .c that defines 
 _Py_FindLastSetBit and _Py_CountSetBits? (with appropriate logic in the .h 
 and configure.in to use system/compiler versions if available)

How about putting them in pymath.c and pymath.h?   Then there's no
need for new files.  There's the possible issue that the two
bit-counting methods operate on different types, though.

 There are already two implementations of find-last-set-bit in Python:
 bits_in_digit() in Objects/longobject.c and hi0bits() in Python/dtoa.c, which 
 I could consolidate.

dtoa.c should be left alone, ideally:  it's currently almost
completely self-contained, and also very close to the original dtoa.c
from David Gay, which makes it easy to incorporate fixes from
upstream.  So it's just Objects/longobject.c that would share the
code.

 Alternately, I could just add static functions to mathmodule.c with the 
 simplest possible implementation (they're only called once per factorial, so 
 the performance impact is minimal).

That would work, too.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8704] cgitb sends a bogus HTTP header if the app crashes before finishing headers

2010-05-14 Thread Ray.Allen

Ray.Allen ysj@gmail.com added the comment:

Yes, I saw the !--: spam string in headers, but it seems that this string 
doesn't make problems. The displaying page is correct.


But after I apply the changes you mentioned:
-return '''!--: spam
+return '''\r\n\r\n!--: spam


I got text/plain output, and the response headers are like this:

DateFri, 14 May 2010 07:30:03 GMT
Server  Apache/2.2.15 (Unix)
Keep-Alive  timeout=5, max=100
Connection  Keep-Alive
Transfer-Encoding   chunked
Content-Typetext/plain



And the content is like this:

!--: spam
Content-Type: text/html

body bgcolor=#f0f0f8font color=#f0f0f8 size=-5 --
body bgcolor=#f0f0f8font color=#f0f0f8 size=-5 -- --

..



So the hole page is not displayed correctly!

Is there any problem with me?

--
nosy: +ysj.ray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8704
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

 I am attaching an iterative version in C patch.

Thanks for doing this comparison.

 The performance  appears to be identical to Daniel's with no small
 integer multiplication optimization.

Okay, let's stick with the recursive version, then.  It has the advantage that 
it uses less space (no need to store the entire list of odd terms).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2142] difflib.unified_diff(...) produces invalid patches

2010-05-14 Thread Ray.Allen

Ray.Allen ysj@gmail.com added the comment:

This is really a bug, but why it's not fixed during such a long time?

Since trentm's python_difflib_no_eol.patch patch failed against the current 
trunk, I modified it to work again, also a patch against py3k.

--
nosy: +ysj.ray
Added file: http://bugs.python.org/file17332/issue_2142_trunk.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2142] difflib.unified_diff(...) produces invalid patches

2010-05-14 Thread Ray.Allen

Changes by Ray.Allen ysj@gmail.com:


Added file: http://bugs.python.org/file17333/issue_2142_py3k.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2142] difflib.unified_diff(...) produces invalid patches

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

I think it's arguable whether this is a bug or not.  There's no official 
specification for the unified diff format that I can find anywhere;  the GNU 
description at

http://www.gnu.org/software/hello/manual/diff/Detailed-Unified.html#Detailed-Unified

doesn't mention this detail.  The '\ No newline at end of file' is actually 
unnecessary for these Python functions, since they operate on lists and produce 
a generator, so it would be needless complication.  And changing this might 
break existing Python code that manually parses the output of unified_diff or 
context_diff and doesn't know what to do with a leading '\' character.  (Does 
such Python code exist?  I don't know.)

I'd suggest adding a keyword argument to the unified_diff and context_diff  
functions to enable this feature, leaving it disabled by default.

--
nosy: +tim_one

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6419] Broken test_kqueue.py on OpenBSD

2010-05-14 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

The same patch was applied to the Python port by OpenBSD developer Damien 
Miller:

http://www.openbsd.org/cgi-bin/cvsweb/ports/lang/python/2.6/patches/patch-Lib_test_test_kqueue_py


Mark, would it be ok in this situation to apply the patch even though
personally I don't know if OpenBSD kqueue behaves like Darwin kqueue?

--
nosy: +mark.dickinson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6419
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8705] shutil.rmtree with empty filepath

2010-05-14 Thread Tarek Ziadé

Changes by Tarek Ziadé ziade.ta...@gmail.com:


--
assignee:  - tarek
priority: normal - low

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8705
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8705] shutil.rmtree with empty filepath

2010-05-14 Thread Tarek Ziadé

Tarek Ziadé ziade.ta...@gmail.com added the comment:

Dan,

Can I have the error you get ?

Thanks

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8705
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8640] subprocess: add envb argument to Popen constructor (Python3, POSIX only)

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

 Why wouldn't you give byte variables in env too?

The problem with the canonicalization to bytes is to choice of the preferred 
type. Eg. env={'PATH': 'a', b'PATH': b'b'}: should we use 'a', 'b' or raise an 
error?

subprocess does already convert environ keys and values to bytes on Unix (in 
subprocess._execute_child() if _posixsubprocess module is present, and in 
posix_execve()).

os.get_exec_path() should also support b'PATH' key.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8640
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8424] Test assumptions for test_itimer_virtual and test_itimer_prof

2010-05-14 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

Luckily, the OpenBSD failures are caused by issues in libpthread. This
means that some skips could be added (as for FreeBSD), but I'll open
a separate issue for that.


Thanks for the comments on the patch. I add two new patches that
incorporate the stderr/SkipTest suggestions.


Should I apply them and close this issue?

--
Added file: http://bugs.python.org/file17334/issue8424-release26-stderr.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8424
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8424] Test assumptions for test_itimer_virtual and test_itimer_prof

2010-05-14 Thread Stefan Krah

Changes by Stefan Krah stefan-use...@bytereef.org:


Added file: http://bugs.python.org/file17335/issue8424-trunk-skiptest.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8424
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8710] test_xpickle: compat tests: workaround for missing test_support

2010-05-14 Thread Stefan Krah

New submission from Stefan Krah stefan-use...@bytereef.org:

When the system python does not have the Lib/test directory, the
compat tests are failing.


==
ERROR: test_attribute_name_interning (test.test_xpickle.CPicklePython26Compat)
--
Traceback (most recent call last):
  File /home/stefan/svn/trunk/Lib/test/pickletester.py, line 959, in 
test_attribute_name_interning
s = self.dumps(x, proto)
  File /home/stefan/svn/trunk/Lib/test/test_xpickle.py, line 114, in dumps
return self.send_to_worker(self.python, arg, proto)
  File /home/stefan/svn/trunk/Lib/test/test_xpickle.py, line 110, in 
send_to_worker
raise RuntimeError(stderr)
RuntimeError: Traceback (most recent call last):
  File /home/stefan/svn/trunk/Lib/test/test_xpickle.py, line 17, in module
from test import test_support
ImportError: No module named test

--
components: Tests
messages: 105698
nosy: collinwinter, skrah
priority: normal
severity: normal
status: open
title: test_xpickle: compat tests: workaround for missing test_support
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8710
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8256] input() doesn't catch _PyUnicode_AsString() exception; io.StringIO().encoding is None

2010-05-14 Thread Amaury Forgeot d'Arc

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

since the prompt is written to stderr, why is sys.stdout.encoding used instead 
of sys.stderr.encoding?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8256
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8256] input() doesn't catch _PyUnicode_AsString() exception; io.StringIO().encoding is None

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

amaury since the prompt is written to stderr, why is sys.stdout.encoding
amaury used instead of sys.stderr.encoding?

input() calls PyOS_Readline() but PyOS_Readline() has multiple 
implementations:
 - PyOS_StdioReadline() if sys_stdin or sys_stdout is not a TTY
 - or PyOS_ReadlineFunctionPointer callback:
   - vms__StdioReadline() (VMS only)
   - PyOS_StdioReadline()
   - call_readline() when readline module is loaded

call_readline() calls rl_callback_handler_install() with the prompt which 
writes the prompt to *stdout* (try ./python 2/dev/null).

I don't think that it really matters that the prompt is written to stderr with 
stdout encoding, because both outputs always use the same encoding.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8256
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3771] test_httpservers intermittent failure, test_post and EINTR

2010-05-14 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

The EINTR issue should be fixed in trunk (issue1628205). Have you by
any chance run the test suite on trunk in the meantime?

--
nosy: +skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3771
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8709] mention explicitly Windows support for os.devnull

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

If there’s no note stating some object is only available on one platform, then 
it’s available for all. That said, for this case I agree with your patch.

--
nosy: +merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8710] test_xpickle: compat tests: workaround for missing test_support

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

I don’t understand your installation. Do you have some parts of the test 
infrastructure but not test_support? Why?

--
nosy: +merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8710
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1813] Codec lookup failing under turkish locale

2010-05-14 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +haypo
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1813
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8710] test_xpickle: compat tests: workaround for missing test_support

2010-05-14 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

The compat tests check that pickling in the newly compiled Python
version is compatible with pickling in installed Python versions.

The installed versions may or may not have a test directory. For
example, the 2.6 port in OpenBSD does not have the test directory.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8710
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread STINNER Victor

New submission from STINNER Victor victor.stin...@haypocalc.com:

Attached patch document PyUnicode_DecodeFSDefault() and 
PyUnicode_DecodeFSDefaultAndSize() in Doc/c-api/, and fix comment in 
Include/unicodeobject.c (remove reference to bytearray, and specify that 
surrogateescape is used).

The patch adds also titles to group unicode functions and methods by topic.

--
assignee: d...@python
components: Documentation, Unicode
files: unicode_doc.patch
keywords: patch
messages: 105706
nosy: d...@python, haypo
priority: normal
severity: normal
status: open
title: Document PyUnicode_DecodeFSDefault() and 
PyUnicode_DecodeFSDefaultAndSize()
versions: Python 3.1, Python 3.2
Added file: http://bugs.python.org/file17336/unicode_doc.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6610] Subprocess descriptor debacle

2010-05-14 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Would the test still be correct if it didn't close stderr? I feel closing 
stderr is very bad from a debuggability standpoint.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6610
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

The bulk of the patch seems good to me, with some minor remarks:
- You haven’t used title case consistently in all section titles.
- I’d just say “wchar_t Support” in a title, deleting “for platforms
which support it”.
- You could mark up “bytes” so that users get a link.
- The verb form of “fall back” is in two words, unless I’m lagging on
current technical English.
- You lack an article when saying “the surrogateescape error handler”.
- Not sure: Is it better to say “for encoding x, use y” or “to encode x,
use y”?

Sorry for not giving precise line numbers or a diff of a diff, that
wouldn’t be practical.

--
nosy: +merwok
title: Document PyUnicode_DecodeFSDefault() and 
PyUnicode_DecodeFSDefaultAndSize() - Document PyUnicode_DecodeFSDefault()  
and PyUnicode_DecodeFSDefaultAndSize()

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8712] Skip libpthread related test failures on OpenBSD

2010-05-14 Thread Stefan Krah

New submission from Stefan Krah stefan-use...@bytereef.org:

[Added OpenBSD Python port maintainers to the nosy list.]

I've identified a number of tests that all pass when Python is compiled
without threads, but fail otherwise. The failures are probably caused
by libpthread issues in OpenBSD, as described in this patch:


http://www.openbsd.org/cgi-bin/cvsweb/ports/lang/python/2.6/patches/patch-Lib_test_test_signal_py


Would you agree that it is reasonable to skip all these tests until
libpthread is fixed?

--
components: Tests
files: openbsd_libpthread_skips.patch
keywords: needs review, patch
messages: 105709
nosy: djmdjm, henry.precheur, skrah
priority: normal
severity: normal
stage: patch review
status: open
title: Skip libpthread related test failures on OpenBSD
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file17337/openbsd_libpthread_skips.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8712
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8424] Test assumptions for test_itimer_virtual and test_itimer_prof

2010-05-14 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

The patches look good, so yes, please apply them.  As for closing the 
issue...if the failures are no longer happening on the buildbots, then yes :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8424
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Daniel Stutzbach

Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:


Removed file: http://bugs.python.org/file17300/factorial.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8712] Skip libpthread related test failures on OpenBSD

2010-05-14 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

This looks reasonable. Perhaps you should add a reference to the relevant 
OpenBSD bug number(s) or URL(s), if any.

--
nosy: +exarkun, mark.dickinson, pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8712
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 Is it better to say “for encoding x, use y” or “to encode x,
 use y”?

The latter, IMO. Encoding is also a noun.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6419] Broken test_kqueue.py on OpenBSD

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Yes, please do apply the patch!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6419
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

In this case, it was a verb (a gerund form).

--
title: Document PyUnicode_DecodeFSDefault() and 
PyUnicode_DecodeFSDefaultAndSize() - Document  PyUnicode_DecodeFSDefault() 
and PyUnicode_DecodeFSDefaultAndSize()

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Daniel Stutzbach

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:

Attached is an updated patch.

In addition to the code cleanup and bug fix suggestions, it includes a new 
base-case for factorial_partial_product.  Instead of:

if (n = m)
return n
if (n + 2 == m)
return n*m
otherwise divide-and-conquer

It now does:

if (the_answer_will_fit_in_unsigned_long)
compute_product_via_tight_loop()
return answer
otherwise divide-and-conquer

It's around half the code of the previous factorial_partial_product(), if you 
don't count comments.  It's also much faster for small n and somewhat faster 
for moderate n.

original patch:
13: 0.848 usec
50: 2.4 usec
100: 4.68 usec
1000: 121 usec
1: 7.68 msec
10: 434 msec

new patch:
13: 0.5 usec
50: 1.2 usec
100: 2.28 usec
1000: 100 usec
1: 7.32 msec
10: 447 msec

I also experimented with adding Alexander's precompute logic to my 
factorial_loop.  However, it did not result in a significant speedup, since all 
of the cases that could leverage the precompute table now execute in the new 
fast base case.

The new patch includes the new unit tests I uploaded earlier.

--
Added file: http://bugs.python.org/file17338/factorial.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8705] shutil.rmtree with empty filepath

2010-05-14 Thread Dan Koch

Dan Koch koc...@ornl.gov added the comment:

Here's the session printout. Desktop files under Vista still get deleted 
despite the exception. Does not occur on Fedora 12 or Mac OS X. I can code 
around it by testing for a blank filepath, but it was a surprise.

C:\Users\ko5python
Python 2.6.4 (r264:75708, Oct 26 2009, 08:23:19) [MSC v.1500 32 bit (Intel)] on 
win32
Type help, copyright, credits or license for more information.
 import os, shutil, user
 desktop_dir = os.path.join(user.home, 'Desktop')
 os.chdir(desktop_dir)
 os.getcwd()
'C:\\Users\\ko5\\Desktop'
 shutil.rmtree('')
Traceback (most recent call last):
  File stdin, line 1, in module
  File C:\Python26\lib\shutil.py, line 225, in rmtree
onerror(os.rmdir, path, sys.exc_info())
  File C:\Python26\lib\shutil.py, line 223, in rmtree
os.rmdir(path)
WindowsError: [Error 3] The system cannot find the path specified: ''


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8705
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Thanks for your remarks: updated patch.

--
Added file: http://bugs.python.org/file17339/unicode_doc-2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8711] Document PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefaultAndSize()

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Commited: r81168 (py3k), r81169 (3.1).

I also added the paragraph titles to Python2: r81166 (trunk) and r81167 (2.6).

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8713] multiprocessing needs option to eschew fork() under Linux

2010-05-14 Thread Brandon Craig Rhodes

New submission from Brandon Craig Rhodes bran...@rhodesmill.org:

The multiprocessing module uses a bare fork() to create child processes under 
Linux, so the children get a copy of the entire state of the parent process.  
But under Windows, child processes are freshly spun-up Python interpreters with 
none of the data structures or open connections of the parent process 
available.  This means that code that tests fine under Linux, because it is 
depending on residual parent state in a way that the programmer has not 
noticed, can fail spectacularly under Windows.

Therefore, the multiprocessing module should offer an option under Linux that 
ignores the advantage of being able to do a bare fork() and instead spins up a 
new interpreter instance just like Windows does.  Some developers will just use 
this for testing under Linux, so their test results are valid for Windows too; 
and some developers might even use this in production, preferring to give up a 
bit of efficiency under Linux in return for an application that will show the 
same behavior on both platforms.  Either way, an option that lets the developer 
subvert the simple sys.platform != 'win32' check in forking.py would go a 
long way towards helping us write platform-agnostic Python programs.

--
components: Library (Lib)
messages: 105719
nosy: brandon-rhodes
priority: normal
severity: normal
status: open
title: multiprocessing needs option to eschew fork() under Linux
type: feature request
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8714] Delayed signals in the REPL on OpenBSD (possibly libpthread related)

2010-05-14 Thread Stefan Krah

New submission from Stefan Krah stefan-use...@bytereef.org:

On OpenBSD, SIGINT handling in the REPL is delayed until further input:

Python 2.7b2+ (trunk:81162, May 14 2010, 14:47:52) 
[GCC 3.3.5 (propolice)] on openbsd4
Type help, copyright, credits or license for more information.
  = here Ctrl-C is pressed but nothing appears
Only after hitting Return a traceback appears:
Traceback (most recent call last):
  File stdin, line 1, in module
KeyboardInterrupt


This behavior was introduced (exposed by?) r68460.


When Python is compiled without threads, the behavior is normal.

--
components: Interpreter Core
messages: 105720
nosy: djmdjm, henry.precheur, skrah
priority: normal
severity: normal
status: open
title: Delayed signals in the REPL on OpenBSD (possibly libpthread related)
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8714
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8715] Create PyUnicode_EncodeFSDefault() function

2010-05-14 Thread STINNER Victor

New submission from STINNER Victor victor.stin...@haypocalc.com:

PyUnicode_EncodeFSDefault() is the opposite of 
PyUnicode_DecodeFSDefault(AndSize)() and is similar to the new function 
os.fsencode(). As you can see in the patch, it simplifies many functions.

/* Encodes a Unicode object to Py_FileSystemDefaultEncoding with the
   surrogateescape error handler and returns a bytes object.

   If Py_FileSystemDefaultEncoding is not set, fall back to UTF-8.
*/

PyAPI_FUNC(PyObject*) PyUnicode_EncodeFSDefault(
PyObject *unicode
);

The function unify the behaviour when Py_FileSystemDefaultEncoding is NULL: use 
UTF-8 whereas import uses ASCII. Other functions did already fall back to 
UTF-8: PyUnicode_AsEncodedString() uses PyUnicode_GetDefaultEncoding() 
(hardcoded to utf8 in Python3) if encoding is NULL

The patch does also fix tkinter module initializer (use surrogateescape error 
handler, instead of strict).

The patch was first attached to issue #8611.

--
components: Interpreter Core, Unicode
files: pyunicode_encodefsdefault-2.patch
keywords: patch
messages: 105721
nosy: Arfrever, benjamin.peterson, ezio.melotti, gregory.p.smith, haypo, 
lemburg, loewis, pitrou
priority: normal
severity: normal
status: open
title: Create PyUnicode_EncodeFSDefault() function
versions: Python 3.2
Added file: http://bugs.python.org/file17340/pyunicode_encodefsdefault-2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8715
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8715] Create PyUnicode_EncodeFSDefault() function

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Ooops, I attached the wrong version of the patch. Version 3 changes the 
documentation (Encodes = Encode).

--
Added file: http://bugs.python.org/file17341/pyunicode_encodefsdefault-3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8715
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8715] Create PyUnicode_EncodeFSDefault() function

2010-05-14 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@haypocalc.com:


Removed file: http://bugs.python.org/file17340/pyunicode_encodefsdefault-2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8715
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8611] Python3 doesn't support locale different than utf8 and an non-ASCII path (POSIX)

2010-05-14 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@haypocalc.com:


Removed file: http://bugs.python.org/file17251/pyunicode_encodefsdefault.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8611] Python3 doesn't support locale different than utf8 and an non-ASCII path (POSIX)

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

I opened a separated issue for the new function PyUnicode_EncodeFSDefault(): 
#8715.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8713] multiprocessing needs option to eschew fork() under Linux

2010-05-14 Thread R. David Murray

Changes by R. David Murray rdmur...@bitdance.com:


--
nosy: +jnoller

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8713] multiprocessing needs option to eschew fork() under Linux

2010-05-14 Thread Jesse Noller

Jesse Noller jnol...@gmail.com added the comment:

This is on my wish list; but I have not had time to do it. Patch welcome.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Python3 compilation fails on Windows:

  File ...\3.x.bolen-windows\build\lib\subprocess.py, line 911, in Popen
_WaitForSingleObject=WaitForSingleObject,
NameError: name 'WaitForSingleObject' is not defined

http://www.python.org/dev/buildbot/3.x.stable/builders/x86%20XP-4%203.x/builds/2121/steps/compile/logs/stdio

--
resolution: fixed - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5099
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Alexander Belopolsky

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


Removed file: http://bugs.python.org/file17310/factorial.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Alexander Belopolsky

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


Removed file: http://bugs.python.org/file17312/factorial3.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8663] Failed compile in a non-ASCII path

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

New patch: use sys.stdout.encoding instead of ASCII. (If stdout is not a TTY, 
sys.stdout.encoding is ASCII.)

--
Added file: http://bugs.python.org/file17342/distutils_spawn_log.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8663
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8663] Failed compile in a non-ASCII path

2010-05-14 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@haypocalc.com:


Removed file: http://bugs.python.org/file17268/distutils_spawn_toascii.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8663
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8712] Skip libpthread related test failures on OpenBSD

2010-05-14 Thread Jean-Paul Calderone

Jean-Paul Calderone exar...@twistedmatrix.com added the comment:

In addition to skipping the tests, would it also make sense to document these 
known limitations of Python threading on OpenBSD somewhere that end users might 
see it?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8712
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6419] Broken test_kqueue.py on OpenBSD

2010-05-14 Thread Stefan Krah

Stefan Krah stefan-use...@bytereef.org added the comment:

Mark, thanks. - The patch is good on OpenBSD-4.5-i386-Celeron,
but I get additional failures on OpenBSD-4.7-beta-amd64-QEMU.

This could be the result of running a beta under qemu.

Henry, could you confirm if the patch works on amd64/OpenBSD-4.7-stable?



==
FAIL: test_create_event (test.test_kqueue.TestKQueue)
--
Traceback (most recent call last):
  File /home/stefan/svn/py3k/Lib/test/test_kqueue.py, line 29, in 
test_create_event
self.assertEqual(ev.ident, fd)
AssertionError: 562945658454018 != 2

==
FAIL: test_queue_event (test.test_kqueue.TestKQueue)
--
Traceback (most recent call last):
  File /home/stefan/svn/py3k/Lib/test/test_kqueue.py, line 130, in 
test_queue_event
(server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(1688841270329350, -2, 5), (1... != [(6, -2, 0), 
(7, -2, 0)]

First differing element 0:
(1688841270329350, -2, 5)
(6, -2, 0)

- [(1688841270329350, -2, 5), (1688841270329351, -2, 5)]
+ [(6, -2, 0), (7, -2, 0)]

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6419
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Alexander Belopolsky

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

I agree, recursive version of partial_product is much simpler to follow.  While 
allocation of all numbers can be avoided in iterative version, doing so would 
further complicate code with little benefit.

I still believe, however that an iterative version can benefit from redefining 
partial_product to be product(2*i+1 for i in range(start, stop)).

Divide and conquer algorithm for that is simply

def partial_product(start, stop):
length = stop - start
.. handle length = 1 and 2 ..
middle = start + (length  1)
return partial_product(start, middle) * partial_product(middle, stop)

I would also reconsider the decision of using iterative outer loop.  Recursive 
outer loop matching redefined partial_product() can be written as

def loop(n):
p = r = 1
if n  2:
p, r = loop(n  1)
p *= partial_product((n  2) + (n  1  1),
 (n  1) + (n  1))
r *= p
return p, r

which I believe is not harder to follow than the iterative alternative and does 
not require bit_length calculation.

I am replacing my python implementation, factorial.py, with the one that uses 
algorithms outlined above.

If there is any interest, I can convert it to C.

--
Added file: http://bugs.python.org/file17343/factorial.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8713] multiprocessing needs option to eschew fork() under Linux

2010-05-14 Thread Brandon Craig Rhodes

Brandon Craig Rhodes bran...@rhodesmill.org added the comment:

Jesse, it's great to learn it's on your wish list too!

Should I design the patch so that (a) there is some global in the module that 
needs tweaking to choose the child creation technique, or (b) that an argument 
to the Process() constructor forces a full interpreter exec to make all 
platforms match, or (c) that a process object once created has an attribute 
(like .daemon) that you set before starting it off?  Or (d) should there be a 
subclass of Process that, if specifically used, has the fork/exec behavior 
instead of just doing the fork?

My vote would probably be for (b), but you have a much better feel for the 
library and its style than I do.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Alexander Belopolsky

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

 I still believe, however that an iterative version can benefit ..

s/iterative/recursive/

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com




[issue8649] Py_UNICODE_* functions are undocumented

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

If, for this and your previous two issues, you could add a suggestion as to 
precisely where you would make an addition and what minimally adequate text you 
would add (even unformatted ascii text in a message) that is consistent with 
surrounding style, action would likely happen sooner.

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8649
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8716] test_tk fails on OS X if run from buildbot slave daemon -- crashes Python

2010-05-14 Thread Bill Janssen

New submission from Bill Janssen bill.jans...@gmail.com:

test_tk fails on OS X if test is run from a daemon process without the 
privilege to access the window server, say a buildbot slave without anyone 
logged in to the console.  The Tk support needs to check whether it has access 
rights to the window server before trying to access it.

Workaround is to log buildbot into the console of the OS X machine (which 
usually but not always works), or to run tests manually.

--
components: Tests, Tkinter
messages: 105733
nosy: janssen
priority: normal
severity: normal
stage: needs patch
status: open
title: test_tk fails on OS X if run from buildbot slave daemon -- crashes Python
type: crash
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8716
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8713] multiprocessing needs option to eschew fork() under Linux

2010-05-14 Thread Jesse Noller

Jesse Noller jnol...@gmail.com added the comment:

I pretty much agree with (b) an argument - your gut instinct is correct - 
there's a long standing thread in python-dev which pretty much solidified my 
thinking about whether or not we need this (we do). 

Any patch has to be backwards compatible by the way, it can not alter the 
current default behavior, also, it has to target python3 as 2.7 is nearing 
final, and this is a behavioral change.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8716] test_tk fails on OS X if run from buildbot slave daemon -- crashes Python

2010-05-14 Thread Bill Janssen

Bill Janssen bill.jans...@gmail.com added the comment:

[More info from Ronald Oussoren]

This is a bug in Tk: 

 root = Tkinter.Tk()
Thu May 13 20:45:13 Rivendell.local python[84887] Error: kCGErrorFailure: Set 
a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged.
_RegisterApplication(), FAILED TO establish the default connection to the 
WindowServer, _CGSDefaultConnection() is NULL.
 2010-05-13 20:45:16.751 Python[84887:d07] An uncaught exception was raised
2010-05-13 20:45:16.762 Python[84887:d07] Error (1002) creating CGSWindow
2010-05-13 20:45:16.955 Python[84887:d07] *** Terminating app due to uncaught 
exception 'NSInternalInconsistencyException', reason: 'Error (1002) creating 
CGSWindow'
*** Call stack at first throw:
(
0   CoreFoundation  0x7fff85e31d24 
__exceptionPreprocess + 180
1   libobjc.A.dylib 0x7fff86f3 
objc_exception_throw + 45
2   CoreFoundation  0x7fff85e31b47 
+[NSException raise:format:arguments:] + 103
3   CoreFoundation  0x7fff85e31ad4 
+[NSException raise:format:] + 148
4   AppKit  0x7fff84614aba 
_NSCreateWindowWithOpaqueShape2 + 473
5   AppKit  0x7fff845a9055 -[NSWindow 
_commonAwake] + 1214
6   AppKit  0x7fff845c6d3d -[NSWindow 
_makeKeyRegardlessOfVisibility] + 96
7   AppKit  0x7fff845c6cb2 -[NSWindow 
makeKeyAndOrderFront:] + 24
8   Tk  0x00010075b86c XMapWindow + 
155
9   Tk  0x0001006ca6d0 Tk_MapWindow 
+ 89
10  Tk  0x0001006d35e6 
TkToplevelWindowForCommand + 2658
11  Tcl 0x0001006300d3 
TclServiceIdle + 76
12  Tcl 0x0001006162ce 
Tcl_DoOneEvent + 329
13  _tkinter.so 0x000100595683 
Tkapp_CallDeallocArgs + 277
14  readline.so 0x0001001f1f9a initreadline 
+ 1280
15  Python  0x000176a1 
PyOS_Readline + 239
16  Python  0x00018a57 
PyTokenizer_FromString + 1322
17  Python  0x000190a0 
PyTokenizer_Get + 154
18  Python  0x00015698 
PyParser_AddToken + 1018
19  Python  0x0001000a2320 
PyParser_ASTFromFile + 146
20  Python  0x0001000a443f 
PyRun_InteractiveOneFlags + 345
21  Python  0x0001000a4615 
PyRun_InteractiveLoopFlags + 206
22  Python  0x0001000a4685 
PyRun_AnyFileExFlags + 76
23  Python  0x0001000b0286 Py_Main + 
2718
24  Python  0x00010e6c start + 52
25  ??? 0x0001 0x0 + 1
)
terminate called after throwing an instance of 'NSException'
Abort trap


This is running /usr/bin/python in a session as a user that doesn't have access 
to the GUI.  The text above says that there is an uncaught ObjC exception, 
caused by the lack of a connection to the window server. Tk should have 
converted that to its own style of errors but didn't.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8716
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8717] Subprocess.py broken in trunk

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

The regression was introduced by r81154: issue #5099.

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8717
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8717] Subprocess.py broken in trunk

2010-05-14 Thread Pascal Chambon

New submission from Pascal Chambon chambon.pas...@gmail.com:

There seems to have been some broken commit on subprocess.py in trunk - the 
moduel can't be imported due to unexisting argument defaults.

Here is a very quick patch, but more inquiry migh tbe necessary to find out 
what happened.

--
files: broken_subprocess.patch
keywords: patch
messages: 105736
nosy: pakal
priority: normal
severity: normal
status: open
title: Subprocess.py broken in trunk
versions: Python 2.7
Added file: http://bugs.python.org/file17344/broken_subprocess.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8717
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

pakal wrote a patch fixing Windows regression: see issue #8717.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5099
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8677] Modules needing PY_SSIZE_T_CLEAN

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Mark just fixed audioop in #8675

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8677
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8716] test_tk fails on OS X if run from buildbot slave daemon -- crashes Python

2010-05-14 Thread Bill Janssen

Bill Janssen bill.jans...@gmail.com added the comment:

It's fairly easy to create a restricted process tree for testing.  ssh into a 
Mac which has no one logged into the console, from another machine, and use 
that connection to launch an xterm or Xemacs window to the other machine.  Then 
log out of the ssh session.  The session running in the xterm will now have no 
access privileges to the window server, and can be used for testing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8716
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8677] Modules needing PY_SSIZE_T_CLEAN

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

And the curses module was made PY_SSIZE_T_CLEAN in r81085 (a very simple 
change).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8677
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8686] This isn't defined beyond that phrase is not friendly to non-native English speakers.

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

I agree with Tim. Drop the zero-info glosses. For real_quick_ratio(),
Return an upper bound on ratio() even more quickly.
should be sufficient (assuming that it *is* always quicker.

Just curious, The descriptions say ratio() = quick_ratio() and ratio() = 
very_quick_ratio. is it also guaranteed that quick_ratio() = 
real_quick_ratio()? Or might one 'luck out' with a better answer from the 
faster method? (I can imagine either being true.)

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8686
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8686] This isn't defined beyond that phrase is not friendly to non-native English speakers.

2010-05-14 Thread Tim Peters

Tim Peters tim.pet...@gmail.com added the comment:

Terry asks:

 is it also guaranteed that quick_ratio() = real_quick_ratio()

Nope!  The docs don't say that, so it's not guaranteed.

It's not the _intent_ of the code that it be true, either.  The only point to 
quick_ratio() and real_quick_ratio() is speed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8686
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8689] sqlite3 parameter substitution breaks with multiple parameters

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

You appear to be saying that the same code gives different results on 2.6.4 and 
2.6.5. Correct? If so, did the version of sqlite change?

In any case, 3.1.2 on WinXP consistently gives (2,)
 sqlite3.version
'2.4.1'

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8689] sqlite3 parameter substitution breaks with multiple parameters

2010-05-14 Thread Simon Jagoe

Simon Jagoe simon.ja...@pragmagility.com added the comment:

I will try to test this with the different combinations of python and sqlite 
versions.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8652] Minor improvements to the Handling Exceptions part of the tutorial

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

The older exception catching syntax should not be promoted but could be 
mentioned, I agree. Adding a paragraph explaining why it was changed would do 
the trick.

Regarding the non-obviousness of which Python version the docs apply to, it is 
indeed mentioned on the front page of the docs, and repeated in the top-left 
corner of each page. You could propose making it bigger. Another way of doing 
this would be to have the page redirect to a URI that includes the version. 
That way, there would be another place to look for the version, and it would 
also make it easier to find out how to find the doc for other versions.

Last, exception unpacking being deprecated (because it’s horrible) and causing 
pain to newcomers seems a good reason to shot it down. Perhaps we should leave 
a short note about it, for people that get strange errors when using it 
inadvertently (or not getting an error where they thought they would).

I suggest you wait some more days for feedback from people with more experience 
with the docs. Sorry if my English was a bit convoluted :)

--
nosy: +merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8694] python3 FAQ mentions unicode()

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Yes, the faq entry has example code like
 value = unicode(value, utf-8)
This whole section now applies when 'value' is a bytes or bytearray object and 
one calls str(value).

For portability, one should in 2.6/7 use unicode strings as much as possible 
and the bytes and unicode functions but not the str function. Then 2to3.py will 
change 'unicode' to 'str'. This should be a separate FAQ entry (if not 
already), for both 2.x and 3.x, with more complete advice from MLV (from whom I 
am parroting the above).

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8694
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8668] add a 'develop' command

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

I have started to draft a similar proposal¹ but it seems that the wiki is not a 
communication medium as good as the bug tracker or the mailing lists (probably 
because of technical issues such as the lack of watchlist and e-mail 
notifications as much as because of Python culture). The discussion can happen 
here or on the mailing list unless Tarek firmly disagrees with the idea.

¹ http://wiki.python.org/moin/Distutils/Proposals/DevelopmentDistributions

--
nosy: +merwok
versions: +Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8668
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8679] write a distutils to distutils2 converter

2010-05-14 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +merwok
versions: +Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8679
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8680] Add a sandbox in Distutils2

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

What kind of sandbox should that be? Best-effort, meaning it replaces some 
functions to provide the dry-run feature, or an iron-clad sandbox that blocks 
malicious code from breaking out?

--
nosy: +merwok
versions: +Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8680
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8707] Duplicated document in telnetlib.

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Which is to say, the entire second paragraph beginning with 'number' should be 
deleted.  The same is true for 2.6, where it is also section 20.14, 3.1 
(20.17), and 3.2 (19.17). Good catch. Thanks for reporting.

--
keywords: +easy
nosy: +tjreedy
versions: +Python 2.6, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8707
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8689] sqlite3 parameter substitution breaks with multiple parameters

2010-05-14 Thread angri

angri gene...@angri.ru added the comment:

This thread contains some observations of versions affected: 
http://groups.google.com/group/python-sqlite/browse_thread/thread/a53a5e5282e29318

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Daniel Stutzbach

Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:


Removed file: http://bugs.python.org/file17338/factorial.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8709] mention explicitly Windows support for os.devnull

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Given the mention of the posix example, I agree. The issue applies to 2.6 and 
3.2 (that I checked) and so I assume to 2.7 and 3.1 also.

There is no doc string for devnull, which I presume should be in ntpath.

 help(os.devnull)
no Python documentation found for 'nul'

If this is a singular omission (as opposed to a general lack in that module), 
you might expand the patch to remedy that also.

--
nosy: +tjreedy
stage:  - commit review
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8649] Py_UNICODE_* functions are undocumented

2010-05-14 Thread Terry J. Reedy

Changes by Terry J. Reedy tjre...@udel.edu:


--
versions: +Python 2.6, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8649
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8709] mention explicitly Windows support for os.devnull

2010-05-14 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

os.devnull is a string, so “pydoc os.devnull” will tell you about
strings, and “help(os.devnull)” will be evaluated to
“help('/dev/null')” which won’t match any topic. Same thing with os.sep
and other module data; the doc is in the module’s docstring.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Daniel Stutzbach

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:

I made a few minor updates to the patch.

It redefines partial_product to product(range(n, m, 2)), which saved me a few 
operations and is more Pythonic than what I had before. :-)

(Not quite what Alexander was after, but it's a step in the right direction.  
His proposed defining of partial_product would have complicated my new base 
case.)

--
Added file: http://bugs.python.org/file17345/factorial.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8677] Modules needing PY_SSIZE_T_CLEAN

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Is there any reason why you reported zlibmodule.c separately in #8650 (other 
than maybe finding that first), and for 4 versions there versus 1 here? Should 
this supersede that?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8677
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

The patch looks good.  Just one issue: I think the overflow check for 
num_operands * last_bit is bogus.  It's possible for the product to overflow 
and still end up being less than num_operands.  How about:

if (num_operands = BITS_IN_LONG  num_operands * last_m_bit = BITS_IN_LONG) 
...

instead?  If num_operands = BITS_IN_LONG then there's no danger of overflow in 
the multiplication, and if num_operands  BITS_IN_LONG then the second test 
will certainly fail.

Apart from that, and some very minor style issues (e.g., please put the body of 
an if statement on the following line;  I don't think this is codified in PEP7, 
but it seems to be the prevailing style in the Python codebase) I think the 
patch is good to go.

[Alexander]
... benefit from redefining partial_product to be product(2*i+1 for i in 
range(start, stop))

You mean rewriting to use half-open intervals [start, stop) rather than closed 
intervals?  In which case I agree it would look slightly cleaner that way, but 
I don't have particularly strong feelings on the issue.  I'll leave it up to 
Daniel whether he wants to change this or not.


I would also reconsider the decision of using iterative outer loop.

I actually prefer the iterative version, perhaps out of a Python-bred aversion 
to recursion (in languages where the frames end up on the stack, anyway).  The 
bit_length calculation doesn't seem like a terrible price to pay to me.  Again, 
I leave this up to Daniel.


Marking this as accepted:  Daniel, if you like I can apply the overflow check 
change suggested above and the minor style fixes and apply this;  or if you 
want to go another round and produce a third patch, that's fine too.  Let me 
know.

(N.B.  If you do produce another patch, please name it something different and 
don't remove the earlier version---removing the earlier patch versions makes 
life harder for anyone trying to follow this issue.)

--
resolution:  - accepted

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Daniel, sorry:  I spent so long writing that last message that I didn't read 
your update until now.

The new patch looks fine;  same caveat about the overflow check as before.
Let me know when you want me to apply this.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8689] sqlite3 parameter substitution breaks with multiple parameters

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

The next question is whether there is any bug in the Python interface module or 
whether c.execute(s,t) is properly passing s and t to sqlite3 for processing 
and converting the return to a Python tuple. If the latter, then this should be 
closed as invalid (because it is a 3rd party problem).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

One other note:  I find the bit numbering in find_last_set_bit peculiar:  isn't 
the least significant bit usually bit 0?  (Well, okay some people number the 
msb 0, but that's just weird. :)  I know the ffs and fls functions also start 
their bit numbering at one, but this seems very unconventional to me.

Perhaps rename find_last_set_bit to bit_length?  i.e., it's the *size* of the 
small bitfield that can contain the given value, rather than the index of the 
highest bit in that bitfield.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

 it's the *size* of the small bitfield

*smallest

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2142] difflib.unified_diff(...) produces invalid patches

2010-05-14 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Marking as a feature request:  I think this is somewhere on the line between 
bugfix and new feature, but either way 2.7 is too close to release to start 
messing with something that isn't really all that broken.

For 2.7 (and 2.6, 3.1), there's also the option of updating the documentation 
to point out this issue.  It would also be worth updating the 
command-line-interface example in the docs to do this post-processing (i.e., 
for each line that doesn't end in a newline, add '\n\ No newline at end of 
file') before calling writelines.

--
type: behavior - feature request
versions:  -Python 2.6, Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8689] sqlite3 parameter substitution breaks with multiple parameters

2010-05-14 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Given that this is a real, and disconcerting problem, and not a failure to read 
the doc, no apology needed. At least one solution is recorded here for anyone 
else hitting the same problem.

If anyone thinks there should be a change to the sqlite3 module, they can 
reopen this.

--
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8663] Failed compile in a non-ASCII path

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Conditions to reproduce the bug:
 - non ASCII directory
 - don't use make -j N (no MAKEFLAGS environment variable)
 - write make output into a pipe, eg. make 21|cat

My 2 last patches are not enough: there are other functions writing non-ASCII 
strings to log whereas log encoding is ASCII. The right fix is to use the 
backslashreplace error handler for the log. Two solutions:
 a) replace sys.stdout by a new file using backslashreplace: I tried this 
solution for regrtest.py: #8533. My patch for regrtest.py doesn't work on 
Windows because of a newline issue
 b) emulate backslashreplace only in distutils log

I prefer (a) because it can be implemented in setup.py without touching 
distutils (tarek told me that distutils shouldn't be patched too much).

distutils_log_backslashreplace.patch implements (b).

--
Added file: 
http://bugs.python.org/file17346/distutils_log_backslashreplace.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8663
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8663] Failed compile in a non-ASCII path

2010-05-14 Thread Tarek Ziadé

Tarek Ziadé ziade.ta...@gmail.com added the comment:

I'll look at that asap. Although, all these patchs should have some tests 
demonstrating the bugs

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8663
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8663] Failed compile in a non-ASCII path

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

setup_stdout_backslashreplace.patch implements point (a).

I don't know which solution is better. This issue is not specific to compiling 
CPython, other programs may fail in non-ASCII paths and so solution (b) is 
maybe better.

--
Added file: http://bugs.python.org/file17347/setup_stdout_backslashreplace.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8663
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8677] Modules needing PY_SSIZE_T_CLEAN

2010-05-14 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 Is there any reason why you reported zlibmodule.c separately in #8650
 (other than maybe finding that first),

Because zlibmodule.c has more 64-bitness issues than just PY_SSIZE_T_CLEAN (see 
bug description).

 Should this supersede that?

No.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8677
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8718] subprocess: NameError: name 'WaitForSingleObject' is not def

2010-05-14 Thread Sridhar Ratnakumar

New submission from Sridhar Ratnakumar sridh...@activestate.com:

This was a regression due to a commit made less than 2 days ago.

make: [build_pywin32] running 'F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun
\python\PCbuild\amd64\python.exe setup.py build' in 'build\pyhg_trunk-win64-x64-
hgtip27-rrun\pywin32'
Traceback (most recent call last):
  File setup.py, line 83, in module
from distutils.command.build_ext import build_ext
  File F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun\python\lib\distutils\c
ommand\build_ext.py, line 23, in module
from distutils.msvccompiler import get_build_version
  File F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun\python\lib\distutils\m
svccompiler.py, line 657, in module
from distutils.msvc9compiler import MSVCCompiler
  File F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun\python\lib\distutils\m
svc9compiler.py, line 18, in module
import subprocess
  File F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun\python\lib\subprocess.
py, line 611, in module
class Popen(object):
  File F:\as\apy\build\pyhg_trunk-win64-x64-hgtip27-rrun\python\lib\subprocess.
py, line 911, in Popen
_WaitForSingleObject=WaitForSingleObject,
NameError: name 'WaitForSingleObject' is not defined

--
components: Library (Lib)
messages: 105768
nosy: srid
priority: normal
severity: normal
status: open
title: subprocess: NameError: name 'WaitForSingleObject' is not def
type: crash
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8718
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8718] subprocess: NameError: name 'WaitForSingleObject' is not def

2010-05-14 Thread Sridhar Ratnakumar

Sridhar Ratnakumar sridh...@activestate.com added the comment:

+brett

http://svn.python.org/view/python/trunk/Lib/subprocess.py?r1=80496r2=81154

--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8718
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8692] Use divide-and-conquer for faster factorials

2010-05-14 Thread Daniel Stutzbach

Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:

On Fri, May 14, 2010 at 3:25 PM, Mark Dickinson rep...@bugs.python.org wrote:
 The patch looks good.  Just one issue: I think the overflow check for 
 num_operands * last_bit is bogus.  It's possible for the product to overflow 
 and still end up being less than num_operands.  How about:

You're right; I'm not sure what I was thinking. (actually, I'm pretty
sure I was thinking about addition ;) )

 if (num_operands = BITS_IN_LONG  num_operands * last_m_bit = 
 BITS_IN_LONG) ...

 instead?  If num_operands = BITS_IN_LONG then there's no danger of overflow 
 in the multiplication, and if num_operands  BITS_IN_LONG then the second 
 test will certainly fail.

Yes, that looks good.

 Marking this as accepted:  Daniel, if you like I can apply the overflow check 
 change suggested above and the minor style fixes and apply this;  or if you 
 want to go another round and produce a third patch, that's fine too.  Let me 
 know.

That would be great. :)

With regards to find_last_set_bit, I understand where you're coming
from, but I'm following the convention of ffs/fls and also
bits_in_digit() from longobject.c.  I'd like to keep them
interchangeable, in case they're consolidated at some point in the
future.  If you want to rename the function, that's fine with me.

FWIW, I think the MSB=0th people are all electrical engineers.  If
you're serializing down to bits and the MSB is the first (0th) bit off
the wire, it makes sense in that context.

 (N.B.  If you do produce another patch, please name it something different 
 and don't remove the earlier version---removing the earlier patch versions 
 makes life harder for anyone trying to follow this issue.)

Good to know.  I'll keep that in mind going forward.

Thanks to both of you for the rigorous review.  This was a fun patch
to work on. :-)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Fix _internal_poll() on Windows: r81179 (trunk), r81181 (2.6), r81181 (3.x), 
r81182 (3.1).

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5099
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8717] Subprocess.py broken in trunk

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Thank you for your patch: I closed #5099 regression.

--
resolution:  - duplicate
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8717
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8718] subprocess: NameError: name 'WaitForSingleObject' is not def

2010-05-14 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Duplicate of #5099 (and #8717). It should be fixed now.

--
nosy: +haypo
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8718
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >