Brett Cannon added the comment:
The import path definition is a little misleading as sys.path is only inferred
when 'path' has None passed in. Otherwise 'path' is what __path__ in a package
is set to, so technically sys.path never even comes into play except by choice
from PathFinder as it
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 08:30 PM, Brett Cannon wrote:
The import path definition is a little misleading as sys.path is only
inferred when 'path' has None passed in. Otherwise 'path' is what __path__ in
a package is set to, so technically sys.path never even comes
Tom Tromey added the comment:
Here is a patch that includes a test case.
The test fails before the stringobject.c patch is applied,
and passes after.
--
Added file: http://bugs.python.org/file26629/P
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
I guess just saying it can be None depending on context would be enough.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15295
___
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 02:56 PM, Eric Snow wrote:
Part of the problem with the import nomenclature is that PEP 302 doesn't
really nail it down and mixes the terms up a bit. This is understandable
considering it broken ground in some regard. However, at this
Alexandre Vassalotti added the comment:
I reviewed the patch here
http://bugs.python.org/review/15513/#ps5596
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15513
___
Tim Peters added the comment:
Matthew, yes, PyPy's regex module implements regular expressions of the
computer science (as opposed to POSIX) sense. See Friedl's book for a full
explanation. Short course is that regex's flavor of regexp matching is
linear-time, but cannot support advanced
Chris Jerdonek added the comment:
Actually, here is a slightly more benign version of the patch.
This patch makes the change in the wrap() method and leaves _wrap_chunks()
alone.
This is less intrusive because it doesn't change the behavior of
_wrap_chunks(), which some people might be
New submission from Taihyun Hwang:
Attached patch enables ASDL parser to construct fields in the right order.
It resolves the issue below in Parser/asdl.py
# XXX can't I just construct things in the right order?
We can safely use left-recursive grammar since Parser/spark.py implements
Earley
Stefan Krah added the comment:
New patches with tests for 3.2 and 3.3. For 3.2 I determined empirically
that EnableCOMDATFolding=1 (and not 0) turns on NOICF.
If anyone can confirm that this is the case or has a pointer to
the relevant vcproj docs, I'd be thrilled.
--
Added file:
Changes by Stefan Krah stefan-use...@bytereef.org:
Added file: http://bugs.python.org/file26633/issue8847-3.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
Benjamin Peterson added the comment:
Thanks for the patch. I'll look at this.
--
assignee: - benjamin.peterson
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15517
Changes by Stefan Krah stefan-use...@bytereef.org:
Removed file: http://bugs.python.org/file26632/issue8847-3.3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
Changes by Stefan Krah stefan-use...@bytereef.org:
Added file: http://bugs.python.org/file26634/issue8847-3.3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
Nick Coghlan added the comment:
Yes, the module docs should have the provisional notice. Good catch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14814
___
Éric Araujo added the comment:
Please backport and leave open for distutils2. I much prefer that bugs stay
open for months rather than porting to d2 be forgotten. Thanks.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
I would largely use Brett's proposed interface for MetaPathFinder (but keep
the path argument optional) and his PathImporter interface for
PathEntryHandler.
Finder can then just become a legacy alias for MetaPathFinder.
--
Martin v. Löwis added the comment:
Also, the only person to run the tests with the PGO build will probably
be Martin just before the releases. :)
We could set up a buildbot slave which does PGO builds, provided somebody
volunteered an installation (including VS Pro), and somebody contributed
Martin v. Löwis added the comment:
If anyone can confirm that this is the case or has a pointer to
the relevant vcproj docs, I'd be thrilled.
http://msdn.microsoft.com/de-de/library/microsoft.visualstudio.vcprojectengine.vclinkertool.enablecomdatfolding(v=vs.90).aspx
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
Barry A. Warsaw added the comment:
On Jul 30, 2012, at 04:39 AM, Meador Inge wrote:
Meador Inge added the comment:
How about the attached?
What about something like:
globals = ({} if globals is None else globals)
and similarly for locals?
--
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
___
Python-bugs-list mailing list
Eric Snow added the comment:
I'm working up a patch. My intention is to match up the names to those that
Barry has pushed out to the updated glossary: MetaPathFinder and
PathEntryFinder. I'll also include doc changes.
I'm going to toy with not having any inheritance between the 3, but I'm
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15500
___
___
Python-bugs-list mailing list
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15489
___
___
Python-bugs-list mailing list
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Python-bugs-list mailing list
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15490
___
___
Python-bugs-list mailing list
Ned Batchelder added the comment:
I agree with Antoine: I don't see why this should be a feature of virtualenvs.
It's easy to use environment variables in a tightly-controlled way. We don't
worry that any of the other environment variables that affect Python execution
will somehow escape
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14918
___
___
Python-bugs-list mailing list
Atsuo Ishimoto added the comment:
I found 'more' command in Windows7 requires \r\n.
Python 2.7.3:
C:\python -c for i in range(5):print(i)|more
0
1
2
3
4
Python 3.3(trunk):
c:\src\cpython\PCbuildpython -c for i in range(5):print(i)|more
?
--
nosy: +ishimoto
Jesús Cea Avión added the comment:
Thanks. Applying to 3.3.
--
assignee: - jcea
nosy: +jcea
versions: +Python 3.3 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15499
___
Roundup Robot added the comment:
New changeset a16403affccd by Jesus Cea in branch 'default':
Closes #15499: Sleep is hardcoded in webbrowser.UnixBrowser
http://hg.python.org/cpython/rev/a16403affccd
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
status: open -
New submission from Chris Calloway:
The filecmp module has no tests for the following methods of the dircmp class:
report()
report_partial_closure()
report_full_closure()
The attached patch provides those tests. This issue was suggested in issue
15454. Future plans for these tests are
Changes by Chris Calloway c...@chriscalloway.org:
--
nosy: +cjerdonek
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Thank you and the issue to add report method tests is issue 15518.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15454
___
Chris Jerdonek added the comment:
Thanks, Chris. A couple high-level comments.
I know this isn't the prevailing style of the existing tests, but it's
generally better if each unit test tests just one thing. That way, for
example, if a test fails you know more precisely what is not working.
Nick Coghlan added the comment:
(With the draft docs now comitted, this issue is the home for thrashing out the
terminology. I'm not going to propose taking this to import-sig or python-dev,
because the bikeshed would end up being fuschia or pink-with-yellow-polkadots
or something)
However
New submission from Eric Snow:
1. add to importlib.machinery
2. register on importlib.abc.Finder
patch in a moment.
--
components: Interpreter Core
keywords: needs review
messages: 167074
nosy: brett.cannon, eric.snow, loewis
priority: normal
severity: normal
stage: patch review
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file26636/issue15519_expose_importer.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15519
Nick Coghlan added the comment:
Further thoughts:
1. Let's keep Finder as a generic base class for things which find module
loaders, with its current implementation but an updated docstring and
documentation.
2. The reason both the MetaPathFinder and PathEntryHander ABCs need to preserve
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file26636/issue15519_expose_importer.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15519
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Added file: http://bugs.python.org/file26637/issue15519_expose_importer.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15519
___
Jesús Cea Avión added the comment:
I take care of this.
--
assignee: - jcea
hgrepos: +143
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
Chris Calloway added the comment:
Would it be possible to structure things so that you have tests like
test_report(), test_report_partial_closure(), etc?
Yes, I would prefer that structure. I was just being consistent, as you said,
with the prevailing style of the existing tests. I will
Changes by Jesús Cea Avión j...@jcea.es:
--
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Python-bugs-list
Mike Castle added the comment:
I did read through all of those before posting this one.
As far as I can remember, none of those addressed the use of pack, which is the
sole problem I'm facing here.
Now maybe when all is said and done and all of these bitfield bugs are worked
out, this one
Changes by Jesús Cea Avión j...@jcea.es:
Added file: http://bugs.python.org/file26638/a16403affccd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
Nick Coghlan added the comment:
Reading through What's New, I withdraw the suggestion of changing the path
entry finder term. It's just not worth the hassle.
That also simplifies things a lot. All that needs to change to make things
consistent:
1. Switch the docs over to using path finder
Jesús Cea Avión added the comment:
Please, review patch
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Meador Inge added the comment:
The test should go in the 'SizeofTest' class and maybe a better test would be a
variant of the test already in that class:
@support.cpython_only
def test_buffer_freeing(self) :
bufsize = 4096
rawio = self.MockRawIO()
bufio =
Chris Jerdonek added the comment:
The tempfile-generated directory names are part of the report method output
and are not known in advance.
There are at least two ways you could deal with this. You could change the
working directory to the temp directory in setUp() and change it back in
Roundup Robot added the comment:
New changeset cbfb915424fd by Benjamin Peterson in branch 'default':
construct fields in the right order (closes #15517)
http://hg.python.org/cpython/rev/cbfb915424fd
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
status: open -
Eric Snow added the comment:
Here's a patch that addresses Nick's 2 3. I think I found a satisfactory
solution for the inheritance that is both correct and backward compatible.
One question for now: does FileFinder need to keep its find_module() method?
That should be resolved before 3.3
Eric Snow added the comment:
I just noticed that WindowsRegistryImporter does not have load_module(). If we
are going for consistency, we should change the name to WindowsRegistryFinder.
--
___
Python tracker rep...@bugs.python.org
Eric Snow added the comment:
With the draft docs now comitted, this issue is the home for thrashing
out the terminology.
In my mind the key is consistency. While a worthy goal regardless, for the
import system and its attendant complexity, consistency is crucial.
(importer == finder +
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file26639/issue15502_new_abc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Added file: http://bugs.python.org/file26640/issue15502_new_abc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file26640/issue15502_new_abc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
Added file: http://bugs.python.org/file26641/issue15502_new_abc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
Nick Coghlan added the comment:
Reading the 3.3 What's New reminded me that we aren't really as free to
redefine this terminology as we might hope (or as I claimed on the previous
issue). We can still try, of course, but the PEP 302 naming scheme has been
around for 10 years, and there are
101 - 160 of 160 matches
Mail list logo
