[issue13992] Segfault in PyTrash_destroy_chain

Manu Cupcic added the comment: Hi, Antoine, thank you for the patch you proposed. It indeed fixed the bug I was seeing (I ran a job that usually crashes in one to two hours over the week end and it is still running). I am not sure what we should do now. Can this patch be integrated as is ? Wh

[issue15850] list.count() results wrong if both booleans & 1's/0's are present in the list

Varun Masuraha added the comment: Hey Martin, I think I got the point. Meanwhile I created my own myCount() for my problem ;-) Thanks. -- ___ Python tracker ___ ___

[issue14223] curses addch broken on Python3.3a1

Nicholas Cole added the comment: Unless I'm getting the build process wrong (possible, because I haven't tried testing fixes before), this fix isn't working for me. -- ___ Python tracker __

[issue13992] Segfault in PyTrash_destroy_chain

Antoine Pitrou added the comment: > I am not sure what we should do now. Can this patch be integrated as is > ? What can I do to help ? Well, you already helped by testing it, thank you. I have to add a test case to the patch, then hopefully it can be committed. -- stage: -> patch rev

[issue14223] curses addch broken on Python3.3a1

Changes by Nicolas Schodet : -- nosy: -schodet ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue15785] curses.get_wch() returns keypad codes incorrectly

Changes by Nicolas Schodet : -- nosy: -schodet ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue15814] memoryview: equality-hash invariant

Nick Coghlan added the comment: The main issue is that it's not quite clear how to deal with problems like C-style vs FORTRAN-style memory layouts and strides vs suboffsets in defining multidimensional hash equality. Without a use case, it's easier to just punt on the question and declare it i

[issue15814] memoryview: equality-hash invariant

Roundup Robot added the comment: New changeset c9c9d890400c by Nick Coghlan in branch 'default': Issue #15814: Add NEWS entry regarding intended memoryview hashing restrictions http://hg.python.org/cpython/rev/c9c9d890400c -- ___ Python tracker

[issue14223] curses addch broken on Python3.3a1

STINNER Victor added the comment: > Unless I'm getting the build process wrong (possible, because > I haven't tried testing fixes before), this fix isn't working for me. Oh did you compile Python? Did you install it? Do you have libncursesw? => do you have the function curses.unget_wch? What i

[issue14223] curses addch broken on Python3.3a1

Changes by Christian Hofstaedtler : -- nosy: -zeha ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue15814] memoryview: equality-hash invariant

Stefan Krah added the comment: Small nitpick: multi-dimensional hashing wasn't really accidental, it was perfectly aligned with the previous statically typed equality definition. When I suggested PyBuffer_Hash = hash(obj.tobytes()) on python-dev for non-contiguous and multi-dimensional arrays, I

[issue15748] Various symlink test failures in test_shutil on FreeBSD

Trent Nelson added the comment: Link to discussion (initiated by Andriy) on z...@lists.illumos.org: http://thread.gmane.org/gmane.os.illumos.zfs/69 -- ___ Python tracker ___ ___

[issue14223] curses addch broken on Python3.3a1

Nicholas Cole added the comment: > Unless I'm getting the build process wrong (possible, because > I haven't tried testing fixes before), this fix isn't working for me. Oh did you compile Python? Did you install it? Yes, I tried compiling it. #./configure MACOSX_DEPLOYMENT_TARGET=10.8 --enab

[issue15814] memoryview: equality-hash invariant

Alexander Belopolsky added the comment: On Mon, Sep 3, 2012 at 8:38 AM, Stefan Krah wrote: > I don't see what could possibly be ill-defined about using the > tobytes() definition for ND-arrays. In all places memoryview now > uses the logical array, which is displayed by tolist(). +1. The key r

[issue15814] memoryview: equality-hash invariant

Changes by Stefan Behnel : -- nosy: -scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15557] Tests for webbrowser module

Anton Barkovsky added the comment: I think you forgot to write `test_open_with_autoraise_false` for Chrome tests. -- ___ Python tracker ___ __

[issue15855] memoryview methods are missing docstrings

New submission from Alexander Belopolsky: With attached patch python -mpydoc memoryview display looks as follows: ... | cast(...) | M.cast(format[, shape]) -> memoryview | | Cast a memoryview to a new format or shape. | | release(...) | M.release() -> None |

[issue15836] unittest assertRaises should verify excClass is actually a BaseException class

Daniel Wagner-Hall added the comment: Cool, my contributor agreement has been received, please merge if happy! -- ___ Python tracker ___ _

[issue14223] curses addch broken on Python3.3a1

STINNER Victor added the comment: > How do I check which version it was built against? On Linux, I use: $ ldd /usr/lib/python2.7/lib-dynload/_curses.so |grep curses libncursesw.so.5 => /lib/i386-linux-gnu/libncursesw.so.5 (0xb76d) $ ls -l /lib/i386-linux-gnu/libncursesw.so.5 lrwxrwx

[issue14223] curses addch broken on Python3.3a1

Nicholas Cole added the comment: On Mon, Sep 3, 2012 at 3:15 PM, STINNER Victor wrote: > > STINNER Victor added the comment: > >> How do I check which version it was built against? > > On Linux, I use: > > $ ldd /usr/lib/python2.7/lib-dynload/_curses.so |grep curses > libncursesw.so.5 =>

[issue15557] Tests for webbrowser module

R. David Murray added the comment: I did indeed. -- Added file: http://bugs.python.org/file27110/test_webbrowser.patch ___ Python tracker ___

[issue15856] inspect.getsource(SomeClass) doesn't show @decorators

New submission from Thomas Kluyver: Since bug #1006219 was fixed, inspect.getsource(func) has returned the source of a function including any decorators on the function. But doing the same with a class, the returned source doesn't include decorators. With functions, the co_firstlineno attribut

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: I added some comments on the latest patch on the review tool. -- ___ Python tracker ___ ___ Python-b

[issue15855] memoryview methods and data members are missing docstrings

Alexander Belopolsky added the comment: In the new patch, I added docstrings for the data members and now the list of memoryview data descriptors looks as follows in pydoc: | -- | Data descriptors defined here: | | c_c

[issue15855] memoryview methods and data members are missing docstrings

Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file27109/memoryobject-docstrings.diff ___ Python tracker ___ ___ Pytho

[issue15509] webbrowser.open sometimes passes zero-length argument to the browser.

R. David Murray added the comment: Given the logic of webbrowser, I think Anton's patch is correct. The null strings are produced by the somewhat twisted logic of UnixBrowser.open, and the problem doesn't apply to the other cases of argument list generation. (In those other cases, getting nu

[issue15509] UnixBrowser.open sometimes passes zero-length argument to the browser.

Changes by R. David Murray : -- title: webbrowser.open sometimes passes zero-length argument to the browser. -> UnixBrowser.open sometimes passes zero-length argument to the browser. ___ Python tracker ___

[issue15857] memoryview of a ctypes struct has incompatible invalid format

New submission from Alexander Belopolsky: Starting with the example in memoryview documentation: >>> from ctypes import BigEndianStructure, c_long >>> class BEPoint(BigEndianStructure): ... _fields_ = [("x", c_long), ("y", c_long)] ... >>> point = BEPoint(100, 200) >>> a = memoryview(point)

[issue15855] memoryview methods and data members are missing docstrings

Antoine Pitrou added the comment: This should also be fixed in 3.2 (at least for those methods/members which are in 3.2). -- nosy: +pitrou versions: +Python 3.2, Python 3.3 -Python 3.4 ___ Python tracker _

[issue15855] memoryview methods and data members are missing docstrings

Alexander Belopolsky added the comment: I am going to commit this tonight. Stefan, please let me know if you have any comments. I copied most of the descriptions from ReST manual with a few minor changes. See shape/strides/suboffsets. -- stage: -> commit review ___

[issue15447] A file is not properly closed by webbrowser._invoke

Roundup Robot added the comment: New changeset 901c790e4417 by R David Murray in branch 'default': #15447: Use subprocess.DEVNULL in webbrowser, instead of opening http://hg.python.org/cpython/rev/901c790e4417 New changeset 5da3b2df38b3 by R David Murray in branch 'default': #15557,#15447,#15509

[issue15557] Tests for webbrowser module

Roundup Robot added the comment: New changeset 5da3b2df38b3 by R David Murray in branch 'default': #15557,#15447,#15509: webbrowser test suite added. http://hg.python.org/cpython/rev/5da3b2df38b3 -- nosy: +python-dev ___ Python tracker

[issue15509] UnixBrowser.open sometimes passes zero-length argument to the browser.

Roundup Robot added the comment: New changeset 6768aa70c2d3 by R David Murray in branch '3.2': #15509: If %action substitution produces a null string, drop it. http://hg.python.org/cpython/rev/6768aa70c2d3 New changeset 323ca2f0e382 by R David Murray in branch 'default': Merge #15509: If %action

[issue15857] memoryview: complete support for struct packing/unpacking

Stefan Krah added the comment: It's deliberately not implemented (and documented): Since memoryview is a complete rewrite, I tried go easy on new features in order to facilitate review. My plan was to implement struct packing/unpacking in 3.3.1 in the same manner as in the new equality function

[issue15509] UnixBrowser.open sometimes passes zero-length argument to the browser.

R. David Murray added the comment: Thanks, Anton. -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___

[issue15447] A file is not properly closed by webbrowser._invoke

R. David Murray added the comment: Thanks, Anton. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Thanks, Anton. And thank you Chris for the initial reviews. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker _

[issue14223] curses addch broken on Python3.3a1

Ned Deily added the comment: > Can that possibly be right?? Yes. That's the version of ncurses that Apple ships with current versions of OS X. You can build it yourself and install into /usr/local and rebuild python. For ncurses 5.9, something like: ./configure --enable-widec --enable-share

[issue15857] memoryview: complete support for struct packing/unpacking

Alexander Belopolsky added the comment: What about >>> struct.unpack_from('>ll',a) (0, 100) shouldn't that return (100, 200)? -- ___ Python tracker ___

[issue15855] memoryview methods and data members are missing docstrings

Stefan Krah added the comment: I've left a couple of comments. -- Personally I'd also prefer if all docstrings go into a separate section. I always perceive docstrings as noise that takes up precious vertical space, so for _decimal I even banned them into docstrings.h. I don't know if there's an

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Hmm. For some reason I did not get emailed these review comments, and I did not see your note before I did the checkin. I will take a look. -- ___ Python tracker __

[issue13518] configparser can’t read file objects from urlopen

Changes by moijes12 : -- nosy: -moijes12 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: Thanks, David. I wasn't sure if you had seen the comments. They're mostly stylistic, though, so it's not too big of a deal. -- ___ Python tracker ___

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Yeah, you make some good points, but I think I may already have spent more time on this that is justified by the amount of usage webbrowser gets :) So I think I'm going to leave it as is, as being 'good enough'. -- __

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Oh, I see. I did get the email, it's just that my email filter put it into a different folder from what I was expected. -- ___ Python tracker ___

[issue15857] memoryview: complete support for struct packing/unpacking

Stefan Krah added the comment: '>' in struct syntax implies "standard size" for 'l', which is 4 bytes. ctypes uses machine size for c_long, so on an LP64 machine you can unpack the data as: >>> struct.unpack_from('>qq', a) (100, 200) -- ___ Python t

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: Fair enough. :) I may keep a couple of those changes in mind if I ever have a chance to visit this module myself in the future. -- ___ Python tracker

[issue8911] regrtest.main should have a test skipping argument

Changes by moijes12 : -- nosy: +moijes12 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue15837] Added test to test_random.py testing Random.shuffle

Alessandro Moura added the comment: Comparing the execution time with and without the int=int argument of this command: amoura@amoura-laptop:~/cpython$ time ./python -c "from random import shuffle; lst=list(range(100)); shuffle(lst); print (len(lst))" I get with int=int: real0m13.755

[issue15855] memoryview methods and data members are missing docstrings

Alexander Belopolsky added the comment: On Sep 3, 2012, at 1:22 PM, Stefan Krah wrote: > Personally I'd also prefer if all > docstrings go into a separate section. I always perceive docstrings > as noise that takes up precious vertical space, so for _decimal I even > banned them into docstrings

[issue14922] mailbox.Maildir.get_message() may fail when Maildir dirname is a unicode string

Petri Lehtinen added the comment: This would be considered a new feature, and is thus out of scope for 2.7. An easy workaround is to encode the unicode path to str using the file system encoding first (sys.getfilesystemencoding()). -- resolution: -> rejected stage: needs patch -> comm

[issue8911] regrtest.main should have a test skipping argument

Changes by Chris Jerdonek : -- nosy: +cjerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue8911] regrtest.main should have a test skipping argument

Chris Jerdonek added the comment: > If you look at importlib.regrtest you will notice it has to muck with > sys.argv in order to get certain tests skipped. This is reminiscent of issue 15132 which I filed, but for unittest.TestProgram() rather than regrtest.main(). > 6. Switch regrtest.py to

[issue15855] memoryview methods and data members are missing docstrings

Stefan Krah added the comment: > On the other hand, this is not that important and consolidating the changes > in one section will make 3.2 to 3.3 merge easier. I'll consolidate and wait > for someone else to complain. :-) Thanks! I'm certain someone will complain, probably on python-dev righ

[issue15533] subprocess.Popen(cwd) documentation

Andrew Svetlov added the comment: Update patch. -- Added file: http://bugs.python.org/file27112/issue-15533-4-default.patch ___ Python tracker ___ ___

[issue15533] subprocess.Popen(cwd) documentation

Chris Jerdonek added the comment: Thanks, Andrew. Regarding your comment, it was a deliberate choice not to do the additional check because I wanted each test to check only one thing. But I am okay with adding the additional check. Regarding the patch, should all of the methods now do someth

[issue15510] textwrap.wrap('') returns empty list

Chris Jerdonek added the comment: Thanks a lot for the very thorough review, David. I should be able to update the patch and respond to a couple of your points later today or tomorrow at the latest. -- ___ Python tracker

[issue8911] regrtest.main should have a test skipping argument

Changes by moijes12 : -- nosy: -moijes12 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue15340] OSError with "import random" when /dev/urandom doesn't exist (regression from 2.6)

Antoine Pitrou added the comment: As for the patch: looks good on the principle. However, PyExc_NotImplementedError has no "errno" or "filename", attribute, so you shouldn't use PyErr_SetFromErrnoWithFilename. Instead, simply call PyErr_SetString. -- _

[issue15858] tarfile missing entries due to omitted uid/gid fields

New submission from Tom Lynn: The tarfile module silently truncates the list of entries when reading a tar file if it sees an entry with a uid/gid field containing only spaces/NULs. I got such a tarball from Java Maven/plexus-archiver. I don't know whether they write such fields deliberately

[issue15814] memoryview: equality-hash invariant

Martin v. Löwis added the comment: Am 02.09.2012 16:21, schrieb Alexander Belopolsky: > I have refrained from voting because in my line of work buffers or > memoryviews deal with large objects that rarely serve as dictionary > keys. As a result, I have zero experince with hashing of buffers. > T

[issue15744] missing tests for {RawIO,BufferedIO,TextIO}.writelines

Changes by Antoine Pitrou : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15814] memoryview: equality-hash invariant

Alexander Belopolsky added the comment: On Mon, Sep 3, 2012 at 3:59 PM, Martin v. Löwis wrote: > if hashing was restricted > to contiguous bytes, then the implementation would certainly be > simplified quite a bit: currently, if it's not contiguous, it needs > to make a separate copy and hash th

[issue15855] memoryview methods and data members are missing docstrings

Roundup Robot added the comment: New changeset c49f89261d65 by Alexander Belopolsky in branch '3.2': Issue #15855: added docstrings for memoryview methods and data descriptors. http://hg.python.org/cpython/rev/c49f89261d65 -- nosy: +python-dev ___ Pyt

[issue15855] memoryview methods and data members are missing docstrings

Roundup Robot added the comment: New changeset 16a69ccff5ce by Alexander Belopolsky in branch 'default': Issue #15855: added docstrings for memoryview methods and data descriptors (merge 3.2). http://hg.python.org/cpython/rev/16a69ccff5ce -- ___ Pyth

[issue15855] memoryview methods and data members are missing docstrings

Roundup Robot added the comment: New changeset ba2c1def3710 by Alexander Belopolsky in branch 'default': Issue #15855: added docstrings for memoryview methods and data descriptors new in 3.3. http://hg.python.org/cpython/rev/ba2c1def3710 -- ___ Pytho

[issue15855] memoryview methods and data members are missing docstrings

Alexander Belopolsky added the comment: A few remaining comments: 1) shape being None for 0-d views in 3.2 is probably a bug. I did not mention that behavior in docstring. 2) "a N-dimensional array" typo was copied from ReST. Fixing it does not deserve a separate tracker entry, but I would

[issue15837] Added test to test_random.py testing Random.shuffle

Serhiy Storchaka added the comment: Third parameter (int) plays a role only in the presence of a second one (random). -- ___ Python tracker ___ _

[issue15855] memoryview methods and data members are missing docstrings

Stefan Krah added the comment: > 1) shape being None for 0-d views in 3.2 is probably a bug. Probably. I don't know whether it's worth fixing. Several test cases in ctypes as well as in NumPy rely on it. So I guess we should just leave it for 3.2. > 2) "a N-dimensional array" typo was copied fr

[issue15855] memoryview methods and data members are missing docstrings

Roundup Robot added the comment: New changeset 82ae284cd5f1 by Alexander Belopolsky in branch 'default': Issue #15855: updated related manual entries. http://hg.python.org/cpython/rev/82ae284cd5f1 -- ___ Python tracker

[issue15837] Added test to test_random.py testing Random.shuffle

R. David Murray added the comment: No, it always has an effect. It means that the name 'int' is bound in locals instead of being looked up via globals. That is what makes it a micro-optimization (LOAD_FAST vs LOAD_GLOBAL, if you do a dis on the two variants). -- ___

[issue15837] Added test to test_random.py testing Random.shuffle

R. David Murray added the comment: Oh, I see what you are saying. The lookup of int is only done if random is not None. Yes, that is true. -- ___ Python tracker ___ __

[issue15837] Added test to test_random.py testing Random.shuffle

R. David Murray added the comment: If the optimization is actually useful, it can be preserved by just putting 'int=int' (with an 'optimization' comment :) before the loop. -- ___ Python tracker __

[issue15837] Added test to test_random.py testing Random.shuffle

Alessandro Moura added the comment: The int=int still makes no difference, but if the second argument is set to random.random, we get a big speedup, regardless of whether the third argument is there: without int=int: amoura@amoura-laptop:~/cpython$ time ./python -c "import random; lst=list(r

[issue15837] Added test to test_random.py testing Random.shuffle

Serhiy Storchaka added the comment: > This could be because of the many tests of whether the 2nd argument is None > in the loop. This is because Random._randbelow (and therefore randrange, randint) is relatively slow. -- ___ Python tracker

[issue15837] Added test to test_random.py testing Random.shuffle

Alessandro Moura added the comment: Yup. This is the result of simply eliminating the condition in the loop and just using the second argument (for the purposes of testing this only): amoura@amoura-laptop:~/cpython$ time ./python -c "import random; lst=list(range(100)); random.shuffle(lst

[issue15858] tarfile missing entries due to omitted uid/gid fields

Changes by Ned Deily : -- nosy: +lars.gustaebel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue15340] OSError with "import random" when /dev/urandom doesn't exist (regression from 2.6)

The Written Word added the comment: Hi Antoine, Thanks for the heads up. I've attached a revised patch that doesn't misuse PyErr_SetFromErrnoWithFilename. -- Added file: http://bugs.python.org/file27113/hash-randomization-not-implemented.patch ___

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

Changes by Campbell Barton : -- components: +Unicode, Windows nosy: +ezio.melotti versions: +Python 3.2, Python 3.3 ___ Python tracker ___ ___

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

New submission from Campbell Barton: There is an inconsistency in PyUnicode_EncodeFSDefault(), on Linux its argument is checked to be unicode, and NULL is returned when its not. On windows however, this throws an assertion. The problem with this is, in some CAPI code you may pass an argument a