[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: I tried applying the latest patch (patch #6) to 3.2, merging to default, and then running all tests in default, and the tests seem to all pass for me (in both default and 3.2). Also, the diff for the change in default after that process seems to be identical

[issue15822] installed python may fail incorrectly trying to rebuild lib2to3 grammar pickles

2012-09-09 Thread Georg Brandl
Georg Brandl added the comment: Picked to release clone as 411d500e56a1. -- priority: release blocker - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15822 ___

[issue15822] installed python may fail incorrectly trying to rebuild lib2to3 grammar pickles

2012-09-09 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15822 ___ ___ Python-bugs-list mailing

[issue15886] Doc: same word iteration

2012-09-09 Thread Masato HASHIMOTO
New submission from Masato HASHIMOTO: Same word (path_fd) is iterated in Doc/library/os.rst. 1858 This function can support :ref:`specifying a file descriptor 1859 path_fd`, :ref:`specifying a file descriptor path_fd` and :ref:`not 1860 following symlinks follow_symlinks`. version:

[issue13992] Segfault in PyTrash_destroy_chain

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5aa1bc2f00ad by Antoine Pitrou in branch 'default': Issue #13992: The trashcan mechanism is now thread-safe. This eliminates http://hg.python.org/cpython/rev/5aa1bc2f00ad -- ___ Python tracker

[issue14223] curses addch broken on Python3.3a1

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset d6d632f254ee by Victor Stinner in branch 'default': Close #14223: Fix window.addch(curses.ACS_HLINE) http://hg.python.org/cpython/rev/d6d632f254ee -- ___ Python tracker rep...@bugs.python.org

[issue10650] decimal.py: quantize(): excess digits with watchexp=0

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset e4ca4edee8bd by Stefan Krah in branch 'default': Closes #10650: Deprecate the watchexp parameter of Decimal.quantize(). http://hg.python.org/cpython/rev/e4ca4edee8bd -- ___ Python tracker

[issue15724] Add versionchanged to memoryview docs

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 144d649764cf by Stefan Krah in branch 'default': Issue #15724: Add versionchanged tags to the memoryview documentation. http://hg.python.org/cpython/rev/144d649764cf -- ___ Python tracker

[issue15781] test_threaded_import fails with -j4

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 85070f284fd2 by Antoine Pitrou in branch 'default': Issue #15781: Fix two small race conditions in import's module locking. http://hg.python.org/cpython/rev/85070f284fd2 -- ___ Python tracker

[issue15340] OSError with import random when /dev/urandom doesn't exist (regression from 2.6)

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6a782496f90a by Antoine Pitrou in branch 'default': Issue #15340: Fix importing the random module when /dev/urandom cannot be opened. http://hg.python.org/cpython/rev/6a782496f90a -- ___ Python tracker

[issue15784] OSError.__str__() should distinguish between errno and winerror

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4e941113e4fa by Richard Oudkerk in branch 'default': Issue #15784: Modify OSError.__str__() to better distinguish between http://hg.python.org/cpython/rev/4e941113e4fa -- ___ Python tracker

[issue15822] installed python may fail incorrectly trying to rebuild lib2to3 grammar pickles

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 411d500e56a1 by Ned Deily in branch 'default': Issue #15822: Fix installation of lib2to3 grammar pickles to ensure http://hg.python.org/cpython/rev/411d500e56a1 -- ___ Python tracker

[issue15785] curses.get_wch() returns keypad codes incorrectly

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 23377e88487b by Victor Stinner in branch 'default': Issue #15785: Modify window.get_wch() API of the curses module: return a http://hg.python.org/cpython/rev/23377e88487b -- ___ Python tracker

[issue15828] imp.load_module doesn't support C_EXTENSION type

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4f6f59303146 by Nick Coghlan in branch 'default': Issue #15828: Restore support for C extension modules in imp.load_module() http://hg.python.org/cpython/rev/4f6f59303146 New changeset a4a9c5717204 by Brett Cannon in branch 'default': Issue #15828:

[issue15814] memoryview: equality-hash invariant

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7734eb2707a1 by Stefan Krah in branch 'default': Issue #15814: Document planned restrictions for memoryview hashes in 3.3.1. http://hg.python.org/cpython/rev/7734eb2707a1 New changeset 71f4d80400f2 by Stefan Krah in branch 'default': Issue #15814:

[issue15885] @staticmethod __getattr__ doesn't work

2012-09-09 Thread Albert Zeyer
Albert Zeyer added the comment: I don't quite understand. Shouldn't __getattr__ also work in old-style classes? And the error itself ('staticmethod' object is not callable), shouldn't that be impossible? -- ___ Python tracker rep...@bugs.python.org

[issue15887] urlencode should accept generators or two elements tuples

2012-09-09 Thread Simonas Kazlauskas
New submission from Simonas Kazlauskas: ``urllib.parse.urlencode([('i', i) for i in range(1000)])`` works, but ``urlencode(('i', i) for i in range(1000))`` raises a ``TypeError: not a valid non-string sequence or mapping object``. Allowing urlencode to accept generators would make life a bit

[issue15886] os.stat() docs repeat specifying a file descriptor support

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is where the typo was introduced: http://hg.python.org/cpython/rev/c890cbad4748#l1.69 -- nosy: +cjerdonek title: Doc: same word iteration - os.stat() docs repeat specifying a file descriptor support ___ Python

[issue15122] Always rewrite single-file mailboxes in-place

2012-09-09 Thread Petri Lehtinen
Petri Lehtinen added the comment: Attaching a patch that changes all single-file mailboxes to be rewritten in-place instead of rewriting and renaming. The patch doesn't add an option, because IMO this should be the default behavior. In addition to solving the locking problems, this makes it

[issue15122] Always rewrite single-file mailboxes in-place

2012-09-09 Thread Petri Lehtinen
Changes by Petri Lehtinen pe...@digip.org: Added file: http://bugs.python.org/file27150/issue15122.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15122 ___

[issue15888] ipaddress HOWTO examples have some errors

2012-09-09 Thread Chris Jerdonek
New submission from Chris Jerdonek: The ipaddress HOWTO seems to have some errors in its interactive doctest examples. Below are the errors after running the doctests for it using the regrtest patch posted to issue 15629. (This is the first doc file for which I have used the modified script

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Roy Smith
Roy Smith added the comment: We need to define the scope of what input strings will be accepted. ISO-8601 defines a lot of stuff which we may not wish to accept. Do we want to accept both basic format (MMDD) and extended format (-MM-DD)? Do we want to accept things like 1985-W15-5,

[issue15889] regrtest --start option raises AttributeError in many scenarios

2012-09-09 Thread Chris Jerdonek
New submission from Chris Jerdonek: The --start option to regrtest raises an AttributeError in many scenarios. For example, these both raise an error: $ ./python.exe -m test --start test_random $ ./python.exe -m test --start test_random test_binascii test_random Traceback (most recent call

[issue15889] regrtest --start option raises AttributeError in many scenarios

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: This issue also affects 3.2 (but not 2.7; there is no --start option in 2.7). -- versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15889

[issue15888] ipaddress HOWTO examples have some errors

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: While we are here, the corresponding Python file also has a couple errors in one of its doctest examples. File Lib/ipaddress.py, line 209, in ipaddress.summarize_address_range Failed example: summarize_address_range(IPv4Address('192.0.2.0'), Exception

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-09-09 Thread R. David Murray
R. David Murray added the comment: Ah, my mistake. I forgot to do the hg add for the new files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14649 ___

[issue15888] ipaddress doctest examples have some errors

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: And also the main doc file Lib/ipaddress.rst (along with some formatting issues, and after adding needed imports): File Doc/library/ipaddress.rst, line 115, in ipaddress.rst Failed example: ipaddress.IPv4Address(3221225985) Expected:

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sep 9, 2012, at 8:15 AM, Roy Smith rep...@bugs.python.org wrote: We need to define the scope of what input strings will be accepted. Since it is easier to widen the domain of acceptable arguments than to narrow it in the future, I would say let's

[issue15875] tarfile may not make @LongLink for non-ascii character

2012-09-09 Thread Lars Gustäbel
Lars Gustäbel added the comment: I prepared a patch that fixes this issue and adds a few tests. Please try if it works for you. -- keywords: +patch stage: - patch review Added file: http://bugs.python.org/file27152/issue15875.diff ___ Python

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Steven Willis
Steven Willis added the comment: Here's a patch for 3.1 -- Added file: http://bugs.python.org/file27153/issue15676-3.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15676 ___

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Steven Willis
Steven Willis added the comment: Here's a patch for 3.2 -- Added file: http://bugs.python.org/file27154/issue15676-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15676 ___

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Steven Willis
Steven Willis added the comment: Here's a branch against the default branch in mercurial. I couldn't find a branch for 3.3 or 3.4. -- Added file: http://bugs.python.org/file27155/issue15676-default.patch ___ Python tracker rep...@bugs.python.org

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Roy Smith
Roy Smith added the comment: I see I mis-stated my example. When I wrote: s = str(d1) d2 = datetime.datetime(s) assert d1 == d2 what I really meant was: s = d1.isoformat() d2 = datetime.datetime(s) assert d1 == d2 But, now I realize that while that is certainly an absolute lower bound, it's

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Steven Willis
Changes by Steven Willis onlyn...@gmail.com: -- versions: +Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15676 ___ ___ Python-bugs-list

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: What workflow/command are you using to apply and then merge the patch? I didn't need to run hg add at any point to go from 3.2 to default, and run the tests, etc. -- ___ Python tracker rep...@bugs.python.org

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Charles-François Natali
Charles-François Natali added the comment: Thanks for the patches. Note that you don't have to provide a patch for each branch, it's usually the committer's job. The patch looks good, but the test could be rewritten with assertRaisesRegex():

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread John Nagle
John Nagle added the comment: For what parts of ISO 8601 to accept, there's a standard: RFC3339, Date and Time on the Internet: Timestamps. See section 5.6: date-fullyear = 4DIGIT date-month = 2DIGIT ; 01-12 date-mday = 2DIGIT ; 01-28, 01-29, 01-30, 01-31 based on

[issue15419] distutils: build_py_2to3 should use a separate build directory

2012-09-09 Thread Dániel Darabos
Dániel Darabos added the comment: I've had the same issue. I was installing Pyglet. I first installed it under Python 2, then: $ sudo python3 setup.py install running install running build running build_py running install_lib [...] creating

[issue2716] Reimplement audioop because of copyright issues

2012-09-09 Thread Aaron
Aaron added the comment: The license from http://sox.sourcearchive.com/documentation/12.17.7/g711_8c-source.html /* * This source code is a product of Sun Microsystems, Inc. and is provided * for unrestricted use. Users may copy or modify this source code without * charge. * * SUN SOURCE

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I realize that while that is certainly an absolute lower bound, it's almost certainly not sufficient. The most common use case I see on a daily basis is parsing strings that look like 2012-09-07T23:59:59+00:00. This is exactly what isoformat() of an

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: For what parts of ISO 8601 to accept, there's a standard: RFC3339 This is almost indistinguishable from the idea of accepting .isoformat() and str() results. From what I see the only difference is that 't' is accepted for date/time separator and 'z'

[issue15888] ipaddress doctest examples have some errors

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: I will prepare a patch for these three files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15888 ___ ___

[issue14223] curses addch broken on Python3.3a1

2012-09-09 Thread Nicholas Cole
Nicholas Cole added the comment: I've just tried the OS X build of 3.3rc2, and this has been fixed. Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14223 ___

[issue15881] multiprocessing 'NoneType' object is not callable

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27d410dd5431 by Alexander Belopolsky in branch '3.2': Issue #15881: Fixed atexit hook in multiprocessing. http://hg.python.org/cpython/rev/27d410dd5431 New changeset 08c680918ff8 by Alexander Belopolsky in branch 'default': Issue #15881: Fixed

[issue15881] multiprocessing 'NoneType' object is not callable

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset db67b848ddc3 by Alexander Belopolsky in branch '3.2': Issue #15881: Fixed 3.2 backport. http://hg.python.org/cpython/rev/db67b848ddc3 -- ___ Python tracker rep...@bugs.python.org

[issue15881] multiprocessing 'NoneType' object is not callable

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Applied to 3.2 and 3.3. Thanks for the patch! Leaving it open pending 2.7 commit. -- resolution: - fixed stage: commit review - committed/rejected ___ Python tracker rep...@bugs.python.org

[issue15881] multiprocessing 'NoneType' object is not callable

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset b05547e8ff92 by Alexander Belopolsky in branch '3.2': Issue #15881: Added NEWS entry and proper credit. http://hg.python.org/cpython/rev/b05547e8ff92 -- ___ Python tracker rep...@bugs.python.org

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-09-09 Thread R. David Murray
R. David Murray added the comment: I have separate working directories for 3.2 vs 3.3. If you have a single working directory, the files would continue to be present even without the add. The add is definitely needed for a correctly committed changeset. --

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Tomi Pieviläinen
New submission from Tomi Pieviläinen: The fix of #15822 caused another break. After installing 3.3rc2 from source, ls -ltc --full-time /usr/local/lib/python3.3/lib2to3/ shows: -rw---. 1 root root 1455 2012-09-09 20:55:36.475519602 +0300 PatternGrammar3.3.0.candidate.2.pickle -rw---.

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: I propose to postpone the fix for that to 3.3.1. Meanwhile, users should either set umask to 022 before installing, or chmod the files afterwards. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org

[issue15891] A public facing API for __unittest = True

2012-09-09 Thread Julian Berman
New submission from Julian Berman: Can `__unittest = True`, which is used to hide stack frames from tracebacks inside the testing framework, be documented as being public, or, if that's not acceptable, be replaced by something that is? `_exc_info_to_string` is a hairy function to need to

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever, ned.deily versions: +Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15890 ___

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Ned Deily
Ned Deily added the comment: AFAIK, the pickles are created with exactly the same permissions as the cached pyc and pyo files have been all along. So, if you propose to change the permissions for the pickles, the compileall steps should be changed as well. --

[issue15891] A public facing API for __unittest = True

2012-09-09 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of issue 1705520. Since Michael obviously hasn't gotten to it yet, a proposed patch might move things along. -- nosy: +r.david.murray stage: - committed/rejected status: open - closed superseder: - API for excluding methods from

[issue15891] A public facing API for __unittest = True

2012-09-09 Thread Michael Foord
Michael Foord added the comment: Whatever we do must be backwards compatible. The question is, is a better api that doesn't use stack frames (which is a hack in my opinion) even possible? -- ___ Python tracker rep...@bugs.python.org

[issue1705520] API for excluding methods from unittest stack traces

2012-09-09 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +Julian stage: test needed - needs patch versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1705520

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Ned Deily
Ned Deily added the comment: BTW, AFAICT, you'll get exactly the same behavior (with distribute failing due to pickle write permission) with earlier releases, like 3.2.3, if you happen to do a make install with an inappropriate umask value. So it appears that setting umask properly has been

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread R. David Murray
R. David Murray added the comment: It occurs to me that ignoring the user's selected umask could be considered a bug by some people. A package manager for a distribution should presumably ensure the correct umask during install, but if a user is doing a direct install, it seems reasonable to

[issue14223] curses addch broken on Python3.3a1

2012-09-09 Thread STINNER Victor
STINNER Victor added the comment: I've just tried the OS X build of 3.3rc2, and this has been fixed. Thank you! Great! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14223 ___

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Steven Willis
Steven Willis added the comment: Sorry, I thought that's what jcea was asking for. Here's an updated patch for the default branch in mercurial that uses assertRaisesRegex in the test. -- Added file: http://bugs.python.org/file27156/issue15676-default.patch

[issue15437] Merge Doc/ACKS.txt names into Misc/ACKS

2012-09-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: I was reminded of this issue by the following e-mail today: http://mail.python.org/pipermail/python-dev/2012-September/121639.html I updated the script I attached earlier to ensure that it can also be run against the names in 2.7 (attaching now as script #3).

[issue15419] distutils: build_py_2to3 should use a separate build directory

2012-09-09 Thread Ned Deily
Ned Deily added the comment: It seems to me this is just a special case of the more general issue of building multiple versions of the same distribution, say with multiple versions of Python 2. In general, anytime you change your build environment, you should start with no existing build

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

2012-09-09 Thread Eduardo A . Bustamante López
Eduardo A. Bustamante López added the comment: I'm not sure what's the best approach here. 1. Avoid changes in the Lib, and document a work-around, which involves installing an opener with the specific User-agent. The draw-back is that it modifies the behaviour of urlopen() globally, so

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

2012-09-09 Thread Eduardo A . Bustamante López
Eduardo A. Bustamante López added the comment: I forgot to mention that I ran a nc process in parallel, to see what data is being sent: ``nc -l -p ``. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15851

[issue15892] _PyImport_GetDynLoadFunc() doesn't check return value of fstat()

2012-09-09 Thread Christian Heimes
New submission from Christian Heimes: The function _PyImport_GetDynLoadFunc() in Python/dynload_shlib.c doesn't check the return value of fstat() CID 486250: Other violation (CHECKED_RETURN)At (3): Calling function fstat(fileno(fp), statb) without checking return value. This library function

[issue15893] Py_FrozenMain() resource leak and missing malloc checks

2012-09-09 Thread Christian Heimes
New submission from Christian Heimes: In Python/frozenmain.c the function Py_FrozenMain() doesn't handle argv_copy and argv_copy2 correctly. Both variables contain memory that is allocated with PyMem_Malloc(). argv_copy2 is never checked for NULL and both variables are not correctly cleaned

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Having separate patches is useful if the patch can not be applied cleanly to different python branches. This is specially true with 2.7/3.x. Checking the fix and committing it to 2.7, 3.2 and 3.3 (probably available in 3.3.1, not 3.3.0, already in release

[issue15894] _PyImport_ReInitLock() doesn't check return value of PyThread_acquire_lock

2012-09-09 Thread Christian Heimes
New submission from Christian Heimes: Coverity claims that the call to PyThread_acquire_lock with NOWAIT_LOCK can fail. It sounds plausible as you don't wait for the lock to succeed. CID 486861: Unchecked return value (CHECKED_RETURN)At (3): Calling function

[issue15895] PyRun_SimpleFileExFlags() can leak a FILE pointer

2012-09-09 Thread Christian Heimes
New submission from Christian Heimes: In Python/pythonrun.c PyRun_SimpleFileExFlags() may leak a FILE pointer if closeit is False and maybe_pyc_file returns true. This happens when the filename ends with .pyc or .pyc. In this case the file is opened a second time with fopen() a few lines

[issue15890] lib2to3 pickles created with wrong permissions

2012-09-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: It appears that it is tradition of (BSD) install(1) to ignore umask. For consistency, all installed files should get the same ACL (+-x where necessary). So I think this behavior is a bug (although apparently not a regression). --

[issue15896] Sporadic EINVAL in nonblocking pipe os.read when forked child fails on Mac OS

2012-09-09 Thread Vitaly
New submission from Vitaly: Python 2.6.7 on Mac OS 10.7.4 running on MacBookPro laptop. run attachment as: python test_pipe_error.py The test() function makes multiple calls to _execute_child() in a loop. Every other call to _execute_child() fails with: = os.read(3, 1048576) self pid:

[issue15676] mmap: add empty file check prior to offset check

2012-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset d85f80b31b54 by Jesus Cea in branch '3.2': Closes #15676: mmap: add empty file check prior to offset check http://hg.python.org/cpython/rev/d85f80b31b54 New changeset f962ec8e47a1 by Jesus Cea in branch 'default': Closes #15676: mmap: add empty

[issue15897] zipimport.c doesn't check return value of fseek()

2012-09-09 Thread Christian Heimes
New submission from Christian Heimes: The code im zipimport.c doesn't check the return value of fseek() in at least four places. The missing checks may hide issues with the file or file system. Solution: Check for -1 and return with an appropriate call to PyErr_SetFromErrno() --

[issue15870] PyType_FromSpec should take metaclass as an argument

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15870 ___ ___ Python-bugs-list mailing list

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15873 ___ ___ Python-bugs-list mailing list

[issue15898] OSX TTY bug

2012-09-09 Thread Andrew Moffat
New submission from Andrew Moffat: I'm getting some kind of race condition on OSX when trying to read the output from a pseudoterminal of a forked process. This race conditional only occurs if I run tty.tcsetattr on the master side of the pty, regardless of if I actually change the mode or

[issue15875] tarfile may not make @LongLink for non-ascii character

2012-09-09 Thread Manuke
Manuke added the comment: I have tried your patch and it have worked completely for my test code. The patch is efficient. Thank you for your speedy work. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15875

[issue15719] Sort dict items in urlencode()

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15719 ___ ___ Python-bugs-list mailing list

[issue15723] Python breaks OS' append guarantee on file writes

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15723 ___ ___ Python-bugs-list mailing list

[issue15751] Support subinterpreters in the GIL state API

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15751 ___ ___ Python-bugs-list mailing list

[issue15756] subprocess.poll() does not handle errno.ECHILD No child processes

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15756 ___ ___ Python-bugs-list mailing list

[issue15883] Add Py_errno to work around multiple CRT issue

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15883 ___ ___ Python-bugs-list mailing list

[issue15897] zipimport.c doesn't check return value of fseek()

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15897 ___ ___ Python-bugs-list mailing list

[issue15895] PyRun_SimpleFileExFlags() can leak a FILE pointer

2012-09-09 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: LGTM. Instead of using a flag variable, could you use something like if (fp!=NULL) fclose(fp);? -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15895

[issue15894] _PyImport_ReInitLock() doesn't check return value of PyThread_acquire_lock

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15894 ___ ___ Python-bugs-list mailing list

[issue15898] OSX TTY bug

2012-09-09 Thread Ned Deily
Ned Deily added the comment: I have not been able to reproduce the behavior you report using various Pythons on OS X 10.8 or on OS X 10.5. Can you give more specifics on the environment that fails for you? I certainly don't claim to have any experience with these tty/pty modules or with the

[issue15893] Py_FrozenMain() resource leak and missing malloc checks

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15893 ___ ___ Python-bugs-list mailing list

[issue15892] _PyImport_GetDynLoadFunc() doesn't check return value of fstat()

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15892 ___ ___ Python-bugs-list mailing list

[issue15725] PyType_FromSpecWithBases bugfix

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15725 ___ ___ Python-bugs-list mailing list

[issue15726] PyState_FindModule false length-comparison fix

2012-09-09 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Antoine, you applied a patch, but market this issue as invalid. What that a mistake?. Should it be closed?. -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15726

[issue15726] PyState_FindModule false length-comparison fix

2012-09-09 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: I meant fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15726 ___ ___ Python-bugs-list mailing list

[issue15727] PyType_FromSpecWithBases tp_new bugfix

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15727 ___ ___ Python-bugs-list mailing list

[issue15695] Correct __sizeof__ support for StgDict

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15695 ___ ___ Python-bugs-list mailing list

[issue15696] Correct __sizeof__ support for mmap

2012-09-09 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15696 ___ ___ Python-bugs-list mailing list

[issue15898] OSX TTY bug

2012-09-09 Thread Andrew Moffat
Andrew Moffat added the comment: If I move tcsetattr into the parent, the race condition still exists. If I move it into the child, before the write(), it works. My environment is OSX 10.7.2 inside of Virtualbox (maybe this is the problem?) I've shuffled some code around, and found case that

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: For some reason there are no review links, so I'll review in this message. Include/datetime.h +typedef struct { .. +} _datetimemodulestate; Names exposed in public headers (datetime.h is a public header) should start with Py or _Py. Other offenders

[issue15695] Correct __sizeof__ support for StgDict

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: What is the point of providing a __sizeof__ method to a purely internal type? I don't think it is possible to expose StgDict at the python level. It is always hidden behind a mapping proxy. Furthemore, StgDict is only used inside type objects and the

[issue15725] PyType_FromSpecWithBases bugfix

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Why is this a problem? ISTM all that is happening is that null tp_base is set to null if Py_tp_base slot is specified as null. If this is somehow a problem - the user should not specify Py_tp_base slot. -- nosy: +belopolsky

[issue15727] PyType_FromSpecWithBases tp_new bugfix

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Can you give an example of the situation that you described? Perhaps you encountered it while refactoring some particular extension module. Which? In your patch new code is commented out. PySpec_New() is not a good name. It should be something like

[issue15873] datetime cannot parse ISO 8601 dates and times

2012-09-09 Thread Alexander Belopolsky
Changes by Alexander Belopolsky alexander.belopol...@gmail.com: -- assignee: - belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15873 ___

  1   2   >