[issue16702] Force urllib2_localnet test not to use http proxies
Senthil Kumaran added the comment: Jeff, Thanks for raising this issue. The aspect of skipping localhost for proxies in urllib2_localnet tests can be handled in a different way as well, namely by setting the environment varible NO_PROXY to *. By this the skip_proxies in urllib2 returns True and proxies are skipped for both HTTP and HTTPS. -- nosy: +orsenthil Added file: http://bugs.python.org/file28438/Issue16702.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16702 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16761] Fix int(base=X)
Serhiy Storchaka added the comment: Sharing only those tests is not enough. We must revise all tests and extract common code to the separated class. I think this is too large change and unrelated to this issue. I will open a new issue for int tests enhancement and refactoring. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16761] Fix int(base=X)
Chris Jerdonek added the comment: It's enough not to make the problem worse, which is why I suggested it and what I wanted to avoid. If you copy-paste the tests you're adding now, it worsens the problem and makes it that much more tedious to fix later on (and to maintain in the meantime). Why must the code sharing be all or nothing? Elsewhere we phase in improvements incrementally. Even with the particular refactoring you're suggesting for the future, I'm not sure we'd want to do it all in one patch. If you begin the process now and add appropriate comments and TODO's pointing the way, at least the next person will know how to take the next steps. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Charles-François Natali added the comment: Semantically, but I am told that due to py3k's different file buffering, that those errors don't percolate through. According to Charles-Francois' post from apr, 14th: Note that Python 3.3 doesn't have this problem. It's not affected by the problem, but it's really just accidental, so it would probably be better to apply this as well to py3k. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16702] Force urllib2_localnet test not to use http proxies
Roundup Robot added the comment: New changeset 6c186caa6285 by Senthil Kumaran in branch '2.7': Issue #16702: Skip proxies for localhost in urllib2_localnet tests http://hg.python.org/cpython/rev/6c186caa6285 New changeset 0eccfb237364 by Senthil Kumaran in branch '3.2': Issue #16702: Skip proxies for localhost in urllib2_localnet tests http://hg.python.org/cpython/rev/0eccfb237364 New changeset 8a524faeb7ae by Senthil Kumaran in branch '3.3': Issue #16702: Skip proxies for localhost in urllib2_localnet tests http://hg.python.org/cpython/rev/8a524faeb7ae New changeset 43b19d9f9af4 by Senthil Kumaran in branch 'default': Issue #16702: Skip proxies for localhost in urllib2_localnet tests http://hg.python.org/cpython/rev/43b19d9f9af4 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16702 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16702] Force urllib2_localnet test not to use http proxies
Senthil Kumaran added the comment: Fixed in all branches of CPython. Thanks. -- assignee: - orsenthil resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16702 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
New submission from Serhiy Storchaka: Int tests should be synchronized between different Python versions. Tests for int and long should be synchronized in 2.7. Common code for int and long tests should be shared in 2.7. CPython tests (i.e. small int identity) should be extracted to separated methods. Tests should be resorted by tested feature. Deprecated assertEquals should be replaced to assertEqual. And may be more. -- assignee: serhiy.storchaka components: Tests messages: 178197 nosy: serhiy.storchaka priority: normal severity: normal stage: needs patch status: open title: Int tests enhancement and refactoring type: enhancement versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Fix int(base=X), int() accepts float number base nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16761] Fix int(base=X)
Serhiy Storchaka added the comment:
Here is a patches which contains only minimal set of required changes. Other
unrelated changes will be done in issue16784.
--
Added file: http://bugs.python.org/file28439/int_without_x-2.7_3.patch
Added file: http://bugs.python.org/file28440/int_without_x-3.2_3.patch
Added file: http://bugs.python.org/file28441/int_without_x-3.3_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
___diff -r ecf3cd3af502 Lib/test/test_int.py
--- a/Lib/test/test_int.py Tue Dec 25 14:50:21 2012 -0800
+++ b/Lib/test/test_int.py Wed Dec 26 12:43:10 2012 +0200
@@ -321,9 +321,11 @@
def test_keyword_args(self):
# Test invoking int() using keyword arguments.
-self.assertEquals(int(x=1.2), 1)
-self.assertEquals(int('100', base=2), 4)
-self.assertEquals(int(x='100', base=2), 4)
+self.assertEqual(int(x=1.2), 1)
+self.assertEqual(int('100', base=2), 4)
+self.assertEqual(int(x='100', base=2), 4)
+self.assertRaises(TypeError, int, base=10)
+self.assertRaises(TypeError, int, base=0)
def test_valid_non_numeric_input_types_for_x(self):
# Test possible valid non-numeric types for x, including subclasses
@@ -356,18 +358,6 @@
def test_error_on_string_base(self):
self.assertRaises(TypeError, int, 100, base='foo')
-# Include the following because in contrast CPython raises no error
-# for bad integer bases when x is not given.
-self.assertRaises(TypeError, int, base='foo')
-
-# For example, PyPy 1.9.0 raised TypeError for these cases because it
-# expects x to be a string if base is given.
-@test_support.cpython_only
-def test_int_base_without_x_returns_0(self):
-self.assertEquals(int(base=6), 0)
-# Even invalid bases don't raise an exception.
-self.assertEquals(int(base=1), 0)
-self.assertEquals(int(base=1000), 0)
def test_intconversion(self):
# Test __int__()
diff -r ecf3cd3af502 Lib/test/test_long.py
--- a/Lib/test/test_long.py Tue Dec 25 14:50:21 2012 -0800
+++ b/Lib/test/test_long.py Wed Dec 26 12:43:10 2012 +0200
@@ -452,6 +452,13 @@
self.assertEqual(long('2br45qc', 35), 4294967297)
self.assertEqual(long('1z141z5', 36), 4294967297)
+def test_keyword_args(self):
+# Test invoking long() using keyword arguments.
+self.assertEqual(long(x=1.2), 1)
+self.assertEqual(long('100', base=2), 4)
+self.assertEqual(long(x='100', base=2), 4)
+self.assertRaises(TypeError, long, base=10)
+self.assertRaises(TypeError, long, base=0)
def test_conversion(self):
# Test __long__()
diff -r ecf3cd3af502 Objects/intobject.c
--- a/Objects/intobject.c Tue Dec 25 14:50:21 2012 -0800
+++ b/Objects/intobject.c Wed Dec 26 12:43:10 2012 +0200
@@ -1059,8 +1059,14 @@
if (!PyArg_ParseTupleAndKeywords(args, kwds, |Oi:int, kwlist,
x, base))
return NULL;
-if (x == NULL)
+if (x == NULL) {
+if (base != -909) {
+PyErr_SetString(PyExc_TypeError,
+int() missing string argument);
+return NULL;
+}
return PyInt_FromLong(0L);
+}
if (base == -909)
return PyNumber_Int(x);
if (PyString_Check(x)) {
diff -r ecf3cd3af502 Objects/longobject.c
--- a/Objects/longobject.c Tue Dec 25 14:50:21 2012 -0800
+++ b/Objects/longobject.c Wed Dec 26 12:43:10 2012 +0200
@@ -3987,8 +3987,14 @@
if (!PyArg_ParseTupleAndKeywords(args, kwds, |Oi:long, kwlist,
x, base))
return NULL;
-if (x == NULL)
+if (x == NULL) {
+if (base != -909) {
+PyErr_SetString(PyExc_TypeError,
+long() missing string argument);
+return NULL;
+}
return PyLong_FromLong(0L);
+}
if (base == -909)
return PyNumber_Long(x);
else if (PyString_Check(x)) {
diff -r e8793c5f0ebc Lib/test/test_int.py
--- a/Lib/test/test_int.py Tue Dec 25 15:26:24 2012 -0800
+++ b/Lib/test/test_int.py Wed Dec 26 12:43:18 2012 +0200
@@ -221,6 +221,14 @@
self.assertEqual(int('2br45qc', 35), 4294967297)
self.assertEqual(int('1z141z5', 36), 4294967297)
+def test_keyword_args(self):
+# Test invoking int() using keyword arguments.
+self.assertEqual(int(x=1.2), 1)
+self.assertEqual(int('100', base=2), 4)
+self.assertEqual(int(x='100', base=2), 4)
+self.assertRaises(TypeError, int, base=10)
+self.assertRaises(TypeError, int, base=0)
+
def test_intconversion(self):
# Test __int__()
class ClassicMissingMethods:
diff -r e8793c5f0ebc Objects/longobject.c
--- a/Objects/longobject.c Tue
[issue16761] Fix int(base=X)
Serhiy Storchaka added the comment: Let's eat an elephant piece by piece. Only one issue per patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Kristján Valur Jónsson added the comment: Ok, I'll have a look. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue949667] setblocking() method on file objects
Charles-François Natali added the comment: I'm not sure that a setblocking() method to fileobjects would make much sense, since non-blocking IO doesn't work with regular files (only pipes, sockets...). -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue949667 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16761] Fix int(base=X)
Chris Jerdonek added the comment: Yes, it is a better approach. At first glance, the patches look okay to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
Chris Jerdonek added the comment: Other things that should be done include porting the more comprehensive tests in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of the tests as necessary (see the Rietveld comments of issue 16761 for details on both). The various issues in this comment and above should probably be broken into multiple patches. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11939] Implement stat.st_dev and os.path.samefile on windows
Roundup Robot added the comment: New changeset 82531b78b719 by Brian Curtin in branch 'default': Add NEWS entry for fixing #11939 http://hg.python.org/cpython/rev/82531b78b719 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11939 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11939] Implement stat.st_dev and os.path.samefile on windows
Brian Curtin added the comment: Thanks for the reviews. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11939 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16769] Remove some old Visual Studio versions from PC/ directory
Changes by Christian Heimes li...@cheimes.de: -- nosy: +christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16769 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16786] argparse doesn't offer localization interface for version action
New submission from Thorsten Kampe: The - deprecated - version keyword for argparse.ArgumentParser allowed for localization of the show program's version number and exit help text for -v/--version (output of -h/--help) The new version action for add_argument does not allow this - resulting in a partially translated output for the -v/--version option. -- components: Library (Lib) messages: 178209 nosy: thorsten priority: normal severity: normal status: open title: argparse doesn't offer localization interface for version action type: behavior versions: Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16786 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10646] ntpath.samefile doesn't work for hard links
Roundup Robot added the comment: New changeset 9e980454b85e by Brian Curtin in branch 'default': Add tests for Issue #10646. http://hg.python.org/cpython/rev/9e980454b85e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10646 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11939] Implement stat.st_dev and os.path.samefile on windows
Roundup Robot added the comment: New changeset 9e980454b85e by Brian Curtin in branch 'default': Add tests for Issue #10646. http://hg.python.org/cpython/rev/9e980454b85e -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11939 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16786] argparse doesn't offer localization interface for version action
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +bethard ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16786 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16787] asyncore.dispatcher_with_send - increase the send buffer size
New submission from Charles-François Natali: As noted in issue #12498, asyncore.dispatcher_with_send only sends 512 bytes at a time: this is 1/3 of the Ethernet MTU, which reduces greatly the attainable bandwidth and increases the CPU usage. Here's a patch bumping it to 8192 (and making it a class member so that derived classes can customize it if needed, although not documented). Here's the result of a simplistic benchmark using asyncore.dispatcher_with_send to send data to a server: Without patch: $ time ./python ~/test_asyncore.py localhost 4242 real0m6.098s user0m4.472s sys 0m1.436s With patch: $ time ./python ~/test_asyncore.py localhost 4242 real0m0.937s user0m0.796s sys 0m0.112s Of course, this is using the loopback interface, but it shows that the performance gain can non negligible. The test script is attached (use netcat -l -p 4242 as server). -- components: Library (Lib) files: asyncore_buffsize.diff keywords: easy, needs review, patch messages: 178212 nosy: giampaolo.rodola, neologix, xdegaye priority: normal severity: normal stage: patch review status: open title: asyncore.dispatcher_with_send - increase the send buffer size type: performance versions: Python 3.4 Added file: http://bugs.python.org/file28442/asyncore_buffsize.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16787 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16787] asyncore.dispatcher_with_send - increase the send buffer size
Changes by Charles-François Natali neolo...@free.fr: Added file: http://bugs.python.org/file28443/test_asyncore.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16787 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8713] multiprocessing needs option to eschew fork() under Linux
Charles-François Natali added the comment: Richard, apart from performance, what's the advantage of this approach over the fork+exec version? Because it seems more complicated, and although I didn't have a look a this last patch, I guess that most of the fork+exec version could be factorized with the Windows version, no? Since it's only intented to be used as a debugging/special-purpose replacement - it would probably be better if it could be made as simple as possible. Also, as you've noted, FD passing isn't supported by all Unices out there (and we've had some reliability issues on OS-X, too). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8713 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9709] test_distutils warning: initfunc exported twice on Windows
Changes by Stefan Krah stefan-use...@bytereef.org: -- nosy: +jkloth ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9709 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16779] Fix compiler warning when building extension modules on 64-bit Windows
Stefan Krah added the comment: I think this is the same as #9709. Please just reopen if it isn't. -- nosy: +skrah resolution: - duplicate stage: - committed/rejected status: open - closed superseder: - test_distutils warning: initfunc exported twice on Windows ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16779 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16787] asyncore.dispatcher_with_send - increase the send buffer size
Giampaolo Rodola' added the comment: A couple of years ago I conducted similar tests and it turned out that 64k was the best compromise: http://code.google.com/p/pyftpdlib/issues/detail?id=94 Twisted uses 128k. I'd be for using 64k and also change asynchat.async_chat.ac_*_buffer_size in accordance. -- nosy: +josiah.carlson, josiahcarlson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16787 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10646] ntpath.samefile doesn't work for hard links
Brian Curtin added the comment: This was fixed as a result of #11939, and I've refactored the tests to add coverage of hard links in 9e980454b85e. This was originally a bug report but it requires a 3.4 feature so it can't be fixed in 3.2 where it originally appeared. -- resolution: - fixed stage: test needed - committed/rejected status: open - closed versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10646 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Richard Oudkerk added the comment: On 32 bit Unix mmap() will raise ValueError(mmap length is too large) in Marc's example. This is correct since Python's sequence protocol does not support indexes larger than sys.maxsize. But on 32 bit Windows, if length == 0 then the size check always passes, and the actual size mapped is the file size modulo 4GB. Fix for 3.x is attached with tests. -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file28444/mmap.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11939] Implement stat.st_dev and os.path.samefile on windows
Serhiy Storchaka added the comment:
Try on Windows:
import os
from os.path import *
samestat(os.stat('.'), os.stat('.'))
Traceback (most recent call last):
File stdin, line 1, in module
NameError: name 'samestat' is not defined
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11939
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16788] Add samestat to Lib/ntpath.py __all__
Changes by Brian Curtin br...@python.org: -- assignee: brian.curtin components: Library (Lib), Windows nosy: brian.curtin priority: normal severity: normal stage: needs patch status: open title: Add samestat to Lib/ntpath.py __all__ type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16788 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16788] Add samestat to Lib/ntpath.py __all__
New submission from Roundup Robot: New changeset cc3f7ef1072e by Brian Curtin in branch 'default': Fix #16788. Add samestat to Lib/ntpath.py http://hg.python.org/cpython/rev/cc3f7ef1072e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16788 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16788] Add samestat to Lib/ntpath.py __all__
Changes by Brian Curtin br...@python.org: -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16788 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11939] Implement stat.st_dev and os.path.samefile on windows
Brian Curtin added the comment: Separate issue. Fixed in #16788. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11939 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Serhiy Storchaka added the comment: This change is not backward compatible. Now user can mmap a larger file and safely access lower 2 GiB. With the patch it will fail. Unix implementation uses unsafe integer overflow idiom which cause undefined behavior (Mark, you have the floor). -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16789] :meth:`quit` links to constants instead of own module
New submission from Dan Kenigsberg: ftplib, poplib and smtplib modules define a quit function. But when it is refered by :meth:`quit` in the documentation, a reference to constants.quit is generated. The suggested patch spells out the module-specific quit function. -- assignee: docs@python components: Documentation files: meth:quit.patch keywords: patch messages: 178222 nosy: danken, docs@python priority: normal severity: normal status: open title: :meth:`quit` links to constants instead of own module type: behavior Added file: http://bugs.python.org/file28445/meth:quit.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16789 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Changes by Kristján Valur Jónsson krist...@ccpgames.com: -- versions: +Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16772] int() accepts float number base
Serhiy Storchaka added the comment: Why does PyNumber_AsSsize_t() used instead PyLong_AsLongAndOverflow()? The range of long enough for all valid values of base and code with PyLong_AsLongAndOverflow() produces better error messages. It looks as a regression for me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3236] ints contructed from strings don't use the smallint constants
Serhiy Storchaka added the comment: Should it be backported to 2.7? -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3236 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Roundup Robot added the comment: New changeset 7e5d7ef4634d by Kristján Valur Jónsson in branch '3.2': Issue #14574: Ignore socket errors raised when flushing a connection on close. http://hg.python.org/cpython/rev/7e5d7ef4634d New changeset 7734c3020a47 by Kristján Valur Jónsson in branch '3.3': Merge with 3.2 : http://hg.python.org/cpython/rev/7734c3020a47 New changeset 2d1cfbaef9a2 by Kristján Valur Jónsson in branch 'default': Merge with 3.3 http://hg.python.org/cpython/rev/2d1cfbaef9a2 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Kristján Valur Jónsson added the comment: There, applied the same changes to the 3.x branches. apparently the DOC folder wasn't branched off for 3.3, or something, at least, there is no sepatate 3.3 and 'default' version of socketserver.rst. Or maybe it is just Hg that got the better of me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16789] :meth:`quit` links to constants instead of own module
Jesús Cea Avión added the comment: I take care of this. -- assignee: docs@python - jcea nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16789 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Richard Oudkerk added the comment: This change is not backward compatible. Now user can mmap a larger file and safely access lower 2 GiB. With the patch it will fail. They should specify length=2GiB-1 if that is what they want. With length=0 you can only access the lower 2GiB if file_size % 4GiB 2GiB. If the file size is 4GiB+1 then you can only access *one byte* of the file. And if 2GiB file_size 4GiB then presumably len(data) will be negative (or throw an exception or fail an assertion -- I have not tested that case). I would not be surprised if crashes are possible. Basically if you had a large file and you did not hit a problem then it was Windows specific dumb luck. I see no point in retaining such unpredictable behaviour. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16789] :meth:`quit` links to constants instead of own module
Roundup Robot added the comment: New changeset 0ffaf1079a7a by Jesus Cea in branch '2.7': Closes #16789: :meth:`quit` links to constants instead of own module http://hg.python.org/cpython/rev/0ffaf1079a7a New changeset 3801ee5d5d73 by Jesus Cea in branch '3.2': Closes #16789: :meth:`quit` links to constants instead of own module http://hg.python.org/cpython/rev/3801ee5d5d73 New changeset b6a9f8fd9443 by Jesus Cea in branch '3.3': MERGE: Closes #16789: :meth:`quit` links to constants instead of own module http://hg.python.org/cpython/rev/b6a9f8fd9443 New changeset 3f7d5c235d82 by Jesus Cea in branch 'default': MERGE: Closes #16789: :meth:`quit` links to constants instead of own module http://hg.python.org/cpython/rev/3f7d5c235d82 -- nosy: +python-dev resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16789 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Serhiy Storchaka added the comment: Agree. Please add the same check for Unix implementation (instead of unsafe overflow trick). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16789] :meth:`quit` links to constants instead of own module
Jesús Cea Avión added the comment: Thanks!. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16789 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16781] execfile/exec execution of class statement does not access locals()
Benjamin Peterson added the comment: Basically, it calls locals() in the function scope, which is undefined behavior. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16781 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3236] ints contructed from strings don't use the smallint constants
Benjamin Peterson added the comment: It's only an optimization, so no. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3236 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16218] Python launcher does not support unicode characters
STINNER Victor added the comment: Status of the different issues: #16416, Mac OS X: 3.2, 3.3, 3.4 #16455, FreeBSD and Solaris: 3.4 #16218, set_main_loader: 3.3, 3.4 #16218, test_cmd_line_script: 3.4 (3.3 has an old copy of the test) #16414, add support.TESTFN_NONASCII: 3.4 #16444, use support.TESTFN_NONASCII: 3.4 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16218 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Richard Oudkerk added the comment: New patch with same check for Unix. -- Added file: http://bugs.python.org/file28446/mmap.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16413] Non cross-platform behavior of os.path.split
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - invalid status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16413 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16599] unittest: Access test result from tearDown
Serhiy Storchaka added the comment: Anatoly, if this is good for you, please close the issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16599 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Serhiy Storchaka added the comment: LGTM. Isn't 2 GiB + 1 bytes mmap file enough for testing? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14574] SocketServer doesn't handle client disconnects properly
Andrew Svetlov added the comment: Everything is fine. Close the issue. -- stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Andrew Svetlov added the comment: Anton, you are free to make that issue and propose a patch :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Andrew Svetlov added the comment: New patch is LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Andrew Svetlov added the comment: Chris, would you commit it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap accepts files 1 GB, but processes only 1 GB
Richard Oudkerk added the comment: Isn't 2 GiB + 1 bytes mmap file enough for testing? Yes. But creating multigigabyte files is very slow on Windows. On Linux/FreeBSD test_mmap takes a fraction of a second, whereas on Windows it takes over 2 minutes. (Presumably Linux/FreeBSD is automatically creating a sparse file.) So adding assertions to an existing test is more convenient than creating another huge file just for these new tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Chris Jerdonek added the comment: BTW, maybe someone should create an issue for full tests coverage of regrtest? I think such an issue would need to be a meta-issue because it is a very large task (involving many patches) and may never be truly finished. Chris, would you commit it? Sure, I should be able to get to it within a day or two. (By the way, after this is committed, the use of a Namespace return value can be phased in gradually as a replacement for some options in the getopt for loop. It need not be all or nothing.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Andrew Svetlov added the comment: Agree with both points -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
R. David Murray added the comment: I'm still -0 on making a new file. regrtest will be running as __main__, so I don't see any reason the test file can't import it to test functions within it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
R. David Murray added the comment: (I could, of course, be wrong :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Benjamin Peterson added the comment: Yes, please don't make something called regrtestlib.py. Some of us like the bash completetion to work with on a small prefix. :) -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13198] Remove duplicate definition of write_record_file
Andrew Svetlov added the comment: Close as out of date. Packaging has been removed from stdlib. -- nosy: +asvetlov resolution: - out of date stage: patch review - status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13198 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12944] Accept arbitrary files for packaging's upload command
Andrew Svetlov added the comment: Close as out of date since packaging has been removed from stdlib. -- nosy: +asvetlov resolution: - out of date status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12944 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Chris Jerdonek added the comment: Benjamin, do you not want a new file at all, or are you just asking for a different name? regrlib was the previous name unless you have another suggestion. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Benjamin Peterson added the comment: I think bitdancer's suggestion of leaving it in regrtest.py is a good one. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15422] Get rid of PyCFunction_New macro
Roundup Robot added the comment: New changeset 6a56eaa5e5fb by Andrew Svetlov in branch 'default': Revert back PyCFunction_New macro. Keep PyCFunction_NewEx usage in python core modules (#15422) http://hg.python.org/cpython/rev/6a56eaa5e5fb -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16781] execfile/exec execution in other than global scope uses locals(), leading to undefined behavior
R. David Murray added the comment: Do you mean that *modifying* locals() in the function scope is undefined behavior? That makes sense, and is a documented limitation. So we need to clarify the execfile/exec documentation to note that if called in anything other than the global scope, locals() will get used as the locals dictionary, and this will lead to undefined behavior if any operation is performed that updates the local namespace...and thus you are best recommend to always pass one or two dictionaries to execfile/exec, so that you *know* what is getting updated. Although I have to say that the exec/execfile doing something that is specified to lead to undefined behavior smells like a bug. (Not that we could fix it even if we agreed that it was, for backward compatibility reasons.) -- title: execfile/exec execution of class statement does not access locals() - execfile/exec execution in other than global scope uses locals(), leading to undefined behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16781 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15422] Get rid of PyCFunction_New macro
Andrew Svetlov added the comment: Georg, I've followed your instructions. Close the issue again. Thanks for mentorship. -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16781] execfile/exec execution in other than global scope uses locals(), leading to undefined behavior
Benjamin Peterson added the comment: The best thing would be if we could kill the default use of locals() and globals() in execfile, but that's probably Py4 material. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16781 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15422] Get rid of PyCFunction_New macro
Roundup Robot added the comment: New changeset 70ea05f762a1 by Andrew Svetlov in branch 'default': Fix compilation error for #15422 http://hg.python.org/cpython/rev/70ea05f762a1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py
Roundup Robot added the comment: New changeset 39be1514c16c by Andrew Svetlov in branch '3.2': fix test for subprocess (#16644) http://hg.python.org/cpython/rev/39be1514c16c New changeset 5d172190c37c by Andrew Svetlov in branch '3.3': fix test for subprocess (#16644) http://hg.python.org/cpython/rev/5d172190c37c New changeset 02d589e2d202 by Andrew Svetlov in branch 'default': fix test for subprocess (#16644) http://hg.python.org/cpython/rev/02d589e2d202 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16644 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py
Andrew Svetlov added the comment: Fixed. Thanks, Serhiy. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16644 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap on Windows can mishandle files larger than sys.maxsize
Changes by Richard Oudkerk shibt...@gmail.com: -- title: mmap accepts files 1 GB, but processes only 1 GB - mmap on Windows can mishandle files larger than sys.maxsize type: enhancement - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16772] int() accepts float number base
Gregory P. Smith added the comment: I used it because Mark suggested it could have the same behavior as round() and that is the more abstract API that round uses. Regardless, at this point I've added tests and tested for the TypeError when a float is passed as well as testing that the only valid values (2..36) all work. I did not test to see that something supporting __index__ works as Mark suggests because I don't know off the top of my head of anything that does and it seems like a pointless thing to care about for this API. If you want something different, feel free to change the code. I'm done with this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap on Windows can mishandle files larger than sys.maxsize
Serhiy Storchaka added the comment: Sorry, I had missed you reuse an existing test. It's right. I think decreasing file size to 4 GiB + 1 byte will keep the purpose of the test and save a little time, but this is another issue. Let's go ahead! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap on Windows can mishandle files larger than sys.maxsize
Terry J. Reedy added the comment: New data, new thoughts ;-) I agree that an undocumented discrepancy between Windows and *nix should be fixed either in doc, code, or both. The fix might be version specific. If the limit on Windows is less than it should or could be, because of our code, that should be changed. It would be best if the working limit were the same for all major platforms or at least the same for all versions of each major platform. I am a bit reluctant to break working code on existing versions, even if the code depends on dumb luck because of an undocumented version-specific buggy 'feature'. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16778] Logger.findCaller needs to be smarter
Vinay Sajip added the comment: What about subclassing Logger? Then you could override findCaller() to do whatever you need, as well as adding a notice() method, for example. I agree using the source filename isn't ideal, but it's hard to know how people might arbitrarily wrap logging calls and still expect the wrappers to be skipped by findCaller(). Do you have any suggested mechanism for doing this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap on Windows can mishandle files larger than sys.maxsize
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16778] Logger.findCaller needs to be smarter
Glynn Clements added the comment: Subclassing findCaller() is likely to be a bit hairy for the average user, as it deals with some fairly arcane aspects of Python internals. As for mechanism, maybe allow functions/methods to be registered with the logging module, which would store a referenceto the function's func_code member. findCaller() would check the frame's f_code member against the set of registered functions, and continue up the stack until it found an unregistered function. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16778 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15853] IDLE crashes selecting Preferences menu with OS X ActiveState Tcl/Tk 8.5.12.1
Changes by Ned Deily n...@acm.org: Added file: http://bugs.python.org/file28447/patch_idle_issue_15853.sh ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15853 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15853] IDLE crashes selecting Preferences menu with OS X ActiveState Tcl/Tk 8.5.12.1
Ned Deily added the comment: ActiveTcl 8.5.13 has now been released and, per ActiveState's usual practice of making only the current release and its immediate predecessor publicly downloadable, the ActiveTcl 8.5.11.1 release is no longer available at the URL above, as Vance noted. 8.5.13 includes fixes for other problems including another critical problem introduced in 8.5.12.x (Issue15574). So, until the Python 3.3.1, 3.2.4, and 2.7.4 releases are available (which will include the workarounds for this issue) and if you do not have access to 8.5.11.1, one option is to patch IDLE yourself. To assist in this, I have uploaded a shell script which will attempt to patch the python.org 3.3.0, 3.2.3, and 2.7.3 versions of IDLE if they are installed. While I've tried to make it reasonably foolproof, examine and use at your own risk. Download the attached file from this issue, patch_idle_issue_15853.sh, and run it in a terminal session. It uses sudo so, on most systems, administrator access will be required. See http://www.python.org/download/mac/tcltk/ for more information. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15853 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15574] IDLE crashes using clipboard copy command on OS X with ActiveTcl 8.5.12
Ned Deily added the comment: The problem reported here no longer occurs with Tk 8.5.13. See http://www.python.org/download/mac/tcltk/ for important information about using 8.5.13, including a workaround patch for Issue15853 until Python 3.3.1, 3.2.4, and 2.7.4 are released. -- resolution: - out of date stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15574 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Chris Jerdonek added the comment: I'm attaching an updated patch incorporating David and Benjamin's suggestion. (Thanks a lot for the feedback, by the way.) I also added a test for the help option and refactored to avoid having to use context managers to check sys.argv, sys.stderr, etc. -- Added file: http://bugs.python.org/file28448/issue-15302-4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Chris Jerdonek added the comment: Here is an alternative patch with a cleaner diff (keeping the help-related strings at the top before the import statements). -- Added file: http://bugs.python.org/file28449/issue-15302-5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16770] Selection in IDLE often skips first character
Ned Deily added the comment: Thanks for the additional information. I am now able to reproduce the behavior you observe when using ActiveTcl 8.5.11.1 and also when using the Apple-supplied 8.5.9 in OS X 10.8; presumably, it is also an issue with earlier versions of Cocoa Tk 8.5. The good news is that the behavior is no longer observable with ActiveTcl 8.5.12.x and 8.5.13. I haven't tried to track down what Tk change(s) are responsible. If you do upgrade your version of Tcl/Tk, avoid 8.5.12.x as there were some serious regressions with it. One of those regressions (Issue15853) remains in 8.5.13 and has been worked around by a change in IDLE. Until that change is released in Python 3.3.1, 3.2.4, and 2.7.4, you can install a patch for it in 2.7.3. See http://www.python.org/download/mac/tcltk/ for more details. -- resolution: - out of date stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16770 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Benjamin Peterson added the comment: I posted some review comments. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15302] Use argparse instead of getopt in test.regrtest
Chris Jerdonek added the comment: Thanks. I replied. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16790] provide ability to share tests between int and long tests
New submission from Chris Jerdonek: Currently, adding new int() and long() tests that are common to both requires duplicating the tests in both test_int and test_long, which makes the tests harder to review and maintain and keep in synch. Providing a simple way to share tests between test_int and test_long will simplify adding new tests for issues like issue 16784, issue 16761, and issue 16772. This issue isn't applicable to 3.x because in 3.x test_int and test_long both test int(), so it doesn't make sense to repeat tests in both. -- components: Interpreter Core keywords: easy messages: 178271 nosy: chris.jerdonek priority: normal severity: normal status: open title: provide ability to share tests between int and long tests versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16790] provide ability to share tests between int and long tests
Chris Jerdonek added the comment: Attaching patch. The tests moved to SharedTestCaseMixin in this patch are tests that were very recently added (as part of issue 16045) and that are planned on being added to test_long as part of issue 16784. -- keywords: +patch Added file: http://bugs.python.org/file28450/issue-16790-1-27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
Chris Jerdonek added the comment: I created issue 16790 to allow the sharing of tests between test_int and test_long in 2.7. I don't think issue 16761 and issue 16772 should be prerequisites to this issue though because both issues could benefit from issue 16790 being committed first (since both issues may involve adding tests to test_int and test_long). Also, I don't necessarily think that *all* tests should be shared between test_int and test_long because that refactoring may be too invasive, but certainly the new ones we are considering adding. -- dependencies: +provide ability to share tests between int and long tests ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16790] provide ability to share tests between int and long tests
Serhiy Storchaka added the comment: Why not inherit IntTestCases and LongTest from SharedTestCaseMixin? And looks as CommonSomeTest naming is more common than SharedSomeTest. -- components: +Tests -Interpreter Core nosy: +serhiy.storchaka stage: - patch review type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16743] mmap on Windows can mishandle files larger than sys.maxsize
Serhiy Storchaka added the comment: As Richard explained, this will not break working code, this will break only broken code. Working limit will not be changed, it's sys.maxsize on all platforms. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16743 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
Serhiy Storchaka added the comment: A large part of IntTestCases.test_basic() and LongTest.test_long() can be shared, as a number of smaller tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16784] Int tests enhancement and refactoring
Chris Jerdonek added the comment: Agreed. I just didn't want it to be a requirement of beginning shared tests in case anyone objects to refactoring existing tests in 2.7 -- as opposed to using it for the addition of new tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16784 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16790] provide ability to share tests between int and long tests
Chris Jerdonek added the comment: Good point. New patch coming shortly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16772] int() accepts float number base
Serhiy Storchaka added the comment: But you have if (!PyLong_Check(obase)) check before. Only ints acceptable. The only difference with previous code is that now OverflowError raised for large bases instead of ValueError. int.__round__ doesn't produce OverflowError. In any case the final version of those changes should be applied to 3.2 and 3.3 too (if no one objects). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16772] int() accepts float number base
Chris Jerdonek added the comment: In any case the final version of those changes should be applied to 3.2 and 3.3 too (if no one objects). +1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16790] provide ability to share tests between int and long tests
Chris Jerdonek added the comment: Note that we need to be more careful about checking for duplicate test names now. -- Added file: http://bugs.python.org/file28451/issue-16790-2-27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
