Antoine Pitrou added the comment:
Well, couldn't we simply return a string in that case? We just have to be more
careful than in the patch :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17683
gjwebber added the comment:
Damn, this was my screw up. It was a combination of two things that threw me
off:
1. I was running my (saved) code un-gaurded, but was getting the same error as
with the example code. I thought the problem was elsewhere.
2. As it was just example code, I was
Charles-François Natali added the comment:
Well, couldn't we simply return a string in that case? We just have to be
more careful than in the patch :-)
Probably, provided that:
- s.bind(addr).getsockname() == addr
- it doesn't break existing code :-)
--
Mark Dickinson added the comment:
Note that the patch uses type punning through a union: while GCC allows
this, it's not allowed by ANSI.
I believe it's legal under C99 + TC3.
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
It just highlights the mistake we made calling a builtin module the
same name as a builtin function :)
But shouldn't the highlighting be handled by Pygments?
;)
--
nosy: +pitrou
___
Python tracker
Bohuslav Slavek Kabrda added the comment:
I'm attaching a patch that I'm currently using to solve this. It works, but
it's a bit aggressive - in the sense that it only adds a string to the
sysconfig variable iff this string is not a substring of current variable
value. So it may corrupt some
Richard Oudkerk added the comment:
On 10/04/2013 6:32am, Charles-François Natali wrote:
Richard, IIRC, you said somewhere that FD passing failures on OS X
could be made to work by passing a FD at a time, or something like
that. What do you think of those faiilures?
I think sending one
Antoine Pitrou added the comment:
Indeed, it has been decided that @expectedFailure would only work when applied
to the test methods run by unittest. In that light, the patch is a correct
solution to the issue.
(I don't think expected failures are a very useful concept myself :-))
--
New submission from Edd:
Hi,
I am willing to bet that this has been discussed before, but I don't see any
related bugs.
I have been using Python for a while now as a prototyping language for
scientific applications. Most recently I have been using it for prototype
program analyses.
In this
Antoine Pitrou added the comment:
Apparently the current code is a result of Guido's changeset 980308fbda29 which
changed normal Unix sockets to use unicode objects, but Linux abstract
namespace sockets to use bytes objects.
I don't know if a lot of thought was given to the issue in that
Eli Bendersky added the comment:
Thanks, looks much better now. I left a couple of small comments in the code
review. Other than that, it makes sense to me to update the existing tests to
follow this scheme as well. Thanks!
On a related note, since you've obviously studied the filecmp
Mark Dickinson added the comment:
See the (inconclusive) python-ideas thread starting here:
http://mail.python.org/pipermail/python-ideas/2013-February/019205.html
I'm going to close this issue: the python-ideas mailing list is better suited
for this kind of open-ended discussions (though it
Benjamin Peterson added the comment:
Yes; I won't have time for a few days, though.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
New submission from Masato HASHIMOTO:
In Doc/using/unix.rst, the following link is broken:
31: http://linuxmafia.com/pub/linux/suse-linux-internals/chapter35.html
(See also for OpenSuse users)
--
assignee: docs@python
components: Documentation
messages: 186491
nosy: docs@python,
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17685
___
___
Python-bugs-list mailing
Georg Brandl added the comment:
Serhiy, do you want to fix this also in 3.2? I'll roll a brown-paper-bag
release of 3.2 and 3.3 together with 2.7.5.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17666
Georg Brandl added the comment:
I guess I will join with 3.2 and 3.3 for #17666.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Ned Deily added the comment:
Perhaps we should hold off for a week or two to see if any other critical
problems show up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Roundup Robot added the comment:
New changeset 1410b7790de6 by Giampaolo Rodola' in branch 'default':
Fix issue #17675: make socket repr() provide local and remote addresses (if
any).
http://hg.python.org/cpython/rev/1410b7790de6
--
nosy: +python-dev
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17675
Georg Brandl added the comment:
Yes, although the new releases will get the standard rc period anyway.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Guido van Rossum added the comment:
Sorry, I don't think I have anything to add.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17683
___
___
Ezio Melotti added the comment:
ISTM that we were trying to moving towards an AST optimizer and away from the
peephole, so I'm not sure it's a good idea to add more optimization to it.
#11549 has patches about the AST optimizer.
--
nosy: +benjamin.peterson, rhettinger
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
versions: +Python 3.4 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17607
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17620
___
___
Python-bugs-list
Giampaolo Rodola' added the comment:
Note that if we pass bytes to bind(), getsockname() will return str anyway:
s = socket.socket(socket.AF_UNIX)
s.bind(b'hello')
s.getsockname()
'hello'
That said, it seems more consistent to me to return str also in case of
abstract namespace.
As per:
Ronald Oussoren added the comment:
The trigger for the customizations is probably too specific. The primary reason
for a having a check that's more specific than 'if sys.platform == darwin' is
to avoid using the customizations when someone uses an X11 build of Tk and I
didn't know (and still
New submission from Andreas Kloeckner:
This line in the _struct module references a PyStructType that isn't
declared anywhere. This is only apparent when the file is compiled without
-DNDEBUG.
http://hg.python.org/cpython/file/1410b7790de6/Modules/_struct.c#l43
--
components:
Roundup Robot added the comment:
New changeset 54532684dbed by Ezio Melotti in branch '2.7':
#17635: fix wrong function name in multiprocessing docs.
http://hg.python.org/cpython/rev/54532684dbed
--
nosy: +python-dev
___
Python tracker
Mark Dickinson added the comment:
Isn't it declared on line 12?
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17687
___
Roundup Robot added the comment:
New changeset 5d39d459b90d by Ezio Melotti in branch '3.3':
#17635: fix wrong function name in multiprocessing docs.
http://hg.python.org/cpython/rev/5d39d459b90d
New changeset 1a935e932152 by Ezio Melotti in branch 'default':
#17635: merge with 3.3.
Ezio Melotti added the comment:
Fixed, thanks for the report!
--
assignee: docs@python - ezio.melotti
nosy: +ezio.melotti
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
versions: +Python 3.4
___
Python
Ezio Melotti added the comment:
The What's new is already mentioned briefly in
http://docs.python.org/devguide/committing.html#news-entries. Would it be
enough to rephrase that part and clarify that committers are expected to update
it?
Another option is to add a new item to make patchcheck
Ezio Melotti added the comment:
I left a review. To test it you could try to reproduce the steps described in
the first message and see what happens.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Éric Araujo added the comment:
You can always use a ref role instead of func. func tries to find a module,
class or function in the global Sphinx index, but ref lets you link to one
specific target (see the table at the top of library/functions.rst for an
example).
--
Tomasz J. Kotarba added the comment:
The example I gave was the simplest possible to illustrate my point but yes,
you are correct, I often match the whole string as I do recursive matches. I
do use non-capturing groups but they would not solve the problem I talked
about. Anyway, I had
Andreas Kloeckner added the comment:
Whoops. I'm an idiot. Forget I said anything.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17687
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: - committed/rejected
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17641
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti -testusernad
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2771
___
___
Andreas Kloeckner added the comment:
(Forgot to say: sorry.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17687
___
___
Python-bugs-list
Brett Cannon added the comment:
Yep, I think expanding that would be fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17637
___
___
Changes by Brett Cannon br...@python.org:
--
resolution: - invalid
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17687
___
___
Python-bugs-list
New submission from Daniel Müllner:
The C API documentation has a code snippet with a sample implementation of a
rich comparison function here:
http://docs.python.org/3.3/extending/newtypes.html#object-comparison
The function is declared as
static int
newdatatype_richcmp(PyObject *obj1,
Roundup Robot added the comment:
New changeset 340a12c18b7f by R David Murray in branch 'default':
#17487: wave.getparams now returns a namedtuple.
http://hg.python.org/cpython/rev/340a12c18b7f
--
nosy: +python-dev
___
Python tracker
R. David Murray added the comment:
Thanks, Claudiu.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17487
Roundup Robot added the comment:
New changeset 172f825d7fc9 by Ezio Melotti in branch '3.3':
#12820: add tests for the xml.dom.minicompat module. Patch by John Chandler
and Phil Connell.
http://hg.python.org/cpython/rev/172f825d7fc9
New changeset f675083b2894 by Ezio Melotti in branch
Ezio Melotti added the comment:
Fixed, thanks for the patches!
--
assignee: - ezio.melotti
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
type: behavior - enhancement
versions: +Python 3.4
___
Python tracker
Changes by Gregory P. Smith g...@krypto.org:
--
priority: high - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +brian.curtin
stage: - patch review
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: +benjamin.peterson, larry
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17666
___
Brian Curtin added the comment:
Could you also propose places in the test to use this? If we're going to add
it, we should use it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17652
___
Ezio Melotti added the comment:
See #11957.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17663
___
___
Python-bugs-list mailing list
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
type: - enhancement
versions: +Python 3.4 -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11957
___
Ezio Melotti added the comment:
Last patch LGTM (except a couple of minor whitespace issues).
Tom, can you sign the contributor agreement
(http://www.python.org/psf/contrib/contrib-form/)?
--
stage: patch review - commit review
versions: -Python 3.2
Ezio Melotti added the comment:
Patch attached.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file29764/issue17637.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17637
jed.ludlow added the comment:
I can confirm that the approach suggested in msg148674 resolves this issue for
Python 2.7.3 (32-bit Python running on 64-bit Windows 7). For a standard 2.7.3
install, simply replacing wininst-9.0.exe in the command sub-directory of
distutils with the patched
Kyle Roberts added the comment:
Ah that's the type of thing I was looking for, thanks Éric. I saw the
underscored reference in functions.rst last night but figured it was just a
local file link. I'll have a patch available later today. Thanks again.
--
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17666
___
Brett Cannon added the comment:
significative - significant
I would also toss in something like or not backwards-compatible so people
know they should mention anything that will require code change to stay
backwards-compatible.
--
___
Python
New submission from Zachary Ware:
Here's a patch for test_tarfile.py discovery.
There are a couple of inheritance issues resolved; CommonReadTest (and its
children, MiscReadTest and StreamReadTest) are changed simply to avoid running
the tests in CommonReadTest on their own--they pass, but
New submission from Zachary Ware:
Just inheritance issues in this one. The patch removes _BaseYearTest as its
only use was as a unittest.TestCase subclass to inherit from, which caused the
discovery issues.
--
components: Tests
files: test_time_discovery.diff
keywords: patch
New submission from Zachary Ware:
Inheritance issues again. This one has some magic in test_main to create the C
and Python tests programmatically which I felt was best left alone, so the
patch simply converts test_main into a load_tests which ignores its arguments.
--
components:
New submission from Zachary Ware:
test_sqlite.py simply imports and runs tests from sqlite3.test, the patch
converts test_main to load_tests to do the same.
--
components: Tests
files: test_sqlite_discovery.diff
keywords: patch
messages: 186528
nosy: brett.cannon, ezio.melotti,
Giacomo Alzetta added the comment:
I can't find any mention of this behaviour in python3's documentation, nor any
reference to ftell(). Is it only well hidden or was it deleted by accident?
--
nosy: +bakuriu
status: pending - open
___
Python tracker
Roundup Robot added the comment:
New changeset 35cb75b9d653 by Benjamin Peterson in branch '3.3':
don't run frame if it has no stack (closes #17669)
http://hg.python.org/cpython/rev/35cb75b9d653
New changeset 0b2d4089180c by Benjamin Peterson in branch 'default':
merge 3.3 (#17669)
Zachary Ware added the comment:
Ping.
Version 4 still applies cleanly, and with issue16935 fixed, it works properly.
The fix for test_socket is looking like it could use the ReapedSuite from this
patch, so would anyone mind looking at this one again and committing if it's
qualified?
paul j3 added the comment:
Further observations:
parser.add_subparsers() accepts a 'dest' keyword arg, but not a 'required' one.
Default of 'dest' is SUPPRESS, so the name does not appear in the Namespace.
Changing it to something like 'command' will produce an entry, e.g.
Changes by Ralf Schmitt python-b...@systemexit.de:
--
nosy: +schmir
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1208304
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 87331820569a by doko in branch '2.7':
- Issue #17086: Search the include and library directories provided by the
http://hg.python.org/cpython/rev/87331820569a
--
___
Python tracker rep...@bugs.python.org
Matthias Klose added the comment:
the call to add_gcc_paths() wasn't backported.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17086
___
___
Berker Peksag added the comment:
Is there a chance to get this into 3.3.2?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16163
___
New submission from STINNER Victor:
Attached patch modify CJK decoders to use the _PyUnicodeWriter API. It adds a
new _PyUnicodeWriter_WriteChar() function.
Performances are not optimal: the overallocation is not well controlled. I will
try to adjust it later (if this patch is accepted).
New submission from STINNER Victor:
The _PyUnicodeWriter API is used in many functions to create Unicode strings,
especially decoders. Performances are not optimal: it is not possible to
specify the minimum length of the buffer if the overallocation is disabled. It
may help #17693 for
Tom Pinckney added the comment:
Great!
Just signed the contributor agreement.
On Apr 10, 2013, at 1:06 PM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti added the comment:
Last patch LGTM (except a couple of minor whitespace issues).
Tom, can you sign the contributor
Kazuhiro Yoshida added the comment:
I am trying to use SSLContext.set_servername_callback in my program but when a
callback is set, it seems that connecting to the server without providing a
server name causes a segmentation fault. (e.g. 'openssl s_client -connect
localhost:443 -servername
Kyle Roberts added the comment:
So the :ref: keyword helps and creates a link, but it has the unfortunate side
effect of adding different markup and style. I've attached two images to
illustrate the differences. I couldn't find a way in the Sphinx or reST
documentation to force it to style
Changes by Kyle Roberts roberts...@gmail.com:
Added file: http://bugs.python.org/file29772/diff_style_markup.PNG
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17661
___
Daniel Black added the comment:
nice patch. Thanks for finding the bug. I like the solution with test case.
Just needs a small enhancement of documention to ensure other users expect this
behaviour.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 5f8fe382f9db by Senthil Kumaran in branch '3.3':
#5609 - test_urllib coverage for url2pathname and pathname2url. Patch
http://hg.python.org/cpython/rev/5f8fe382f9db
New changeset 7b3f1c6a67d9 by Senthil Kumaran in branch 'default':
merge from 3.3
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5609
Roger Serwy added the comment:
Attached is the updated patch to include Ezio's review. Thanks Ezio!
--
Added file: http://bugs.python.org/file29773/patch_2and3_rev1.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Roger Serwy added the comment:
LGTM.
--
nosy: +roger.serwy
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17670
___
Roger Serwy added the comment:
Serhiy, don't worry. There's still plenty of broken found in IDLE.
Antoine, may I modify site.py with site_reversion.patch? If not, then I can
include a workaround in IDLE.
--
___
Python tracker rep...@bugs.python.org
Roger Serwy added the comment:
Attached is a refreshed patch for tip.
Supporting Ctrl+Z and Enter on Windows would be problematic as I discussed
earlier. We could introduce a timer to make sure Enter is pressed within a
short window after Ctrl+Z.
If someone wants to make a patch for that,
New submission from Ronald Oussoren:
The _sysconfig module contains the definitions for sysconfig.get_config_var and
is created during python's build.
The definitions in _sysconfig.py for #define macros redefined in pymacconfig.h
are wrong when building a universal build of Python (fat
85 matches
Mail list logo
