Benjamin Peterson added the comment:
Modulo earlier comments, I think it looks good to land.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18112
___
Eduardo Robles Elvira added the comment:
Sure, I will fill it out. But is it required?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18321
___
New submission from Eduardo Robles Elvira:
A TarFile object constructor accepts a fileobj argument. When this argument is
set and it has a mode property, tarfile._mode is blindly copied from there.
Otherwise, mode is set using the mode argument in the constructor.
This usually works, but in
Changes by Eduardo Robles Elvira edu...@gmail.com:
Removed file: http://bugs.python.org/file31061/gzip.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18575
___
Eduardo Robles Elvira added the comment:
Fixing gzip.patch, it was using basestring (python2) instead of str
--
Added file: http://bugs.python.org/file31062/gzip.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18575
Roundup Robot added the comment:
New changeset 2aa6c1e35b8a by Nick Coghlan in branch 'default':
Close #13266: Add inspect.unwrap
http://hg.python.org/cpython/rev/2aa6c1e35b8a
--
nosy: +python-dev
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Drekin added the comment:
Is there any chance the API will be added and used by python.exe?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17620
___
Roundup Robot added the comment:
New changeset 203a77e74aa7 by Nick Coghlan in branch 'default':
Close #15494: test.support is now a package rather than a module
http://hg.python.org/cpython/rev/203a77e74aa7
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
status:
Roundup Robot added the comment:
New changeset 0b7ed24f7d33 by Nick Coghlan in branch '3.3':
Issue #15494: test.support is now a package rather than a module
http://hg.python.org/cpython/rev/0b7ed24f7d33
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +orsenthil
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18574
___
___
Roundup Robot added the comment:
New changeset 4f0034477ba9 by Nick Coghlan in branch '3.3':
Close #15415: Factor out temp dir helpers to test.support
http://hg.python.org/cpython/rev/4f0034477ba9
New changeset b20a10c97e08 by Nick Coghlan in branch 'default':
Merge #15415 from 3.3
New submission from Peter Santoro:
The attached proposed lru_timestamp function provides developers with more
control over how often lru_cache entries are refreshed. Doc string follows:
def lru_timestamp(refresh_interval=60):
Return a timestamp string for @lru_cache decorated functions.
New submission from Nick Coghlan:
tests.script_helper provides various utilities for sensibly testing scripts in
a subprocess. It isn't easy for CPython developers to discover, since it is
isn't documented and the file is mixed in with actual tests in the main test
directory.
As discussed in
New submission from Nick Coghlan:
test.bytecode_helper provides various utilities for sensibly testing bytecode
generation. It isn't easy for CPython developers to discover, since it isn't
documented and the file is mixed in with actual tests in the main test
directory.
As discussed in
Nick Coghlan added the comment:
As noted in #18576 and #18578, I'd like for these relocation patches to include
the addition of documentation for the submodule in Doc/library/test.rst
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Also, now that test.support is a subpackage, the helper should be a submodule
of that (test.support.package_helper) rather than directly in the test
directory.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
test.support is now a subpackage in both 3.3 and default, but
test.support.package_helper still needs to be created (see comments on #15403)
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
New submission from Christian Heimes:
Coverity Scan may have found an issue in listobject's merge code. I'm not
familiar with the code so I don't know if ssb.value can be NULL here.
3. Condition ssb.values != NULL, taking false branch
4. var_compare_op: Comparing ssb.values to null implies
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: ncoghlan -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18578
___
___
Python-bugs-list
New submission from Alexey Borzenkov:
A user reported getting a TypeError when building greenlet on OS X with Python
2.7.4 built with homebrew. The TypeError happens because we subclass build_ext
so before building extensions we can change compiler's compiler_so. The problem
is that instead
Peter Santoro added the comment:
I updated my proposed lru_timestamp function with the following changes:
1) restricted refresh_interval to int type
2) updated doc string
Updated doc string follows:
def lru_timestamp(refresh_interval=60):
Return a timestamp string for @lru_cache
Alexey Borzenkov added the comment:
I was unaware of this issue (which homebrew works around incorrectly), and
because of this I created issue 18580. The problem is indeed with unicode
strings which are coming from _read_output in _osx_support. This is probably
because this code was merged
Alexey Borzenkov added the comment:
Also, to reproduce it you have to temporarily move away your /usr/bin/cc and
/usr/bin/clang, which then triggers the affected code path.
--
___
Python tracker rep...@bugs.python.org
Changes by Ralf Schmitt python-b...@systemexit.de:
--
nosy: +schmir
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18071
___
___
Python-bugs-list
Changes by Ralf Schmitt python-b...@systemexit.de:
--
nosy: +schmir
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18580
___
___
Python-bugs-list
Ned Deily added the comment:
Thanks for the analysis. I'm consolidating this issue with Issue18580.
--
assignee: eric.araujo - ned.deily
nosy: +ned.deily
resolution: - duplicate
stage: - committed/rejected
superseder: - _osx_support compiler_fixup
Changes by Ned Deily n...@acm.org:
--
nosy: +lars.gustaebel
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18575
___
___
Python-bugs-list mailing
New submission from Vajrasky Kok:
There are two classes in Lib/test/test_abc.py, which are TestABC and
TestLegacyAPI.
Only TestABC is being unit tested.
Beside that TestLegacyAPI class has one duplicate test, which is
test_abstractmethod_integration with TestABC class.
--
New submission from Christian Heimes:
The patch is a proof of concept for PBKDF2 support for the OpenSSL variant of
hashlib. It's a thin wrapper around PKCS5_PBKDF2_HMAC() and is deliberately
designed as low level API with bytes and input and output types. High level
wrappers can do the
Changes by Christian Heimes li...@cheimes.de:
Added file: http://bugs.python.org/file31067/pbkdf2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file31066/pbkdf2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Christian Heimes added the comment:
I guess I have to revise my patch and go throw Windows' crypto lookup
functions...
Automatic CA root certificate updates on Windows
http://netsekure.org/2011/04/automatic-ca-root-certificate-updates-on-windows/
--
Terry J. Reedy added the comment:
Based on recent python-list posts, there is also 'break is bad' propaganda
going around. Perhaps we should say that loop-and-a-half with break is
preferred (or at least equally acceptable) to repeating code.
while True:
value = getvalue()
if not
Antoine Pitrou added the comment:
Please use the y* format, not y#.
Also, I would lower-case pbkdf2, just as we already lower-case md5, sha1,
etc.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file31068/050c6d089164.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18112
___
Antoine Pitrou added the comment:
Updated patch with the suggested changes, apart from a couple stylistic ones
(waiting for your answer on these ones).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18112
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
nosy: +rhettinger
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18577
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Multivolume support in tarfile module
nosy: +serhiy.storchaka
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18575
Drekin added the comment:
Is there a chance this will be fixed at least in Python 4?
--
nosy: +Drekin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11619
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18563
___
Serhiy Storchaka added the comment:
Based on recent python-list posts, there is also 'break is bad' propaganda
going around. Perhaps we should say that loop-and-a-half with break is
preferred (or at least equally acceptable) to repeating code.
Sometimes yet one alternative can be used
Guido van Rossum added the comment:
OK, forget I said anything about exceptions. The language in Nick's patch is
fine.
Regarding break is bad, while I agree with Terry's recommendation, I think
saying anything about this would be overreaching the scope of a style guide.
We shouldn't give
Roundup Robot added the comment:
New changeset c57b2a344097 by Terry Jan Reedy in branch '3.3':
Issue #18441: Remove check from test_text.py in 3.3,4 (already done in 2.7).
http://hg.python.org/cpython/rev/c57b2a344097
--
___
Python tracker
Terry J. Reedy added the comment:
-def temp_cwd(name='tempcwd', quiet=False, path=None):
+def temp_cwd(name='tempcwd', quiet=False):
Since this parameter removal was pushed, the Windows buildbots consistently
have this new error in this Windows-only test.
ERROR: test_empty
Nick Coghlan added the comment:
with statements are good, basically.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18472
___
___
Raymond Hettinger added the comment:
Nick, +1 from me if you want to make your edits and wrap this one up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18472
___
Terry J. Reedy added the comment:
Some comments on patch 6:
1. tearDownClass was omitted, resulting in boxes left on the screen, at least
when running in Idle with win7. I added this to the README.
I am also getting messages like warning: callback failed in WindowList class
Damien M Calloway added the comment:
I believe I have isolated the bug - I added a blank string to the SMALL TEST
DATA list, since empty strings will not compress. Test now fails on lines 645
and 663 when extract and extract_all assertions fail. This appears to
replicate the issue reported.
R. David Murray added the comment:
Yes, this is a very good point. (And your passing test is worthwhile, you are
correct.)
People are expected to be able to write handlers, so clearly the timeout API
needs to be documented, if for no other reason than to keep a handler writer
from
Guido van Rossum added the comment:
Raymond Hettinger added the comment:
Nick, +1 from me if you want to make your edits and wrap this one up.
+1 from me too.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18472
Changes by Alexander Belopolsky alexander.belopol...@gmail.com:
--
nosy: +belopolsky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18538
___
___
New submission from Terry J. Reedy:
Writing tests for FormatParagraph.py #18226 revealed that it could use some
improvements.
At minimum, some for format_paragraph should probably be replaced with
textwrap.wrap (or the class) in order to handles double spacing after
sentences.
Terry J. Reedy added the comment:
Patch attached with current version. I noted in a comment that we should
probably replace some of format_paragraph with textwrap.wrap.
The find_paragraph test works fine with the current text mock. I split one test
method and will probably do more.
It could
Roundup Robot added the comment:
New changeset a76693942de3 by Nick Coghlan in branch '3.3':
Attempt to fix #15415 on Windows
http://hg.python.org/cpython/rev/a76693942de3
New changeset b14308524cff by Nick Coghlan in branch 'default':
Merge #15415 Windows buildbot change from 3.3
Nick Coghlan added the comment:
I did see the Windows buildbot failure, but stopped scanning the log once I saw
the intermittent test_signal failure :P
With the more granular API, test_startfile is a better fit for
support.change_cwd, so we'll see how that goes on the Windows buildbots.
55 matches
Mail list logo
