[issue19026] OrderedDict should not accept dict as parameter

2013-09-15 Thread Raymond Hettinger
Raymond Hettinger added the comment: An OrderedDict is a dict subclass and needs to accept the same inputs as dict methods. This is a guaranteed API and not a bug. It is not the OrderedDict's fault if you supply an unordered input. It can't add order after the fact. -- assignee: ->

[issue16038] ftplib: unlimited readline() from connection

2013-09-15 Thread A.M. Kuchling
A.M. Kuchling added the comment: For 2.6 I'll make a revised version of Giampaolo's patch that doesn't add a new exception class. Rationale: Adding a new exception class changes the API of the module, which we'd like to avoid. If someone is writing 2.6 code that wants to catch this excepti

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Patch looks great, thanks Andrew. All tests pass. Feel free to commit to the 2.6 branch along with a NEWS file entry. -- ___ Python tracker

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg197788 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is not important in the context of this issue, but readline(0) is blocked and returns 1-character string. Move the length check above self.sslobj.read(1). For readability you can also move the chr != "\n" inside the loop: while size is None

[issue19026] OrderedDict should not accept dict as parameter

2013-09-15 Thread anatoly techtonik
New submission from anatoly techtonik: http://stackoverflow.com/questions/15733558/python-ordereddict-not-keeping-element-order I wonder why OrderedDict accepts dict as parameter in a first place? OD is used when order is important and if plain dict is supplied, the order is lost. >>> d =

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is not important in the context of this issue, but readline(0) is blocked and returns 1-character string. Move the length check above self.sslobj.read(1). For readability you can also move the chr != "\n" inside the loop: while size is None

[issue18704] IDLE: PEP8 Style Check Integration

2013-09-15 Thread Raymond Hettinger
Raymond Hettinger added the comment: [TJR] > I am opposed to this specific proposal and > think this issue should be closed. [Ramchandra Apte] > Agree with Terry Reedy. [R. Jayakrishnan] > Better to close this issue then ... I agree as well. -- resolution: -> rejected status: open -

[issue17764] Support http.server passing bind address via commend line argument

2013-09-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: Found the patch suitable and had addressed Berker Pesag's review comments too. Thanks for contributing, Malte Swart and thanks for submitting the contributor agreement too. -- nosy: +orsenthil resolution: -> fixed stage: patch review -> committed/rej

[issue17764] Support http.server passing bind address via commend line argument

2013-09-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset a248655c8261 by Senthil Kumaran in branch 'default': Expose --bind argument for http.server, enable http.server to bind to a user http://hg.python.org/cpython/rev/a248655c8261 -- nosy: +python-dev ___ Pyt

[issue19025] Deleting attribute of Enum gives misleading error message

2013-09-15 Thread Ethan Furman
Changes by Ethan Furman : -- assignee: -> ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread A.M. Kuchling
A.M. Kuchling added the comment: Here's a final proposed version of the patch for 2.6 that adds a test. Changes made: * code now raises SMTPResponseException instead of a new SMTPLineTooLong exception; bwarsaw deemed that adding a new exception class was changing the module API. * we looked

[issue19025] Deleting attribute of Enum gives misleading error message

2013-09-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue16040] nntplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Any more thoughts on this bug w.r.t. 2.6.9? It seems that without a patch for any version of Python, and with 2.6.9 coming soon, a fix for this just won't make it into 2.6.9. That doesn't bother me too much, and I'm willing to just knock this off the 2.6.

[issue19025] Deleting attribute of Enum gives misleading error message

2013-09-15 Thread R. David Murray
R. David Murray added the comment: Doesn't this confusion (here and in 19011) arise from the fact that the enum class does *not* have CUTE_CAT attribute? That is, the error message is correct, but surprising. Because, frankly, Enums are surprising in many ways ;) -- nosy: +r.david.mu

[issue15363] Idle/tkinter ~x.py 'save as' fails. closes idle

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +Tkinter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread A.M. Kuchling
A.M. Kuchling added the comment: The patch requires a little adjusting to apply against 2.6. -- nosy: +akuchling Added file: http://bugs.python.org/file31772/smtplib-2.6.patch ___ Python tracker ___

[issue17104] Tk() not defined in Tkinter module

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +Tkinter -None status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailin

[issue16043] xmlrpc: gzip_decode has unlimited read()

2013-09-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue18704] IDLE: PEP8 Style Check Integration

2013-09-15 Thread R. Jayakrishnan
R. Jayakrishnan added the comment: Thanks for showing great interest on this idea. As usual, it seems this will going to be another nice project with IDLE for me. Better to close this issue then, and create an appropriate initiation with the suggested points(preferring a commencement by core de

[issue1565525] tracebacks eat up memory by holding references to locals and globals when they are not wanted

2013-09-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Ping! I'd like to change the function name to clear_frames() and then > commit this. Antoine or anyone, want to disagree with using > clear_frames() as the name? clear_frames() sounds fine to me :-) -- ___ Python

[issue19025] Deleting attribute of Enum gives misleading error message

2013-09-15 Thread Vajrasky Kok
New submission from Vajrasky Kok: >>> from enum import Enum >>> class MyPet(Enum): ... CUTE_CAT = 1 ... VIGOROUS_DOG = 2 ... UGLY_BLOBFISH = 3 ... PROMISCUOUS_BONOBO = 4 ... def spam(cls): pass ... >>> del MyPet.CUTE_CAT Traceback (most recent call last): File "", line 1, in Attribu

[issue1565525] tracebacks eat up memory by holding references to locals and globals when they are not wanted

2013-09-15 Thread A.M. Kuchling
A.M. Kuchling added the comment: Ping! I'd like to change the function name to clear_frames() and then commit this. Antoine or anyone, want to disagree with using clear_frames() as the name? -- ___ Python tracker

[issue19024] Document asterisk (*), splat or star operator

2013-09-15 Thread Ezio Melotti
Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti stage: -> needs patch type: crash -> enhancement versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.5 ___ Python tracker _

[issue19024] Document asterisk (*), splat or star operator

2013-09-15 Thread anatoly techtonik
anatoly techtonik added the comment: tag:easy -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue1602] windows console doesn't print or input Unicode

2013-09-15 Thread Drekin
Drekin added the comment: Glenn Linderman: Yes I have built on what the others learned. For your question, I made it and tested it in Python 3.3, it should also work in 3.4 and what I've tried, it actually works. As Terry J. Reedy says you can just load the module and enable the streams. I do

[issue19024] Document asterisk (*), splat or star operator

2013-09-15 Thread anatoly techtonik
New submission from anatoly techtonik: I'd say this is a critical documentation bug that leads to head bang when you try to figure out what does '*' in code means. This bug is two fold: 1. Define a dedicated place in documentation for '*' operator with examples. I propose http://docs.python.or

[issue8010] tkFileDialog.askopenfiles crashes on Windows 7

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as a duplicate of issue5712. -- nosy: +serhiy.storchaka status: open -> pending ___ Python tracker ___ __

[issue1602742] itemconfigure returns incorrect text property of text items

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch for issue19020 fixes this issue. -- nosy: +serhiy.storchaka versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker _

[issue6225] Fixing several minor bugs in Tkinter.Canvas and one in Misc._configure

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also #19020. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue18877] tkinter askopenfilenames does not work in Windows library folder

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also #3015 and #5712. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3015] tkinter with wantobjects=False has been broken for some time

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as issue18877 is related to this. I have proposed for it a little different patch than first Guilherme's patch. As for removing wantobjects, we perhaps can do this only in 3.4. -- nosy: +serhiy.storchaka versions: +Python 3.3, Python 3.4 -Pytho

[issue12558] Locale-dependent exception for float width argument to Tkinter widget constructor

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a bug in Tk. It uses locale-agnostic Tcl_GetDoubleFromObj() in most places, but in some places (especially in canvas) it uses locale-dependent strtod(). And that is even worse, strtod() is used even for parsing comma-delimited floats (@-indices). We

[issue5712] tkinter - askopenfilenames returns string instead of tuple in windows 2.6.1 release

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is it still reproducible on 2.7? -- nosy: +serhiy.storchaka versions: -Python 2.6 ___ Python tracker ___ _

[issue19023] ctypes docs: Unimplemented and undocumented features

2013-09-15 Thread Sye van der Veen
Changes by Sye van der Veen : -- keywords: +patch Added file: http://bugs.python.org/file31769/75843d82f6cf.diff ___ Python tracker ___ __

[issue19023] ctypes docs: Unimplemented and undocumented features

2013-09-15 Thread Sye van der Veen
New submission from Sye van der Veen: In the ctypes documentation, there's mention of a BigEndianUnion/LittleEndianUnion that isn't actually implemented, and the "Arrays and pointers" section just reads "Not yet written". The attached patch adds the (Big|Little)EndianUnion classes (with tests)

[issue12558] Locale-dependent exception for float width argument to Tkinter widget constructor

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +gpolo, serhiy.storchaka, terry.reedy stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.3 ___ Python tracker ___ _

[issue13519] Tkinter rowconfigure and columnconfigure functions crash if minsize, pad, or weight is not None

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think this was fixed in issue16809. -- nosy: +serhiy.storchaka status: open -> pending ___ Python tracker ___ __

[issue6181] Tkinter.Listbox several minor issues

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker ___ _

[issue3405] Add support for the new data option supported by event generate (Tk 8.5)

2013-09-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list

[issue18877] tkinter askopenfilenames does not work in Windows library folder

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This patch should fix the issue (as many other issues). -- assignee: -> serhiy.storchaka keywords: +patch stage: needs patch -> patch review versions: +Python 3.4 Added file: http://bugs.python.org/file31768/tkinter_Tkapp_CallResult.patch ___

[issue18877] tkinter askopenfilenames does not work in Windows library folder

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I guess tkinter.wantobjects is 0 for you? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Py

[issue18950] Miscellaneous fixes for the sunau module

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Update patch addresses Ezio's comment. -- Added file: http://bugs.python.org/file31767/sunau.patch ___ Python tracker ___

[issue19014] Allow memoryview.cast() for empty views

2013-09-15 Thread Stefan Krah
Stefan Krah added the comment: I agree that this cast should work. Perhaps disallowing zero strides is enough -- I have to look at this more closely though. -- ___ Python tracker ___

[issue19020] Regression: Windows-tkinter-idle, unicode, and 0xxx filename

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are two methods: splitlist() and split(). The splitlist() method splits only one level and always returns a tuple (even if it is empty or one-element). The split() method splits recursive and can returns a string if it is not splittable. I.e. result ty

[issue18994] Inside fcntl module, we does not check the return code of all_ins function

2013-09-15 Thread Vajrasky Kok
Vajrasky Kok added the comment: Charles-François Natali, sorry I just noticed Ezio's comment. The all_ins function return -1 on failure and 0 on success. I use this form: if (all_ins(m)) return NULL; because I follow the example in Modules/posixmodule.c. If this form: if

[issue18994] Inside fcntl module, we does not check the return code of all_ins function

2013-09-15 Thread Charles-François Natali
Charles-François Natali added the comment: I noticed this when converting the code to use PyModule_AddIntMacro(). Vajrasky, did you see Ezio's review on http://bugs.python.org/review/18994/#ps9258 ? -- ___ Python tracker

[issue19022] Improve handling of type.__abstractmethods__ descriptor

2013-09-15 Thread Nick Coghlan
New submission from Nick Coghlan: Issue 10006 pointed out that attempting to access object.__abstractmethods__ raises AttributeError. The solution was to ensure type.__abstractmethods__ *also* raises AttributeError. This is thoroughly confusing, since the name is clearly visible in the output

[issue19022] Improve handling of type.__abstractmethods__ descriptor

2013-09-15 Thread Nick Coghlan
Changes by Nick Coghlan : -- nosy: +Yaroslav.Halchenko, benjamin.peterson, daniel.urban ___ Python tracker ___ ___ Python-bugs-list ma

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: As Victor suggested in msg136939 we can use a class attribute. This technique is used in some other places in the stdlib (perhaps for other purposes). For example in subprocess.Handle. We should check all defined __del__-s in stdlib and fix them all if they

[issue14927] add "Do not supply 'int' argument" to random.shuffle docstring

2013-09-15 Thread Georg Brandl
Georg Brandl added the comment: I would propose a leading underscore for these methods; they should make it clear to the user that the parameter is meant to be "private". With this line in the docstring, I would wonder "Why is the argument there in the first place?!" (because most people don't

<    1   2