[issue19256] Optimize marshal format and add version token.

2013-10-13 Thread STINNER Victor
STINNER Victor added the comment: Good idea to add a version. But it should not be a token, but a mandatory header at the beginning. For example, 16 unsigned bits at the beginning. Many file formats use a magic key, like MZ for Windows executable or GIF for GIF pictures. What do you think of

[issue19256] Optimize marshal format and add version token.

2013-10-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I actually agree with Kristjan that an opcode is the least disruptive choice here. I also agree it's useful if we want to be able to evolve the protocol without being tied by backwards compatibility constraints. --

[issue19256] Optimize marshal format and add version token.

2013-10-13 Thread STINNER Victor
STINNER Victor added the comment: I actually agree with Kristjan that an opcode is the least disruptive choice here. Does you mean that data serialized with python 3.3 can be read with python 3.4? But not the opposite (version token unknown in Python 3.3)? --

[issue19256] Optimize marshal format and add version token.

2013-10-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I actually agree with Kristjan that an opcode is the least disruptive choice here. Does you mean that data serialized with python 3.3 can be read with python 3.4? But not the opposite (version token unknown in Python 3.3)? Yes, indeed. I'm not sure it's

[issue19027] undefined symbol: _PyParser_Grammar

2013-10-13 Thread Ned Deily
Ned Deily added the comment: BTW, this can be worked around (for non cross-builds at least) by running make touch on the source directory, e.g.: make -C python/src -f python/build/Makefile touch But it should be fixed. Doko? -- ___ Python

[issue4965] Can doc index of html version be separately scrollable?

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3bb34d370871 by Ezio Melotti in branch '3.3': #4965: Implement intelligent scrolling of the sidebar in the docs. http://hg.python.org/cpython/rev/3bb34d370871 New changeset 8d916ea12efb by Ezio Melotti in branch 'default': #4965: merge with 3.3.

[issue4965] Can doc index of html version be separately scrollable?

2013-10-13 Thread Ezio Melotti
Ezio Melotti added the comment: I committed the patch on 3.3/3.x. I'm willing to port the patch on 2.7 too, however sidebar.js is not in Doc/tools/sphinxext/static/ but in Doc/tools/sphinx/themes/default/static/, which is not under version control. How do you suggest to proceed? --

[issue19252] Enum.py : Enum.__new__() : Test Coverage

2013-10-13 Thread Ethan Furman
Ethan Furman added the comment: I'm not sure what you are talking about. Here's the code: try: if value in cls._value2member_map_: return cls._value2member_map_[value] except TypeError: # not there, now do long search -- O(n) behavior for member in

[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19176 ___ ___

[issue19082] Lib/xmlrpc/client.py demo code points to the dead server

2013-10-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch is good. I think, it is better to include this information in documentation too. Please let me know if this suitable, I shall go ahead committing this. (With credits to Vajrasky Kok) -- assignee: - orsenthil nosy: +orsenthil versions:

[issue19249] Enumeration.__eq__

2013-10-13 Thread Ethan Furman
Ethan Furman added the comment: Here's the current __eq__ method: def __eq__(self, other): if type(other) is self.__class__: return self is other return NotImplemented It is, in fact, using identity and not value equality. I'm thinking we should either remove

[issue11763] assertEqual memory issues with large text inputs

2013-10-13 Thread Ezio Melotti
Ezio Melotti added the comment: Attached an updated patch that addresses Serhiy comments. The tests in the previous patch have been committed already, so this might need new tests. The first problem I mentioned in msg134530 has been reported in #19217. -- Added file:

[issue18606] Add statistics module to standard library

2013-10-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: Oscar Benjamin has just made a proposal to me off-list that has *almost* convinced me to make statistics.sum a private implementation detail, at least for the 3.4 release. I won't go into detail about Oscar's proposal, but it has caused me to rethink all the

[issue18606] Add statistics module to standard library

2013-10-13 Thread Tim Peters
Tim Peters added the comment: Do what's best for the future of the module. A PEP is more of a starting point than a constraint, especially for implementation details. And making a private thing public later is one ginormous whale of a lot easier than trying to remove a public thing later.

[issue19217] Calling assertEquals for moderately long list takes too long

2013-10-13 Thread Ezio Melotti
Ezio Melotti added the comment: Here's a proof of concept to fix the issue (still lacks tests and breaks one existing test). The problem is that assertSequenceEqual computes the diff regardless of the size of the sequences, and then truncates it if it's too long. Producing the diff takes

[issue11928] fail on filename with space at the end

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- type: - behavior versions: +Python 3.4 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11928 ___

[issue17029] h2py.py: search the multiarch include dir if it does exist

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17029 ___

[issue15826] Increased test coverage of test_glob.py

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: patch review - commit review versions: -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file32106/issue15826.diff ___ Python tracker rep...@bugs.python.org

[issue887237] Machine integers

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue887237 ___ ___

[issue4888] misplaced (or misleading) assert in ceval.c

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: - patch review versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4888 ___

[issue14112] tutorial intro talks of shallow copy concept without explanation

2013-10-13 Thread Ezio Melotti
Ezio Melotti added the comment: Here is a patch that adds glossary entries for deep and shallow copy. I tried to keep them simple and clear enough. FWIW http://docs.python.org/3.4/library/copy.html also has a definition of the terms. If my definitions are OK I will add links to the terms

[issue4888] misplaced (or misleading) assert in ceval.c

2013-10-13 Thread Guido van Rossum
Changes by Guido van Rossum gu...@python.org: -- nosy: -gvanrossum ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4888 ___ ___ Python-bugs-list

[issue19251] bitwise ops for bytes of equal length

2013-10-13 Thread Ramchandra Apte
Ramchandra Apte added the comment: +1 -- nosy: +Ramchandra Apte ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19251 ___ ___ Python-bugs-list

[issue4965] Can doc index of html version be separately scrollable?

2013-10-13 Thread Georg Brandl
Georg Brandl added the comment: You'll have to put a copy in sphinxext/static. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4965 ___ ___

[issue18521] [cppcheck] Full report

2013-10-13 Thread Ezio Melotti
Ezio Melotti added the comment: I grouped the errors by message and checked of there were any actual errors. Most of the reports seemed wrong or false positive, but a few looked fixable. I haven't checked the Unusued variable ones, because they are harmless (even thought we could clean them

[issue14112] tutorial intro talks of shallow copy concept without explanation

2013-10-13 Thread Georg Brandl
Georg Brandl added the comment: The text talks about containers which, although often the case, is not general enough; copy() and deepcopy() can work with any object. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14112

[issue18521] [cppcheck] Full report

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset eaeaed43ff1c by Georg Brandl in branch 'default': Re #18521: fix not-quite-C syntax that works only because the PyXXX_Check are macros defined with () around them. http://hg.python.org/cpython/rev/eaeaed43ff1c -- nosy: +python-dev

[issue18521] [cppcheck] Full report

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7396d10405db by Georg Brandl in branch 'default': Re #18521: remove assignments of variables that are immediately reassigned. http://hg.python.org/cpython/rev/7396d10405db -- ___ Python tracker

[issue18521] [cppcheck] Full report

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 63bc2fe28a6e by Georg Brandl in branch 'default': Re #18521: move array bounds check before array access. http://hg.python.org/cpython/rev/63bc2fe28a6e -- ___ Python tracker rep...@bugs.python.org

[issue18521] [cppcheck] Full report

2013-10-13 Thread Georg Brandl
Georg Brandl added the comment: I fixed some items from Ezio's list that I think were legitimate; the rest is mostly invalid. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18521

[issue18606] Add statistics module to standard library

2013-10-13 Thread Raymond Hettinger
Raymond Hettinger added the comment: I think this should get checked in so that people can start interacting with it. The docstrings and whatnot can get tweaked later. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org

<    1   2   3