Serhiy Storchaka added the comment:
Shouldn't converttuple() in getargs.c set levels[1] = 0; after second
levels[0] = i+1;?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
Serhiy Storchaka added the comment:
Agree that all other looks false positive or unimportant.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
Raymond Hettinger added the comment:
Unlike pickle, the marshal module makes no promises about keeping the format
consistent between Python versions.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
New submission from Alex Gaynor:
Use case:
Alexanders-MacBook-Pro:pypy alex_gaynor$ python3.3
Python 3.3.2 (default, May 29 2013, 14:03:57)
[GCC 4.2.1 Compatible Apple LLVM 4.2 (clang-425.0.28)] on darwin
Type help, copyright, credits or license for more information.
import datetime.datetime
Roundup Robot added the comment:
New changeset c99a3566be83 by Serhiy Storchaka in branch '2.7':
Issue #19189: Improved cross-references in the pickle module documentation.
http://hg.python.org/cpython/rev/c99a3566be83
New changeset f2c725fb4b2f by Serhiy Storchaka in branch '3.3':
Issue
Serhiy Storchaka added the comment:
Thank you Georg for your review and for your suggestion.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18758
___
___
Serhiy Storchaka added the comment:
The version token needed only when we want break backward compatibility (change
the meaning of existing opcodes).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
koobs added the comment:
Tests fail for 2.7 on the koobs-freebsd9 and koobs-freebsd10 buildbots since
a9f967c8d002db364021a5fb1c9926a27029e849
Taking a snapshot of the output here for reference:
test_aifc
test test_aifc produced unexpected output:
Nick Coghlan added the comment:
+0 for starting with _sum as private and +1 for getting this initial
version checked in for alpha 4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18606
CliffM added the comment:
Sorry -- I could have been clearer :
The conditional:
if member.value == value:
Is redundant as the tests stand. If you comment it out -- everything works. So
therefore we are missing a test.
The current test works, as red is the first value to pop out of the
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: committed/rejected - patch review
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18919
___
Serhiy Storchaka added the comment:
Is unexpected output considered as test failing? The aifc module uses bare
print to output these warnings to stdout. Here is a patch which uses
captured_stdout().
--
Added file: http://bugs.python.org/file32109/test_aifc_capture_warnings.patch
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +brett.cannon, eric.snow
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19257
___
Serhiy Storchaka added the comment:
Perhaps a combination of len(pprint.pformat(seq1).splitlines()) and
len(pprint.pformat(seq2).splitlines()) (minimum, maximum or production) is
better metric?
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
The version token needed only when we want break backward
compatibility (change the meaning of existing opcodes).
This is true. For example, my first hunch was to make w_long()
emit variable-length data, (0-254: one byte integer, 255: four
bytes integer
Esa Peuha added the comment:
So best guess is that Microsoft's allocators have gotten fatally fragmented,
but I don't know how to confirm/refute that.
Let's test this in pure C. Compile and run the attached uglyhack.c on win32; if
it reports something significantly less than 100%, it's
New submission from Vajrasky Kok:
./python Lib/wsgiref/simple_server.py
Serving HTTP on 0.0.0.0 port 8000 ...
127.0.0.1 - - [14/Oct/2013 17:23:43] GET /xyz?abc HTTP/1.1 200 4510
sys:1: ResourceWarning: unclosed socket.socket fd=4, family=2, type=1,
proto=0, laddr=('0.0.0.0', 8000)
Attached
Christian Heimes added the comment:
Here is an optimized version with inline HMAC.
Contrary to the implementations in OpenSSL, PyCrypto, and pbkdf2.py the length
of the password has almost no impact on the runtime of my implementation.
--
Added file:
Vajrasky Kok added the comment:
Hi, Senthil Kumaran, thank you for your review.
I have one small complain about your improved patch. Perhaps we need to give
security warning when they want to use allow_dotted_names feature in the
documentation. I omitted the warning in the demo because it is
Serhiy Storchaka added the comment:
Benjamin, what would you say about this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18965
___
___
Serhiy Storchaka added the comment:
If there are no objections I'm going to commit this.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
stage: test needed - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2259
___
Christian Heimes added the comment:
I have optimized XOR and now it's even faster than OpenSSL's code for
reasonable long passwords. :(
--
Added file: http://bugs.python.org/file32113/pbkdf2_py3.patch
___
Python tracker rep...@bugs.python.org
Stefan Krah added the comment:
About IDLE I can't say anything, but I'm not entirely sure if the
PEP-399 import method is easier to understand for users, see e.g.:
http://stackoverflow.com/questions/13194384/instantiate-decimal-class
I get the impression that the posters at first did not even
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16525
___
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
For consistency with the aifc and sunau modules the wave module should
compress/uncompress u-law and A-law data.
--
nosy: +serhiy.storchaka
stage: test needed - needs patch
versions: +Python 3.4 -Python 3.2
___
STINNER Victor added the comment:
Python uses an allocator called pymalloc. For allocations smaller
than 512 bytes, it uses arenas of 256 KB. If you allocate many small
objects and later release most of them (but not all!), the memory is
fragmented. For allocations larger than 512 bytes, Python
Kristján Valur Jónsson added the comment:
Right, the idea of the version token is to introduce it now, as early as
possible, even if it is not needed, for prudence.
For example, if version 5 decides to change the semantics of some of the
opcodes, we can then support both kinds, in the future.
New submission from Christian Heimes:
The operator module doesn't have a Python implementation of _compare_digest.
This code mimicks the C code:
def _compare_digest(a, b):
if isinstance(a, str) and isinstance(b, str):
a = a.encode(ascii)
b = b.encode(ascii)
a =
STINNER Victor added the comment:
Should we support serialization in an older version? For example,
disable the new SMALL and ASCII tokens?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
STINNER Victor added the comment:
#15061 explains why the function is not implemented in Python :)
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19259
___
Serhiy Storchaka added the comment:
Here is a patch for all three audio modules. After dropping support of string
(which is meanless) in the audioop module (issue16685) it can be simplified.
I doubt that this should be applied in maintenance releases. Support of
non-bytes arguments in
Antoine Pitrou added the comment:
OTOH I don't like moving code around either, so we can wait until
there's a demonstrated need for the speedup.
Keep in mind that people who have startup speed problems aren't
likely to open an issue on the tracker about it, let alone
diagnose it enough to put
Antoine Pitrou added the comment:
Should we support serialization in an older version? For example,
disable the new SMALL and ASCII tokens?
It is officially supported with the version parameter:
http://docs.python.org/3.4/library/marshal.html#marshal.dump
--
Kristján Valur Jónsson added the comment:
We have done so previously and should continue to do that. Thanks for pointing
out that the new SHORT_REF needs that fix :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
Antoine Pitrou added the comment:
It explains why the function isn't implemented in Python, it doesn't say that
there shouldn't be a best-effort Python fallback.
All in all, Christian's version looks reasonable. All arithmetic is done on
small ints, so there shouldn't be a strong
Changes by Antoine Pitrou pit...@free.fr:
--
title: GC does not really free up memory in console - freeing then
reallocating lots of memory fails under Windows
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19246
Antoine Pitrou added the comment:
I have optimized XOR and now it's even faster than OpenSSL's code for
reasonable long passwords. :(
Uh... and it gives the right results? Perhaps OpenSSL should be reimplemented
in Python :-)
If your code is resistant to timing attacks, I suppose we don't
Antoine Pitrou added the comment:
The original commit doesn't contain any tests, so you should add some to be
sure there's no regression in both directions (i.e. no regression for issue
#6624 and for this issue):
http://hg.python.org/cpython/rev/83b46a5988b0/
--
Serhiy Storchaka added the comment:
Right, the idea of the version token is to introduce it now, as early as
possible, even if it is not needed, for prudence.
How it will help? If we will break backward compatibility in version 10, then
we will introduce the version token for version 10 and
Kristján Valur Jónsson added the comment:
Only output TYPE_SHORT_REF for version = 4
--
Added file: http://bugs.python.org/file32115/marshal2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
Kristján Valur Jónsson added the comment:
Quoting myself: for prudence.
We probably should have had this from the beginning. Adding this now makes it
easier to make such changes in future, because then you don't have to re-invent
the versioning mechanism.
--
Serhiy Storchaka added the comment:
Christian, does you noticed my comments on Rietveld?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
Serhiy Storchaka added the comment:
What is difference between introducing the version token right now or only when
(if?) we will need it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
New submission from Larry Hastings:
In r_string() (read a string) in marshal.c we see this comment:
/* The result fits into int because it must be =n. */
read = fread(p-buf, 1, n, p-fp);
This comment was first committed in r36501 by MvL. Back then the read and
n variables were int,
Nick Coghlan added the comment:
Added some structural comments to the patch. I'll defer to Serhiy when it comes
to assessing the algorithm details :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19183
Kristján Valur Jónsson added the comment:
Never put off to tomorrow what you can do today :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
Georg Brandl added the comment:
Python-ast.c can't be changed; it is auto-generated. But the whole thing can
be handled in compile.c I think -- see attached patch. Test suite passes
(except for test_dis, which checks compilation result against a given list of
bytecodes).
--
nosy:
Georg Brandl added the comment:
I'll make a complete patch with test suite additions (and fixing test_dis) if
this is deemed to be a correct approach.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
Changes by Georg Brandl ge...@python.org:
--
nosy: +bquinlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14407
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11646
___
___
Python-bugs-list
Georg Brandl added the comment:
Is this still the case with Python 2.7?
--
nosy: +georg.brandl
resolution: - out of date
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7979
Changes by Georg Brandl ge...@python.org:
--
assignee: - dmalcolm
nosy: +dmalcolm
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15817
___
___
Ethan Furman added the comment:
CliffM added the comment:
Sorry -- I could have been clearer :
The conditional:
if member.value == value:
Is redundant as the tests stand. If you comment it out -- everything works.
So therefore we are missing a test.
Are you saying that you are
Roundup Robot added the comment:
New changeset 3507be2f94d4 by Georg Brandl in branch '3.3':
Closes #17154: error out gracefully on ignore or condition without argument.
http://hg.python.org/cpython/rev/3507be2f94d4
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
Benjamin Peterson added the comment:
I think it's fine with the simplification I suggested.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
Georg Brandl added the comment:
If you know you have an expression and would like the value, you should use the
eval mode.
In the case of single, you can adapt sys.displayhook to change where to print
(if at all) the values. Note that single sometimes prints multiple values
(try e.g. for i
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17095
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16425
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list
Benjamin Peterson added the comment:
I think it's too bad parsing of b-prefixed strings in Python 2 doesn't reject
non-ASCII characters.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18965
Georg Brandl added the comment:
The refs output is only active in debug mode, and only for debugging. It is
printed directly to stderr using C fprintf(), I don't think it's worth the
complication.
--
nosy: +georg.brandl
resolution: - wont fix
status: open - closed
Changes by Georg Brandl ge...@python.org:
--
nosy: +bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15613
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15440
___
___
Python-bugs-list mailing list
Changes by Georg Brandl ge...@python.org:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15371
___
___
Python-bugs-list
Georg Brandl added the comment:
Sounds good to me.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18300
___
___
Changes by Georg Brandl ge...@python.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18068
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +barry, ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18096
___
___
Python-bugs-list
Georg Brandl added the comment:
Only affects 3.2, so this won't be fixed anymore.
--
nosy: +georg.brandl
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18254
Georg Brandl added the comment:
Last desperate ping for 3.4?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2919
___
___
Georg Brandl added the comment:
See attached patch, it handles this like all other builtins that don't support
keyword arguments in their constructor.
--
keywords: +patch
nosy: +georg.brandl, pitrou
versions: +Python 2.7, Python 3.3
Added file:
Georg Brandl added the comment:
aside The rXXX notation is reserved for SVN revision numbers, which are
unambiguous. The revision numbers in Mercurial are specific to each clone.
/aside
Other than that, LGTM.
--
nosy: +georg.brandl
___
Python
Changes by Georg Brandl ge...@python.org:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19258
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
If there are no objections I will commit this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12866
___
___
Roundup Robot added the comment:
New changeset f1e66ef64d17 by Georg Brandl in branch '3.3':
Closes #19258: close WSGI server after handling request in demo code.
http://hg.python.org/cpython/rev/f1e66ef64d17
New changeset 64a1e224042e by Georg Brandl in branch '2.7':
Closes #19258: close WSGI
Changes by Georg Brandl ge...@python.org:
--
nosy: +tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19138
___
___
Python-bugs-list
Antoine Pitrou added the comment:
I don't think weakref objects are meant to be picklable at all. At least
there's no support code for that, so pickling weak proxies only works by chance.
--
nosy: +alexandre.vassalotti
type: behavior - enhancement
versions: +Python 3.4 -Python 2.6,
Antoine Pitrou added the comment:
It doesn't work in 2.7 because bytearray only supports the new buffer API
(which is more secure), not the old one. I don't think it's worth trying to fix
at this point, so I'm tempted to close as won't fix.
--
nosy: +georg.brandl
Antoine Pitrou added the comment:
Why the PyWeakref_Check() in your patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Antoine Pitrou added the comment:
Well, the comment should actually be removed, it's just pointless.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
Peder Jørgensen added the comment:
This is great!
My brother did a few more updates to it and added support for endian
conversion, and i've been using it a lot with out any problems, but i must
admit your patch looks a lot cleaner Serhiy. Great work. Can't wait to test it.
This is going to be
Martin v. Löwis added the comment:
I agree that the comment can be removed. If the code is (now) statically
type-safe, there is no point in keeping it.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list
Georg Brandl added the comment:
Agreed. This is not really a bugfix.
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
Georg Brandl added the comment:
Good point, that is pointless in __init__().
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Changes by Georg Brandl ge...@python.org:
Added file: http://bugs.python.org/file32119/no_weakref_kwargs_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
Georg Brandl added the comment:
Updated patch with test suite update.
--
Added file: http://bugs.python.org/file32120/if_else_nojump_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
Benjamin Peterson added the comment:
lgtm
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
R. David Murray added the comment:
In 2.7 unexpected output is a test failure, yes.
In 3.x we removed that check. But I wonder if that was wise :) (We did it for
technical reasons when adding other features to regrtest).
Yes, using captured_stdout and checking for the expected warnings
Antoine Pitrou added the comment:
Just for the record, have you passed the whole test suite after cleaning up the
pyc files,
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
Serhiy Storchaka added the comment:
I tested 2.6, 2.7, 3.2, 3.3, and 3.4. All of them read and write 24b48k.aif.
Currently 2.7, 3.3, and 3.4 have tests for 24-bit aifc files. Seems this issue
is not more actual.
--
dependencies: -Add support for 24-bit samples in the audioop module
Georg Brandl added the comment:
Issue #6624 wasn't an issue, it should have been closed-invalid :)
But you're right, a test case is needed, see new patch.
--
Added file: http://bugs.python.org/file32121/seterror_fix_2.patch
___
Python tracker
Serhiy Storchaka added the comment:
Currently 24-bit wave files are supported at least in 2.7, 3.3, and 3.4 (there
are tests for this). The audioop module yet not supports 24-bit data, but this
is another issue.
--
dependencies: -Add support for 24-bit samples in the audioop module
Georg Brandl added the comment:
Yep :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Serhiy, you're welcome to set issues to pending, but please don't forget to
close them after a certain time...
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
Changes by Georg Brandl ge...@python.org:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list
1 - 100 of 170 matches
Mail list logo
