Charles-François Natali added the comment:
Would it be possible to generate a clean patch?
The latest one contains many unrelated commits.
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18874
Roundup Robot added the comment:
New changeset 0d9624f2ff43 by Serhiy Storchaka in branch 'default':
Issue #12892: The utf-16* and utf-32* codecs now reject (lone) surrogates.
http://hg.python.org/cpython/rev/0d9624f2ff43
--
nosy: +python-dev
___
Kristján Valur Jónsson added the comment:
No matter how it sounds, it certainly looks cleaner in code.
Look at all this code, designed to work around an unexpected GC collection with
various pointy bits and edge cases and special corners.
Compare to explicitly just asking GC to relent, for a
New submission from STINNER Victor:
The following failure may be related to #19466. I failed to reproduce it on my
Windows 7 VM (I compiled Python in 32-bit mode).
http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1697/steps/test/logs/stdio
New submission from John Dobson:
2 consecutive commands into interactive shell still results in segmentation
fault 11, patch 18458 reports skipped as patch not needed for 3.3
--
assignee: ronaldoussoren
components: Macintosh
messages: 203347
nosy: johndobson, ronaldoussoren
priority:
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +hynek, ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19651
___
___
koobs added the comment:
I'm not sure how I missed this, but our FreeBSD ports that build out-of-tree
required adding a local patchthat reverts the Makefile.pre.in change in
ab6ab44921b2 when we updated each port to the latest releases of 2.7, 3.2 and
3.3:
Antoine Pitrou added the comment:
No matter how it sounds, it certainly looks cleaner in code.
It's also unsafe and invasive, since it's a process-wide setting. An
iterator can be long-lived if it's being consumed slowly, so you've
disabled garbage collection for an unknown amount of time,
Xavier de Gaye added the comment:
This is a consequence of the problem mentioned in msg 177059 above.
New patch 'issue16596_nostate_3.diff' fixes both problems by having the
interpreter
issue an exception debug event when processing a StopIteration in target
FOR_ITER:
* The same debug events
Xavier de Gaye added the comment:
Forgot to say that the only difference between this patch and the previous one
is in Python/ceval.c.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
Gregory Salvan added the comment:
issue18054 :
- adding assertCleanError in the ipaddress module,
- suggesting assertCleanTraceback, assertRaisedFrom in unittest
- usefull but TestCase has already a wide api.
A solution like Testtools assertThat with matcher protocol
Serhiy Storchaka added the comment:
Ezio have approved the patch and I have committed it.
Thank you Victor and Kang-Hao for your patches. Thanks all for the reviews.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Kristján Valur Jónsson added the comment:
Yes, the long iterator scenario is the reason it is not ideal for this
scenario.
The other one (gc.collect()) is easily solved by implementing this construct
natively. It can be done rather simply by adding an overriding pause
property to gc, with
Antoine Pitrou added the comment:
Speaking of which, this is not only about GC runs, although it is the most
annoying scenario (since you basically don't control when it happens). Regular
resource reaping because of reference counting can also wreak havoc.
About the patch, I don't know. It
Kristján Valur Jónsson added the comment:
The changes for the docs are just a port of the original patch. And indeed,
these functions don't return an iterator, but a generator object.
I admit I'm confused by the difference, since next() can be called directly on
the generator. Still, a lot
Roundup Robot added the comment:
New changeset 27461e6a7763 by Victor Stinner in branch 'default':
Issue #19513: Disable overallocation of the PyUnicodeWriter before the last
write
http://hg.python.org/cpython/rev/27461e6a7763
--
___
Python tracker
STINNER Victor added the comment:
I created the issue #19652: test_asyncio: test_subprocess_send_signal() hangs
on buildbot AMD64 Snow Leop 3.x.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19334
New submission from STINNER Victor:
I didn't understand the purpose of the issue #19334: it doesn't mention the OS
nor the test. I prefer to create a more specific issue, so here you have one
specific hang.
STINNER Victor added the comment:
The original report and build logs were attached to the original issue
covering the import of asyncio: #19262
Also attaching here.
Extract of the most important part:
[382/382] test_asyncio
Timeout (1:00:00)!
Thread 0x000805c18000:
File
Nick Coghlan added the comment:
Given the time frame, how about we just go with Serhiy's suggestion of a known
non-Unicode codec internal blacklist for both 3.3 and 3.4?
I still like the idea of exposing codec type maps for introspection, but
designing a decent API for that which also handles
Michael Foord added the comment:
The new behaviour is intentional, glad you've managed to work around it.
--
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Marc-Andre Lemburg added the comment:
On 19.11.2013 12:38, Nick Coghlan wrote:
Given the time frame, how about we just go with Serhiy's suggestion of a
known non-Unicode codec internal blacklist for both 3.3 and 3.4?
+1
--
___
Python tracker
Stefan Holek added the comment:
I have some complex test fixtures that I have written tests for, and one of
them started to fail because it assumed that the suite would still be valid
after having run.
That said, I was able to work around the issue and if you don't care neither do
I. ;-)
Roundup Robot added the comment:
New changeset 99141ab08e21 by Victor Stinner in branch 'default':
Issue #19513: repr(tuple) now uses _PyUnicodeWriter for better performances
http://hg.python.org/cpython/rev/99141ab08e21
--
___
Python tracker
STINNER Victor added the comment:
Thanks Serhiy for your review.
I added a new _PyUnicodeWriter_WriteASCIIString() function to write the
separator (, ) and the suffix (,)).
changeset: 87263:d1ca05428c38
user:Victor Stinner victor.stin...@gmail.com
date:Tue Nov 19 12:54:53
Roundup Robot added the comment:
New changeset 3a354b879d1f by Victor Stinner in branch 'default':
Issue #19646: repr(dict) now uses _PyUnicodeWriter API for better performances
http://hg.python.org/cpython/rev/3a354b879d1f
--
nosy: +python-dev
___
STINNER Victor added the comment:
I added a new _PyUnicodeWriter_WriteASCIIString() function to reply to Serhiy's
comment on Rietveld:
Perhaps it will be worth to add a helper function or macros
_PyUnicodeWriter_WriteTwoAsciiChars()?
changeset: 87263:d1ca05428c38
user:Victor
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19646
___
Ezio Melotti added the comment:
Here's an updated patch that addresses comments on rietveld and adds a few more
tests and docs.
I should also update the what's new, but I have other upcoming changes in the
html package so I'll probably do it at the end.
Regarding your concern:
* if people are
Nick Coghlan added the comment:
Actually, this won't the subTest example because that actually *suppresses* the
errors, and reports them later. Annotations only help when the exception is
allowed to escape.
--
___
Python tracker
New submission from STINNER Victor:
The _PyUnicodeWriter API avoids creation of temporary Unicode strings and has
very good performances to build Unicode strings with the PEP 393 (compact
unicode string).
Attached patch adds a _PyObject_ReprWriter() function to avoid creation of
tempory
Serhiy Storchaka added the comment:
Using this function, there is no need to create temporary colon (: ) or sep
(, ) strings, performances are a little better with the final commit.
I'm surprised that this has given such large effect. ;) I hoped only on more
clear code.
--
STINNER Victor added the comment:
I'm surprised that this has given such large effect. ;) I hoped only on more
clear code.
To be honest, I expected shorter code but worse performances using
_PyUnicodeWriter_WriteASCIIString().
dict_repr() was not really super fast: it did call
New submission from STINNER Victor:
http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/7331/steps/test/logs/stdio
==
FAIL: test_debug (tkinter.test.test_tkinter.test_text.TextTest)
Roundup Robot added the comment:
New changeset 130597102dac by Serhiy Storchaka in branch 'default':
Remove dead code committed in issue #12892.
http://hg.python.org/cpython/rev/130597102dac
--
___
Python tracker rep...@bugs.python.org
New submission from Eli Bendersky:
It was mentioned in one of the recent python-dev threads that making the Python
code-base simpler to encourage involvement of contributors is a goal, so I
figured this may be relevant.
I've recently written a new parser for the ASDL specification language
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19654
___
___
Nick Coghlan added the comment:
Attached is a proof of concept for the blacklist approach (for 3.4, but without
the fixes needed for the transform codec handling tests in test_codecs)
This does have the potential to add a reasonable amount of additional overhead
to encoding and decoding for
Nick Coghlan added the comment:
Victor is still -1, so to Python 3.5 it goes.
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7475
___
Ned Deily added the comment:
Works for me using the python.org 3.3.3 64-/32-bit installer. Are you using
that Python 3.3.3? Please show the results of typing the following commamds
and substituting for python3.3 whatever command name you are using that
causes the segfault.
python3.3 -c
STINNER Victor added the comment:
+/* A set would be faster, but when to build it, where to store it? */
+if (_PyUnicode_CompareWithId(codec_name, PyId_base64) == 0 ||
+_PyUnicode_CompareWithId(codec_name, PyId_uu) == 0 ||
+_PyUnicode_CompareWithId(codec_name,
Eli Bendersky added the comment:
FWIW, asdl_c.py could use some modernization, but I'll defer this to a later
cleanup in order to do things gradually.
The same can be said for the Makefile rules - they can be simpler and more
efficient (no need to invoke asdl_c / parse the ASDL twice, for
Larry Hastings added the comment:
A week before beta? How confident are you in this new parser?
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
___
Ned Deily added the comment:
There's something odd going on with that buildbot. The failures are from
Serhly's new tests. For 10.4 Tiger, the buildbot should be running Tk 8.4. It
does seem to have a third-party Tcl and Tk installed in /Library/Frameworks,
which is good, but the logs don't
Changes by Ned Deily n...@acm.org:
--
nosy: +db3l
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19654
___
___
Python-bugs-list mailing list
Eli Bendersky added the comment:
Larry, ease your worries: note that I only tagged this on version 3.5!
That said, this parser runs during the build and produces a .h file and .c file
- these partake in the build; I verified that the generated code is *identical*
to before, so there's not
Mark Lawrence added the comment:
Are we at beta for 3.5 already? :)
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
___
Nick Coghlan added the comment:
Future proofing is irrelevant at this point - this is just about what
can realistically be implemented in 3.4, not what can be implemented
with the luxury of several months to rearchitect the codec system (and
if we were going to do that, we'd just fix the type
John Dobson added the comment:
mysite $ python -c 'import sys;print(sys.version)'
3.3.3 (v3.3.3:c3896275c0f6, Nov 16 2013, 23:39:35)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]
mysite $ python -c 'import readline;print(readline.__file__)'
Christian Heimes added the comment:
Your Python installation picks up the wrong readline module.
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19651
___
Ned Deily added the comment:
Christian is correct. /System/Library/Frameworks is the location of the Apple
supplied system Pythons and further Apple does not ship any version of Python
3. So you should figure out how your /System/Library got altered and restore it
to release state.
John Dobson added the comment:
Many thanks for your prompt assistance
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19651
___
Serhiy Storchaka added the comment:
Blacklisting by name is slow and it prevents a user from defining a codec with
blacklisted name.
What if just add private attribute (_not_text?) to unsafe codecs? If a codec
has this attribute, than it should not be used it text encoding/decoding.
Checking
Guido van Rossum added the comment:
The traceback is pretty useless. So is the title of the other bug report hangs
for 1 hour (which just means it hangs forever but the test runner kills it
after one hour).
We would need to run the tests with -v so at least we can pinpoint which of the
600
STINNER Victor added the comment:
Ah, it looks like the test uses a child process. The following issue has a
similar problem, we don't know that status of the child process:
http://bugs.python.org/issue19564
I proposed a patch in this issue for multiprocessing, to enable also
faulthandler in
Roundup Robot added the comment:
New changeset e0c4a5b2b739 by Martin v. Löwis in branch 'default':
Issue #19550: Implement Windows installer changes of PEP 453 (ensurepip).
http://hg.python.org/cpython/rev/e0c4a5b2b739
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset 4fe87b5df2d0 by Andrew Kuchling in branch '3.3':
#1098749: re-word gettext docs to not encourage using pygettext so much.
http://hg.python.org/cpython/rev/4fe87b5df2d0
--
nosy: +python-dev
___
Python
A.M. Kuchling added the comment:
I've applied a patch from #8502 that doesn't encourage the use of pygettext.py
so strongly.
I raised the issue of deprecating pygettext.py on python-dev on Nov 11 2013;
the thread starts at
A.M. Kuchling added the comment:
Applied my documentation patch.
New changeset 4fe87b5df2d0 by Andrew Kuchling in branch '3.3':
#1098749: re-word gettext docs to not encourage using pygettext so much.
http://hg.python.org/cpython/rev/4fe87b5df2d0
--
Erik Purins added the comment:
Note that the zipfile module does not include a dereference option, but tarfile
does.
The following links to python examples show that users are writing zipfiles
with symlinks, so it is possible to preserve them in a zip archive.
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
___
___
Python-bugs-list
Martin v. Löwis added the comment:
I have now committed the changes to the installer. A demo installer can be
found at
http://prof.beuth-hochschule.de/fileadmin/user/mvon_loewis/python-3.4.16027.msi
I'm skeptical about the lack of proper deinstallation: per convention,
uninstallation of
anatoly techtonik added the comment:
Implemented more advanced interface with filtering and tests - here -
https://bitbucket.org/techtonik/astdump/
Right now the output is not so detailed, but it may change if the need arises.
--
___
Python tracker
Nick Coghlan added the comment:
Yes, a private attribute on CodecInfo is probably better - the rest of the
patch would stay the same, it would just check for that attribute instead
of particular names.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
That sounds reasonable to me - thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19550
___
___
Ezio Melotti added the comment:
Here is the last iteration with a few minor tweaks and a couple more tests.
--
stage: patch review - commit review
Added file: http://bugs.python.org/file32703/issue2927-3.diff
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
I cannot help you unless you tell me which specific test is failing. But once
you have a proposed fix I will review it. Thanks for advocating for the
minority platforms!
--
___
Python tracker
Zachary Ware added the comment:
I don't know that it's expected, but it doesn't appear to be unexpected.
regrtest doesn't appear to know anything about expected failures or unexpected
successes, mostly because both concepts appear at the individual test level
while regrtest deals at the test
New submission from Serhiy Storchaka:
PEP 3112 had added bytes literals in 2.6. But bytes literals in 2.x are just
synonyms to 8-bit string literals and allow non-ascii characters, while bytes
literals in 3.x allows only ascii characters. For better forward compatibility
with 3.x the proposed
Tim Golden added the comment:
Fine with your volumepathname patch. The core of the code was contributed and I
didn't check it too carefully as it clearly worked. (For some definition of
worked).
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 6e5afeada7ca by R David Murray in branch '3.3':
#19449: Handle non-string keys when generating 'fieldnames' error.
http://hg.python.org/cpython/rev/6e5afeada7ca
New changeset ee2c80eeca2a by R David Murray in branch 'default':
Merge: #19449: Handle
New submission from Garrett Cooper:
I was a bit surprised when I ran into this issue when porting some nose tests
from Windows to Linux:
#!/usr/bin/env python
with open('/etc/services') as fd:
lines = fd.readlines()
lines.append('')
SERVICES = [line.split()[0] for line in lines
Serhiy Storchaka added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2927
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
That's not the right fix for that test failure. If exec_module() is not meant
to set import-related attributes like __cached__ because import itself (through
_SpecMethods.init_module_attrs()) then test_frozen needs to be updated to not
expect such attributes.
R. David Murray added the comment:
Thanks, Tomas and Vajrasky. I tweaked the patch slightly: Thomas's fix was
better, since it doesn't incur the overhead of the repr unless an an error is
detected (a micro-optimization, true, but an easy one). I also chose to only
check that 'fieldnames' is
Roundup Robot added the comment:
New changeset 7b9235852b3b by Ezio Melotti in branch 'default':
#2927: Added the unescape() function to the html module.
http://hg.python.org/cpython/rev/7b9235852b3b
--
nosy: +python-dev
___
Python tracker
Peter Otten added the comment:
I believe you are misinterpreting what you are seeing. Empty lines read from a
file do not produce an empty string, you get \n instead which is true in a
boolean context.
Try
[line.split()[0] for line in lines if line.strip() and not line.startswith(#)]
or add
Ezio Melotti added the comment:
Fixed, thanks for the reviews!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2927
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - invalid
stage: - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19657
Dustin Haffner added the comment:
I've made an attempt at patching set_issubset() to match the Python from
Raymond's message. I've rearranged the set_issubset function so that it checks
for a set/frozenset, dict, or iterable in that order. In the iterable case it
will create a temporary set
Serhiy Storchaka added the comment:
We can add a print for a patchlevel.
--
keywords: +patch
Added file: http://bugs.python.org/file32707/test_tcl_patchlevel.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19654
Ronald Oussoren added the comment:
I for the most part agree with the comments and will provide an updated patch
on thursday. Would you mind if I committed that without further review (due to
cutting it awfully close to the deadline for beta 1)?
Some comments I want to reply to specifically:
Serhiy Storchaka added the comment:
It's too large and complicated patch. I would like to have a chance to quick
review it before committing. You will have time to commit.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
I propose to include frame size in previous frame. This will twice decrease the
number of file reads.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17810
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
___
___
Serhiy Storchaka added the comment:
Could anyone please review the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
___
___
Claudiu.Popa added the comment:
Ping, please review. I guess it is minimal enough to get into 3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18615
___
Guido van Rossum added the comment:
It's not fixed. Let me paste in a session. This uses the latest Tulip repo
(simple_tcp_server.py was just added). I've added import pdb;
pdb.set_trace() to the top of the client() coroutine, to set a breakpoint (I'm
a very unsophisticated pdb user :-).
Changes by Guido van Rossum gu...@python.org:
--
nosy: -gvanrossum, jackjansen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
___
___
Roundup Robot added the comment:
New changeset 68fd86a83ece by Victor Stinner in branch 'default':
Issue #9566: compile.c uses Py_ssize_t instead of int to store sizes to fix
http://hg.python.org/cpython/rev/68fd86a83ece
--
___
Python tracker
STINNER Victor added the comment:
Oops, I forgot to mention this issue number in the commit:
---
changeset: 87277:68fd86a83ece
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Tue Nov 19 22:23:20 2013 +0100
files: Python/compile.c
description:
Issue
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19578
___
___
Python-bugs-list
New submission from Ronny Pfannschmidt:
got:
l = {}
import inspect
exec(compile('def fun(): pass', '', 'exec'), l, l)
inspect.getsource(l['fun'])
Traceback (most recent call last):
File input, line 1, in module
File /home/private/.local/lib/python3.3/inspect.py, line 726, in getsource
Roundup Robot added the comment:
New changeset 8d3e85dfa46f by Victor Stinner in branch 'default':
Issue #9566, #19617: Fix compilation on Windows
http://hg.python.org/cpython/rev/8d3e85dfa46f
--
nosy: +python-dev
___
Python tracker
Roundup Robot added the comment:
New changeset 8d3e85dfa46f by Victor Stinner in branch 'default':
Issue #9566, #19617: Fix compilation on Windows
http://hg.python.org/cpython/rev/8d3e85dfa46f
--
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
We could take the opportunity to ast scripts to a Tools/ subdir. Then you could
use whatever it is test_tools.py uses.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19655
Francisco Martín Brugué added the comment:
Actual tip:
changeset: 87276:2012e85638d9
date: Tue Nov 19 11:43:38 2013 -0800
It's a fresh clone, then:
make clean
./configure --with-pydebug
make -j4
./python -OO -m test -v test_email
== CPython 3.4.0a4+ (default:2012e85638d9, Nov 19 2013,
Zachary Ware added the comment:
Does this qualify as a new feature that needs to be in before beta 1?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3158
___
Serhiy Storchaka added the comment:
Updated patch addresses Victor's comments.
--
Added file: http://bugs.python.org/file32708/deprecate-U-mode_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
1 - 100 of 138 matches
Mail list logo
