[issue16099] robotparser doesn't support request rate and crawl delay parameters

Nikolay Bogoychev added the comment: Hey, it has been more than an year since the last activity. Is there anything else I should do in order for someone of the python devs team to review my changes and perhaps give some feedback? Nick -- ___ Python

[issue19736] posixmodule.c: Add flags for statvfs.f_flag to constant list

Roundup Robot added the comment: New changeset 1d0b7e90da4d by doko in branch 'default': - Issue #19736: Add module-level statvfs constants defined for GNU/glibc http://hg.python.org/cpython/rev/1d0b7e90da4d -- nosy: +python-dev ___ Python tracker

[issue19922] mbstate_t requires _INCLUDE__STDC_A1_SOURCE

Roundup Robot added the comment: New changeset 4221d5d9ac84 by Christian Heimes in branch 'default': Attempt to fix OpenIndiana build issue introduced by #19922 http://hg.python.org/cpython/rev/4221d5d9ac84 -- ___ Python tracker

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Nick Coghlan added the comment: Victor, people set "LANG=C" for all sorts of reasons, and we have no control over how operating systems define that locale. The user perception is "Python 3 doesn't work properly when you ssh into systems", not "Gee, I wish operating systems defined the C locale mo

[issue19700] Update runpy for PEP 451

Nick Coghlan added the comment: Deleted a bunch of code, and runpy now correctly sets both __file__ and __cached__ (runpy previously never set the latter properly). You can also see the reason for my rant above in the form of runpy._fixed_find_spec. importlib.find_loader was always kind of use

[issue19343] Expose FreeBSD-specific APIs in resource module

Christian Heimes added the comment: Claudiu, I'm really sorry. :( The patch was originally developed by you, not by koobs. All credits to you! -- ___ Python tracker ___

[issue17259] Document round half to even rule for floats

alexd2 added the comment: Note: I have python2.7.3 in Ubuntu 12.04.3 installed in a VirtualBox VM on a Windows 7 32-bit and an Intel(R) Core(TM)2 Duo CPU U9300 @ 1.20GHz (2 CPUs), ~1.2GHz processor -- ___ Python tracker

[issue19343] Expose FreeBSD-specific APIs in resource module

Christian Heimes added the comment: Thanks Larry! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue19343] Expose FreeBSD-specific APIs in resource module

Roundup Robot added the comment: New changeset ad2cd599f1cf by Christian Heimes in branch 'default': Issue #19343: Expose FreeBSD-specific APIs in resource module. Original patch by Koobs. http://hg.python.org/cpython/rev/ad2cd599f1cf -- nosy: +python-dev _

[issue19343] Expose FreeBSD-specific APIs in resource module

Larry Hastings added the comment: I can live with this in 3.4 if you check it in before beta 2. -- ___ Python tracker ___ ___ Python-b

[issue19766] test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module

Christian Heimes added the comment: Vinay, thanks for your fast response! :) #19913 should be resolved, too. A couple of months ago several people complained about a new file that looked like a ZIP bomb. This virus warnings looks even more severe although it's probably a false positive. Could

[issue19700] Update runpy for PEP 451

Nick Coghlan added the comment: OK, I just noticed that importlib.find_spec copies the annoying-as-hell behaviour of importlib.find_loader where it doesn't work with dotted names. Can we fix that please? It's stupid that pkgutil.get_loader has to exist to workaround that design flaw for find_l

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Antoine Pitrou added the comment: > Or said differently, the filesystem encoding is different than the > locale encoding. Indeed, but the FS encoding and the IO encoding are the same. "locale encoding" doesn't really matter here, as we are assuming that it's wrong. --

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Larry Hastings added the comment: Antoine: are you characterizing this as a "bug" rather than a "new feature"? I'd like to see more of a consensus before something like this gets checked in. Right now I see a variety of opinions. When I think "conservative approach" and "knows about system en

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

Larry Hastings added the comment: Brett, could you weigh in please? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue19929] subprocess: increase read buffer size

Charles-François Natali added the comment: > STINNER Victor added the comment: > > Since Popen.communicate() returns the whole content of the buffer, would it > be safe to increase the buffer size? For example, use 4 GB as the buffer size? Sure, if you want to pay the CPU and memory overhead of

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

Charles-François Natali added the comment: > STINNER Victor added the comment: > > I don't like generic "except OSError: pass". Here is a first patch for > epoll() to use "except FileNotFoundError: pass" instead. Kqueue selector > should also be patched. Except that it can fail with ENOENT, bu

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Serhiy Storchaka added the comment: Setting sys.stderr encoding to UTF-8 on ASCII locale is wrong. sys.stderr has the backslashreplace error handler by default, so it newer fails and should newer produce non-ASCII data on ASCII locale. -- nosy: +serhiy.storchaka __

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

STINNER Victor added the comment: 2013/12/8 Antoine Pitrou : >> Python uses the fact that the filesystem encoding is the locale >> encoding in various places. > > The patch doesn't change that. You wrote: "-> With the patch: utf-8 utf-8 utf-8 ANSI_X3.4-1968", so os.get sys.getfilesystemencoding(

[issue19700] Update runpy for PEP 451

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Antoine Pitrou added the comment: > If you use a different encoding but only just for filenames, you will > get mojibake when you pass a filename on the command line or in an > environment varialble. That's not what the patch does. -- ___ Python trac

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

STINNER Victor added the comment: 2013/12/8 Nick Coghlan : > Yes, that's the point. *Every* case I've seen where the locale encoding has > been reported as ASCII on a modern Linux system has been because the > environment has been configured to use the C locale, and that locale has a > silly,

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

STINNER Victor added the comment: I don't like generic "except OSError: pass". Here is a first patch for epoll() to use "except FileNotFoundError: pass" instead. Kqueue selector should also be patched. I tested to close epoll FD (os.close(epoll.fileno())): on Linux 3.11, epoll.unregister(fd)

[issue19846] Setting LANG=C breaks Python 3

Changes by Nick Coghlan : -- title: print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding() -> Setting LANG=C breaks Python 3 ___ Python tracker _

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

Nick Coghlan added the comment: Yes, that's the point. *Every* case I've seen where the locale encoding has been reported as ASCII on a modern Linux system has been because the environment has been configured to use the C locale, and that locale has a silly, antiquated, encoding setting. This

[issue19883] Integer overflow in zipimport.c

STINNER Victor added the comment: Here is a work-in-progress patch. PyMarshal_ReadShortFromFile() and PyMarshal_ReadLongFromFile() are still wrong: new Unsigned version should be added to marshal.c. I don't know if a C cast to unsigned is enough because long can be larger than 32-bit (ex: on L

[issue19930] os.makedirs('dir1/dir2', 0) always fails

Changes by Serhiy Storchaka : -- keywords: +patch nosy: +loewis Added file: http://bugs.python.org/file33043/os_makedirs_mode.patch ___ Python tracker ___ ___

[issue19930] os.makedirs('dir1/dir2', 0) always fails

New submission from Serhiy Storchaka: os.makedirs() can't create a directory with cleared write or list permission bits for owner when parent directories aren't created. This is because for parent directories same mode is used as for final directory. Note that the mkdir utility creates parent

[issue19766] test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module

Vinay Sajip added the comment: I've updated distlib to use dummy_threading where threading isn't available - see https://bitbucket.org/pypa/distlib/commits/029fee573900765729402203e39b2171d7ae0784 Can someone please test with this version vendored into pip to check that the failures no longer

[issue19929] subprocess: increase read buffer size

STINNER Victor added the comment: Oh, Charles-François Natali replied to my review by email, and it's not archived on Rietveld. Copy of him message: > http://bugs.python.org/review/18923/diff/9757/Lib/subprocess.py#newcode420 > Lib/subprocess.py:420: _PopenSelector = selectors.SelectSelector >

[issue17259] Document round half to even rule for floats

alexd2 added the comment: I encountered the same inconsistent behavior. That is, I don't get the same rounding from the two following commands: print "%.f %.f" %(0.5, 1.5) # Gives --> 0 2 print "%.f %.f" %(round(0.5), round(1.5)) # Gives --> 1 2 I also get: print round(0.5), roun

[issue19929] subprocess: increase read buffer size

STINNER Victor added the comment: Where is the buffer size? The hardcoded 4096 value in Popen._communicate()? data = os.read(key.fd, 4096) I remember that I asked you where does 4096 come from when you patched subprocess to use selectors (#18923): http://bugs.python.org/review/18923/#ps9827

[issue19846] print() and write() are relying on sys.getfilesystemencoding() instead of sys.getdefaultencoding()

STINNER Victor added the comment: Antoine Pitrou added the comment: > > Python uses the fact that the filesystem encoding is the locale > > encoding in various places. > The patch doesn't change that. Nick Coghlan added the comment: > Note that the *only* change Antoine's patch makes is that: >

[issue19921] Path.mkdir(0, True) always fails

Serhiy Storchaka added the comment: Thank you Vajrasky. Now this check is skipped on Windows. -- Added file: http://bugs.python.org/file33042/pathlib_mkdir_mode_4.patch ___ Python tracker __

[issue19690] test_logging test_race failed with PermissionError

Vinay Sajip added the comment: I'll close this for now as the failures seem to have stopped. Though I only added some diagnostics, that might have changed the relative timings enough so the race doesn't surface (for now). -- resolution: -> works for me status: open -> closed

[issue19766] test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module

Vinay Sajip added the comment: I will look at doing a distlib update shortly - but there's another issue (#19913) that might also require an update - it' not clear yet. -- ___ Python tracker __

[issue19929] subprocess: increase read buffer size

New submission from Charles-François Natali: This is a spinoff of issue #19506: currently, subprocess.communicate() uses a 4K buffer when reading data from pipes. This was probably optimal a couple years ago, but nowadays most operating systems have larger pipes (e.g. Linux has 64K), so we migh

[issue19572] Report more silently skipped tests as skipped

Serhiy Storchaka added the comment: I have added few comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19837] Wire protocol encoding for the JSON module

Gregory P. Smith added the comment: So why not put a dump_bytes into upstream simplejson first, then pull in a modern simplejson? There might be some default flag values pertaining to new features that need changing for stdlib backwards compatible behavior but otherwise I expect it's a good i

[issue19925] Add unit test for spwd module

Vajrasky Kok added the comment: Hi Claudiu, thanks for the review and the knowledge that on Windows, we don't have attribute getuid of os. Here is the updated patch. I do not check specifically for Windows but only whether the platform can import spwd module or not. That should be enough. ---

[issue19837] Wire protocol encoding for the JSON module

Gregory P. Smith added the comment: upstream simplejson (of which json is an earlier snapshot of) has an encoding parameter on its dump and dumps method. Lets NOT break compatibility with that API. Our users use these modules interchangeably today, upgrading from stdlib json to simplejson wh

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

Charles-François Natali added the comment: The test is failing on Windows buildbot: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1851/steps/test/logs/stdio """ == ERROR: test_unreg

[issue19928] Implement cell repr test

New submission from Serhiy Storchaka: Repr test for cell is empty. Proposed patch implements it. -- components: Tests files: test_cell_repr.patch keywords: patch messages: 205528 nosy: serhiy.storchaka, zach.ware priority: normal severity: normal stage: patch review status: open title: I

[issue19921] Path.mkdir(0, True) always fails

Vajrasky Kok added the comment: Fails on Windows Vista. ...s..s..s..s...F. .. == FAIL: test_mkdir_parents (__main__.PathTest) --

<    1   2