[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Rebecka added the comment: I've checked and an updated test file for 3.4 shows the same behaviour in the renamed module http.cookiejar. Even though no standard exists I hope 3.4+ would be changed to simplify the cookie handling, since there is a lot of hassle converting UTC times to local tim

[issue22320] Invalid link in General Python FAQ

Roundup Robot added the comment: New changeset 241f9aa9fb89 by Ned Deily in branch '2.7': Issue #22320: Fix broken link in the General Python FAQ. http://hg.python.org/cpython/rev/241f9aa9fb89 New changeset 3eaba8a0cb3a by Ned Deily in branch '3.4': Issue #22320: Fix broken link in the General P

[issue22320] Invalid link in General Python FAQ

Ned Deily added the comment: Thanks again for the patch! (I did change the wording slightly.) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22320] Invalid link in General Python FAQ

Josh Lynn added the comment: No problem! Thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue10240] dict.update.__doc__ is misleading

Changes by Raymond Hettinger : -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22311] Pip 404's

Changes by Ned Deily : -- nosy: +dstufft ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

Andrea Torre added the comment: Ubuntu 12.04 64-bit Python 2.7.3 (virtualenv) Hi, just adding a few info, hope not completely useless, that seem related to the issue. I got the same message when running nosetests against my source. It's an application using Tkinter as frontend. All tests pass,

[issue20215] Python2.7 socketserver can not listen IPv6 address

Andreas Røsdal added the comment: Is there any interest in this patch? it would be nice with a review of the patch. :) -- ___ Python tracker ___ ___

[issue18615] sndhdr.whathdr could return a namedtuple

Raymond Hettinger added the comment: The patch looks good. I'll apply it shortly. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue22306] Inconsistent division by 0 behaviour in decimal module

Raymond Hettinger added the comment: > Sorry. Scratch my last comment. I see from the docs > ( https://docs.python.org/3/library/decimal.html ) >vthat the decimal module explicitly references that IBM spec. > I imagine that standard python arithmatic doesn't even attempt > to conform to this

[issue22293] unittest.mock: use slots in MagicMock to reduce memory footprint

Changes by Raymond Hettinger : -- stage: -> needs patch versions: +Python 3.5 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list

[issue21400] Code coverage documentation is out-of-date.

Heather McCartney added the comment: Here's a patch with a suggestion for the new text, with the part about the code coverage website removed. Once that part was gone, I found the remainder slightly easier to read when the options were presented the other way around, so the simpler (although s

[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Akira Li added the comment: time.time() returns the current time in seconds since Epoch it is neither local nor UTC time. It can be converted to both. You can get local time using datetime.fromtimestamp(ts). You can get UTC time using datetime.utcfromtimestamp(ts) or to get an aware datetime obj

[issue19447] py_compile.compile raises if a file has bad encoding

Roundup Robot added the comment: New changeset 2d0bcb653085 by Berker Peksag in branch '3.4': Issue #19447: Suppress output of py_compile.compile(). http://hg.python.org/cpython/rev/2d0bcb653085 New changeset a8ef9d7c4d20 by Berker Peksag in branch 'default': Issue #19447: Suppress output of py_

[issue19447] py_compile.compile raises if a file has bad encoding

Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

Changes by Terry J. Reedy : -- versions: +Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22321] odd result for datetime.time.strftime("%s")

New submission from Dima Tisnek: $ python2 -c 'import datetime; print datetime.time(10, 44, 11).strftime("%s")' -2208955189 $ python3 -c 'import datetime; print (datetime.time(10, 44, 11).strftime("%s"))' -2208955189 So apparently, datetime.time(...).strftime("%s") semantically "seconds since

[issue17396] modulefinder fails if module contains syntax error

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Python 3.5 ___ Python tracker ___ ___

[issue20020] "modernize" the modulefinder module

Changes by Berker Peksag : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20215] Python2.7 socketserver can not listen IPv6 address

Changes by Antoine Pitrou : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Antoine Pitrou added the comment: Note the .timestamp() method will work correctly if the datetime object is expressed in *local time*, which is not what Rebecka's code uses. Otherwise the incantation is a bit more complex: https://docs.python.org/3/library/datetime.html#datetime.datetime.time

[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Akira Li added the comment: timestamp() method works correctly for an aware datetime objects as in my example (notice: timezone.utc in the code). The issue is not that it is a manual computation, the issue is that it is incorrect: #XXX WRONG, DO NOT DO IT time.mktime(datetime.datetime.utcno

[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Akira Li added the comment: The last example assumes that time.gmtime(0) is 1970-01-01 00:00:00Z (otherwise time.time() may return different timestamp) -- ___ Python tracker ___

[issue22319] mailbox.MH chokes on directories without .mh_sequences

Tim Chase added the comment: I had to tweak the example reproduction code as it seemed to succeed (i.e., fail to demonstrate the problem) in some instances. The same exception occurs, but here's the full original traceback: $ cd /home/tim/.claws-mail/imapcache/mail.example.com/t...@example.c

[issue19494] urllib2.HTTPBasicAuthHandler (or urllib.request.HTTPBasicAuthHandler) doesn't work with GitHub API v3 and similar

Changes by Ian Cordasco : -- nosy: +icordasc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19494] urllib2.HTTPBasicAuthHandler (or urllib.request.HTTPBasicAuthHandler) doesn't work with GitHub API v3 and similar

Ian Cordasco added the comment: > However, one sticking point is whether that optimization may also have > adverse effects in terms of security (since we would always be sending auth > headers, even when the server doesn't ask for it...). Antoine's concern has always been a concern of mine. Th

[issue22322] Zip files created by `git archive` result in a SyntaxError (due to comment?)

New submission from Peter Wu: Files created by `git archive` are not understood by the Python interpreter. This could be caused by the additional comment (for the commit hash) in the file. echo 'print(1)' > __main__.py git init && git add __main__.py && git commit -m init git archive --format=

[issue22321] odd result for datetime.time.strftime("%s")

R. David Murray added the comment: I believe this is effectively a duplicate of issue 12750. That is, python doesn't do anything in particular with %s, it just lets the platform do what it will. Issue 12750 is about making what it does consistent and cross-platform. (On gentoo linux I get -1

[issue22322] Zip files created by `git archive` result in a SyntaxError (due to comment?)

R. David Murray added the comment: You are correct. zipimport does not support zip files with comments. There is already an open issue (issue 5950) for adding support for this. -- nosy: +r.david.murray resolution: -> duplicate stage: -> resolved status: open -> closed superseder: ->

[issue5950] Make zipimport work with zipfile containing comments

Serhiy Storchaka added the comment: See issue22322 for yet one use case ("git archive" creates ZIP file with archive comment). -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue22311] Pip 404's

Donald Stufft added the comment: Yea can you give more information? How are you reproducing this? What version of Python? I can't reproduce it locally. -- ___ Python tracker ___

[issue19494] urllib2.HTTPBasicAuthHandler (or urllib.request.HTTPBasicAuthHandler) doesn't work with GitHub API v3 and similar

Changes by Terry J. Reedy : -- nosy: -terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue22311] Pip 404's

Stefan Behnel added the comment: CPython 3.5, latest development versions. This started failing on August 21st, presumably with the changes for issue 22118. -- ___ Python tracker __

[issue21965] Add support for Memory BIO to _ssl

Antoine Pitrou added the comment: > We can leave these undocumented at the Python level if you prefer. I'd rather that indeed. If there's a specific need, we can expose them as a separate issue. > Maybe just "SSLInstance", would that be better than "SSLObject"? That doesn't sound much better

[issue22311] Pip 404's

Donald Stufft added the comment: Ok, I'll pull down Python 3.5 in a bit and see what is what. -- ___ Python tracker ___ ___ Python-bug

[issue22311] Pip 404's

Antoine Pitrou added the comment: No need to keep this open, this is tackled in issue 22278. -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker __

[issue22278] urljoin duplicate slashes

Antoine Pitrou added the comment: Those tests don't seem to bring much. Part of them are straight from the RFC (and therefore already in the current test suite, I assume), part of them are for non-HTTP protocols such as "fred" (!). A couple of them seem to be genuine, although only one fails a

[issue22293] unittest.mock: use slots in MagicMock to reduce memory footprint

Antoine Pitrou added the comment: > This means that by the end of a run, we have quite a lot of references to > MagicMocks. It sounds like you are bitten by unittest keeping references to all past TestCase instances. This has been fixed recently (see #11798). -- nosy: +pitrou ___

[issue22301] smtplib.SMTP.starttls' documentation is just confusing

Michele Orrù added the comment: "R. David Murray" writes: > Since we want to encourage people to use the context, that sounds > reasonable for 3.x at least. Concerning this specific proposition, I really don't see the point in having .starttls() not simply accepting a SSLContext as argument, a

[issue22302] Windows os.path.isabs UNC path bug

Akima added the comment: I checked for the existence of this bug in 2 other python versions today. It's present in CPython 3.4.1, but CPython 2.7.5 doesn't exhibit the issue. Python 2.7.5 (default, May 15 2013, 22:43:36) [MSC v.1500 32 bit (Intel)] on win32 Type "help", "copyright", "credits

[issue22323] Rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString()

New submission from STINNER Victor: I would like to deprecate PyUnicode_AsUnicode(), see the issue #22271 for the rationale (hint: memory footprint). The first step is to rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString() to not call PyUnicode_AsUnicode() anymore. Attached patch

[issue22271] Deprecate PyUnicode_AsUnicode(): emit a DeprecationWarning

STINNER Victor added the comment: > The deprecate PyUnicode_AsUnicode(), we should stop using it in Python itself. Here is the first step: issue #22323, "rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString()" (to not call PyUnicode_AsUnicode() anymore). -- __

[issue22154] ZipFile.open context manager support

Mike Short added the comment: Context manager comment & code snippet added to zipfile doc - patch attached. -- keywords: +patch nosy: +Mike.Short Added file: http://bugs.python.org/file36521/zipfile.patch ___ Python tracker

[issue22324] Use PyUnicode_AsWideCharString() instead of PyUnicode_AsUnicode()

New submission from STINNER Victor: I would like to deprecate PyUnicode_AsUnicode(), see the issue #22271 for the rationale (hint: memory footprint). To deprecate PyUnicode_AsUnicode(), we should stop using it internally. The attached patch is a work-in-progress patch, untested on Windows (onl

[issue22278] urljoin duplicate slashes

Demian Brecht added the comment: I'll try to get some time this week to extend the various test cases, thanks for pointing that out Antoine. I also found that, other than the few RFC-specific blocks in the link that Nick added in the other ticket, not only were they questionable (non-HTTP as A

[issue22324] Use PyUnicode_AsWideCharString() instead of PyUnicode_AsUnicode()

STINNER Victor added the comment: Oh, I didn't generated wchar.patch correctly: please ignore changes in the unicodeobject.c files. These changes are part of issues #22271 and #22323. -- ___ Python tracker ___

[issue22324] Use PyUnicode_AsWideCharString() instead of PyUnicode_AsUnicode()

STINNER Victor added the comment: wchar_posixmodule.patch: patch for posixmodule.c. Sorry, the code calling PyUnicode_AsUnicode() was not generated by Argument Clinic in fact. -- Added file: http://bugs.python.org/file36523/wchar_posixmodule.patch __

[issue22290] "AMD64 OpenIndiana 3.x" buildbot: assertion failed in PyObject_Call() in test_subprocess.test_preexec()

STINNER Victor added the comment: Oh, a lot of tests fail with MemoryError on this buildbot. It may explain this issue. For example, test_json crashed with SIGSEGV in this build, probably because of an unhandled MemoryError exception: http://buildbot.python.org/all/builders/AMD64%20OpenIndiana

[issue22166] test_codecs "leaking" references

STINNER Victor added the comment: ExceptionChainingTest uses a function to raise an arbitrary exception. Problem: the function and its parameter becomes part of the exception traceback. Shortly, the exception links indirectly to itself in a nice reference cycle... Example: --- import traceback

[issue22166] test_codecs leaks references

STINNER Victor added the comment: Attached: Draft patch to fix some reference leaks in test_codecs. -- title: test_codecs "leaking" references -> test_codecs leaks references Added file: http://bugs.python.org/file36524/test_codecs_fix1.patch ___ Pyth

[issue22166] test_codecs leaks references

STINNER Victor added the comment: ExceptionChainingTest creates a random codec name. If you change the codec name to a fixed string like "xxx", ExceptionChainingTest.test_raise_by_type() doesn't leak anymore (when test_codecs_fix1.patch is applied), but other tests start to fail. We should m

[issue19826] Document that bug reporting by email is possible

Mike Short added the comment: Addition to bugs.html to describe submitting bugs via email -- keywords: +patch nosy: +Mike.Short Added file: http://bugs.python.org/file36525/bugs.patch ___ Python tracker ___

[issue19826] Document that bug reporting by email is possible

Mike Short added the comment: Same addition to the Python Dev Guide - seemed more appropriate on the tracker page vs. the triaging page. -- Added file: http://bugs.python.org/file36526/tracker.patch ___ Python tracker

[issue19826] Document that bug reporting by email is possible

R. David Murray added the comment: I'd be just as happy to not document this. The fact that you need an account first means that people will try to submit without an account, and get a bounce. It also works better when people reply on the bug tracker rather than by email. I'd not want to ta

[issue1508475] transparent gzip compression in urllib

Martin Panter added the comment: I think the patch is indeed a bit short, for instannce it looks like calling read() without a size limit could bypass the decoding. Also, I wonder if Content-Encoding handling is better done at a higher level. What if someone wants to download a *.tar.gz file?

[issue22166] test_codecs leaks references

Antoine Pitrou added the comment: > We should maybe enhance the codecs API to be able to unregister a codec? That would be nice. At least as a private API in 3.4. -- nosy: +pitrou ___ Python tracker __

[issue22323] Rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString()

Antoine Pitrou added the comment: > Attached patch implements this. There is no patch. -- nosy: +pitrou ___ Python tracker ___ ___ Py

[issue22038] Implement atomic operations on non-x86 platforms

Changes by John Malmberg : -- nosy: +John.Malmberg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue22296] cookielib uses time.time(), making incorrect checks of expiration times in cookies

Rebecka added the comment: Akira is correct: using time.mktime to produce the expiration date for the cookie is wrong (thank you very much for the pointers!). Using e.g. http.cookiejar.http2time with a HTTP formatted date string gives a correct time stamp (with which cookie.is_expired succeeds